http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12597 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12597 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |veron@veron.ch --- Comment #2 from Marc Véron <veron@veron.ch> --- Patch does not apply: Auto-merging koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css Failed to merge in the changes. Version: 3.17.00.010 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12597 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12597 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 30224 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30224&action=edit Bug 12597 - Give better visual indication of currently-selected language in the staff client There is currently no visual feedback to the user reflecting which of multiple installed translations is currently selected. I think some necessary styling didn't make it into the conversion to Bootstrap menus. This patch attempts to improve things. Most of the changes are to bring back the previous style of highlighting the currently selected language. A new change is the addition of the sub-language code to the display of the menu label if one of that menu item's sub-languages is selected. This patch also removes some obsolete CSS which referred to the old menu system. To test, apply the patch and install or update multiple languages, including at least two sub-languages. In my test I used en, en-GB and de-DE. Clear your browser cache if necessary. Enable all these languages and test the functionality of the language selection menu in the footer. - Non-enabled languages should appear as non-bold links. - When a single language (with no sub-languages) is enabled it should appear as bold text. - When one of multiple sub-languages is enabled that selection in the pop-up menu should appear as bold text. The menu label should show in bold the language code of the selected sub-language. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12597 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30224|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12597 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 30358 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30358&action=edit [PASSED QA] Bug 12597 - Give better visual indication of currently-selected language in the staff client There is currently no visual feedback to the user reflecting which of multiple installed translations is currently selected. I think some necessary styling didn't make it into the conversion to Bootstrap menus. This patch attempts to improve things. Most of the changes are to bring back the previous style of highlighting the currently selected language. A new change is the addition of the sub-language code to the display of the menu label if one of that menu item's sub-languages is selected. This patch also removes some obsolete CSS which referred to the old menu system. To test, apply the patch and install or update multiple languages, including at least two sub-languages. In my test I used en, en-GB and de-DE. Clear your browser cache if necessary. Enable all these languages and test the functionality of the language selection menu in the footer. - Non-enabled languages should appear as non-bold links. - When a single language (with no sub-languages) is enabled it should appear as bold text. - When one of multiple sub-languages is enabled that selection in the pop-up menu should appear as bold text. The menu label should show in bold the language code of the selected sub-language. Tested with de-DE and de-CH, works as expected Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as expected, passes all tests. No problems found. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12597 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30236|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12597 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.