[Bug 26273] New: Expose cashup summary historyfor a cash register
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 Bug ID: 26273 Summary: Expose cashup summary historyfor a cash register Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org Depends on: 26272 Blocks: 13985 With bug 26172 we allow for a nicely summarised display of cash register activity for the most recent cashup action. We should somehow expose the ability to see past cashups in the same way. I'm open to suggestions on how best to expose this... one thought that came to mind was to add 'next/previous' buttons to the summary modal so you could 'scroll' through previous cashups.. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] Cash Management - Koha as 'Point of Sale' https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26272 [Bug 26272] Allow cashup summaries to be displayed from the library summary page -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26274 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26274 [Bug 26274] Expose cash register cashup summaries via an API route. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|26272 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26272 [Bug 26272] Allow cashup summaries to be displayed from the library summary page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Expose cashup summary |Expose cashup summary |historyfor a cash register |history for a cash register -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk --- Comment #1 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- This sounds like a great idea. My instinct would be to also have an index - perhaps where each linked summary is labelled with the cash up date? A bit like this: 05-01-2021 || Link to summary 01-01-2021 || Link to summary 22-12-2020 || Link to summary 15-12-2020 || Link to summary 08-12-2020 || Link to summary 01-12-2020 || Link to summary 29-11-2020 || Link to summary 26-11-2020 || Link to summary 13-11-2020 || Link to summary 04-11-2020 || Link to summary We tend to seek out previous cash ups when there's a problem, so being able to quickly view an index of that till's cash ups to find the correct session would be great. If we had 2-3 cash ups a week and we wanted to go back 6 months, just prev/next controls would be a little frustrating. Or, if it's not too much work, a data table would do the job - then we could always use the search / sort controls? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- *** Bug 26676 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Katrin Fischer 2020-10-14 12:34:55 BST At the moment when we do multiple cashups, there is no overview page to see the past ones. We can only see a bit of information on the last cash-ups. It would be nice to have a way to list cashups for a timeframe for audit and other purposes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 116176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116176&action=edit Bug 26273: Add historic cashups table to register page This patch adds a historic cashups table to the bottom of the register transaction details page. It will only display if one or more cashups have taken place and contains links to allow display of the summary detail modal for each cashup. Test plan 1/ Enable UseCashRegisters 2/ Undertake a few transactions and cashups 3/ View the 'Register details' page 4/ Note the appearance of a 'Cashup history' section at the bottom of the page 5/ Note that 'Summary' button displays the relevant modal 6/ Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I'm looking for feedback on this one now.. I'm not entirely sure about the placement of the index.. whether the register details page is the right place or whether this warrants a page of it's own (but then.. where should it be linked from and what should it be called?) The attached patch is a proof of concept for how we may achieve it however :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116176|0 |1 is obsolete| | --- Comment #6 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 116640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116640&action=edit Bug 26273: Add historic cashups table to register page This patch adds a historic cashups table to the bottom of the register transaction details page. It will only display if one or more cashups have taken place and contains links to allow display of the summary detail modal for each cashup. Test plan 1/ Enable UseCashRegisters 2/ Undertake a few transactions and cashups 3/ View the 'Register details' page 4/ Note the appearance of a 'Cashup history' section at the bottom of the page 5/ Note that 'Summary' button displays the relevant modal 6/ Signoff Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #7 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- The sign off is under my name, but both Daniel and I have been testing with it. We both really like this. We like the placement of the summaries, as we think it's easy for the staff to find and easy to use. We particularly like that the filters for the datatable show automatically, and that you can sort/search by takings as well as date. The date formatting is slightly unusual with the +00.00 at the end: e.g. 2021-02-10T10:04:56+00:00 But that's not a blocker for us - it's very useful to see the time and to be able to sort by it, in case the staff cash up multiple times in one day. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 116685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116685&action=edit Bug 26273: (follow-up) Format dates and money correctly. This patch adds the missing formatting for the Datetime and Amount fields. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Sally from comment #7)
The sign off is under my name, but both Daniel and I have been testing with it. We both really like this.
We like the placement of the summaries, as we think it's easy for the staff to find and easy to use.
We particularly like that the filters for the datatable show automatically, and that you can sort/search by takings as well as date.
The date formatting is slightly unusual with the +00.00 at the end: e.g. 2021-02-10T10:04:56+00:00
But that's not a blocker for us - it's very useful to see the time and to be able to sort by it, in case the staff cash up multiple times in one day.
Thanks for testing, and good catch on the missing formatting.. I've added a followup not to take care of both the datetime formatting and the cashup amounts. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I meant to ask.. I could probably get at the staff user name for who carried out the cashup.. would that be helpful in the index table at all too? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116640|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 116691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116691&action=edit Bug 26273: Add historic cashups table to register page This patch adds a historic cashups table to the bottom of the register transaction details page. It will only display if one or more cashups have taken place and contains links to allow display of the summary detail modal for each cashup. Test plan 1/ Enable UseCashRegisters 2/ Undertake a few transactions and cashups 3/ View the 'Register details' page 4/ Note the appearance of a 'Cashup history' section at the bottom of the page 5/ Note that 'Summary' button displays the relevant modal 6/ Signoff Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Daniel Jones <daniel.jones@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116685|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 116692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116692&action=edit Bug 26273: (follow-up) Format dates and money correctly. This patch adds the missing formatting for the Datetime and Amount fields. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 --- Comment #13 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- (In reply to Martin Renvoize from comment #10)
I meant to ask.. I could probably get at the staff user name for who carried out the cashup.. would that be helpful in the index table at all too?
If it's not too much work, that'd be great! (Or even just the borrowernumber.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116691|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 116697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116697&action=edit Bug 26273: Add historic cashups table to register page This patch adds a historic cashups table to the bottom of the register transaction details page. It will only display if one or more cashups have taken place and contains links to allow display of the summary detail modal for each cashup. Test plan 1/ Enable UseCashRegisters 2/ Undertake a few transactions and cashups 3/ View the 'Register details' page 4/ Note the appearance of a 'Cashup history' section at the bottom of the page 5/ Note that 'Summary' button displays the relevant modal 6/ Signoff Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Daniel Jones <daniel.jones@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116692|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 116698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116698&action=edit Bug 26273: (follow-up) Format dates and money correctly. This patch adds the missing formatting for the Datetime and Amount fields. Test plan 1/ Apply patch and reload register page to re-display the cashups table 2/ Note that the 'Date' field now displays a nicely formatted date without an offset. 3/ Note that the 'Amount' field now displays the number according to your money formatting preferences (with 2 decimal places in most cases) 4/ Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 116699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116699&action=edit Bug 26273: (follow-up) Add 'Cashier' to the cashups table This patch adds the 'Cashier' field as discussed on the bug report. Test plan 1/ Apply patch and reload the register page to refresh the table 2/ Note that a 'Cashier' field now appears in the table 3/ Sorting and searching on 'Cashier' should work as expected 4/ Default sorting should remain as 'Date' order. 5/ Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116699|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 116710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116710&action=edit Bug 26273: (follow-up) Add 'Cashier' to the cashups table This patch adds the 'Cashier' field as discussed on the bug report. Test plan 1/ Apply patch and reload the register page to refresh the table 2/ Note that a 'Cashier' field now appears in the table 3/ Sorting and searching on 'Cashier' should work as expected 4/ Default sorting should remain as 'Date' order. 5/ Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27680 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116697|0 |1 is obsolete| | --- Comment #18 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 116771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116771&action=edit Bug 26273: Add historic cashups table to register page This patch adds a historic cashups table to the bottom of the register transaction details page. It will only display if one or more cashups have taken place and contains links to allow display of the summary detail modal for each cashup. Test plan 1/ Enable UseCashRegisters 2/ Undertake a few transactions and cashups 3/ View the 'Register details' page 4/ Note the appearance of a 'Cashup history' section at the bottom of the page 5/ Note that 'Summary' button displays the relevant modal 6/ Signoff Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Daniel Jones <daniel.jones@cheshiresharedservices.gov.uk> Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116698|0 |1 is obsolete| | --- Comment #19 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 116772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116772&action=edit Bug 26273: (follow-up) Format dates and money correctly. This patch adds the missing formatting for the Datetime and Amount fields. Test plan 1/ Apply patch and reload register page to re-display the cashups table 2/ Note that the 'Date' field now displays a nicely formatted date without an offset. 3/ Note that the 'Amount' field now displays the number according to your money formatting preferences (with 2 decimal places in most cases) 4/ Signoff Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116710|0 |1 is obsolete| | --- Comment #20 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 116773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116773&action=edit Bug 26273: (follow-up) Add 'Cashier' to the cashups table This patch adds the 'Cashier' field as discussed on the bug report. Test plan 1/ Apply patch and reload the register page to refresh the table 2/ Note that a 'Cashier' field now appears in the table 3/ Sorting and searching on 'Cashier' should work as expected 4/ Default sorting should remain as 'Date' order. 5/ Signoff Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 --- Comment #21 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- Both patches work as expected - cashier field, and date/time. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The dependency patch is not yet signed off - moving to BLOCKED for the moment until that is sorted. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27779 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 [Bug 27779] Cashup summary 'refunds' should denote what the refund was actioned against. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|13985 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] Cash Management - Koha as 'Point of Sale' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116771|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 117449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117449&action=edit Bug 26273: Add historic cashups table to register page This patch adds a historic cashups table to the bottom of the register transaction details page. It will only display if one or more cashups have taken place and contains links to allow display of the summary detail modal for each cashup. Test plan 1/ Enable UseCashRegisters 2/ Undertake a few transactions and cashups 3/ View the 'Register details' page 4/ Note the appearance of a 'Cashup history' section at the bottom of the page 5/ Note that 'Summary' button displays the relevant modal 6/ Signoff Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Daniel Jones <daniel.jones@cheshiresharedservices.gov.uk> Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116772|0 |1 is obsolete| | --- Comment #24 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 117450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117450&action=edit Bug 26273: (follow-up) Format dates and money correctly. This patch adds the missing formatting for the Datetime and Amount fields. Test plan 1/ Apply patch and reload register page to re-display the cashups table 2/ Note that the 'Date' field now displays a nicely formatted date without an offset. 3/ Note that the 'Amount' field now displays the number according to your money formatting preferences (with 2 decimal places in most cases) 4/ Signoff Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116773|0 |1 is obsolete| | --- Comment #25 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 117451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117451&action=edit Bug 26273: (follow-up) Add 'Cashier' to the cashups table This patch adds the 'Cashier' field as discussed on the bug report. Test plan 1/ Apply patch and reload the register page to refresh the table 2/ Note that a 'Cashier' field now appears in the table 3/ Sorting and searching on 'Cashier' should work as expected 4/ Default sorting should remain as 'Date' order. 5/ Signoff Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 --- Comment #26 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Rebased against the now PQA dependency bug and set status back to SO -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Some small things: 1) If there is no first name for the "cashier" the table will display "null", for example: null koha. A lot of libraries may use "functional" accounts where this is a likely scneario. 2) Quite nit-picky (I know!)... the heading "Cashup history" is really close to the "Details" button and further away form the table, much further than the heading of the same label to the table above. I think this does make it a little hard to understand the table structure at a quick glance. Overall this works well, failing for 1) but happy to get something for 2)! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 --- Comment #28 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 117787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117787&action=edit Bug 26273: (QA follow-up) Check for null firstname This patch adds a test for firstname being defined before constructing fullname from it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #29 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #27)
Some small things:
1) If there is no first name for the "cashier" the table will display "null", for example: null koha. A lot of libraries may use "functional" accounts where this is a likely scenario.
Fixed in followup
2) Quite nit-picky (I know!)... the heading "Cashup history" is really close to the "Details" button and further away form the table, much further than the heading of the same label to the table above. I think this does make it a little hard to understand the table structure at a quick glance.
This appears to be something funky in the API driven datatables wrapper.. as such I'm tempted to open a distinct bug about it rather than fix it here as it'll affect both here, the Cities management page and the orders tables. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 --- Comment #30 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 117793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117793&action=edit Bug 26273: (QA follow-up) Remove unrequired table_controls div Looks like a copy/paste issue.. I don't believe we need this div at all for the table to function as expected and adding it just creates uneeded whitespace. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 --- Comment #31 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Martin Renvoize from comment #29)
This appears to be something funky in the API driven datatables wrapper.. as such I'm tempted to open a distinct bug about it rather than fix it here as it'll affect both here, the Cities management page and the orders tables.
I take that back.. somehow a spare div crept into the source in this template.. I've removed it in a followup :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #32 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Still stuck with the nulls, sorry! Also a little extra space between heading and "Display" could be nice. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117787|0 |1 is obsolete| | --- Comment #33 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 117809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117809&action=edit Bug 26273: (QA follow-up) Check for null firstname This patch adds a test for firstname being defined before constructing fullname from it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117793|0 |1 is obsolete| | --- Comment #34 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 117810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117810&action=edit Bug 26273: (QA follow-up) Remove unrequired table_controls div Looks like a copy/paste issue.. I don't believe we need this div at all for the table to function as expected and adding it just creates uneeded whitespace. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 --- Comment #35 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 117811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117811&action=edit Bug 26273: (QA follow-up) Add horizontal rule to distinguish tables -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #36 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- try now -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117449|0 |1 is obsolete| | --- Comment #37 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 117829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117829&action=edit Bug 26273: Add historic cashups table to register page This patch adds a historic cashups table to the bottom of the register transaction details page. It will only display if one or more cashups have taken place and contains links to allow display of the summary detail modal for each cashup. Test plan 1/ Enable UseCashRegisters 2/ Undertake a few transactions and cashups 3/ View the 'Register details' page 4/ Note the appearance of a 'Cashup history' section at the bottom of the page 5/ Note that 'Summary' button displays the relevant modal 6/ Signoff Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Daniel Jones <daniel.jones@cheshiresharedservices.gov.uk> Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117450|0 |1 is obsolete| | --- Comment #38 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 117830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117830&action=edit Bug 26273: (follow-up) Format dates and money correctly. This patch adds the missing formatting for the Datetime and Amount fields. Test plan 1/ Apply patch and reload register page to re-display the cashups table 2/ Note that the 'Date' field now displays a nicely formatted date without an offset. 3/ Note that the 'Amount' field now displays the number according to your money formatting preferences (with 2 decimal places in most cases) 4/ Signoff Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117451|0 |1 is obsolete| | --- Comment #39 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 117831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117831&action=edit Bug 26273: (follow-up) Add 'Cashier' to the cashups table This patch adds the 'Cashier' field as discussed on the bug report. Test plan 1/ Apply patch and reload the register page to refresh the table 2/ Note that a 'Cashier' field now appears in the table 3/ Sorting and searching on 'Cashier' should work as expected 4/ Default sorting should remain as 'Date' order. 5/ Signoff Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117809|0 |1 is obsolete| | --- Comment #40 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 117832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117832&action=edit Bug 26273: (QA follow-up) Check for null firstname This patch adds a test for firstname being defined before constructing fullname from it. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117810|0 |1 is obsolete| | --- Comment #41 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 117833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117833&action=edit Bug 26273: (QA follow-up) Remove unrequired table_controls div Looks like a copy/paste issue.. I don't believe we need this div at all for the table to function as expected and adding it just creates uneeded whitespace. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117811|0 |1 is obsolete| | --- Comment #42 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 117834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117834&action=edit Bug 26273: (QA follow-up) Add horizontal rule to distinguish tables Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #43 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- + return data.escapeHtml(); It explodes if data is not defined (see bug 25293 for instance). I think we should move the JS function '_escape_str' out of in acqui/parcel.tt to have it available from anywhere. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 --- Comment #44 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #43)
+ return data.escapeHtml();
It explodes if data is not defined (see bug 25293 for instance).
I think we should move the JS function '_escape_str' out of in acqui/parcel.tt to have it available from anywhere.
staff-global.js perhaps.. or a new variable_filter.js perhaps? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 --- Comment #45 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 118125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118125&action=edit Bug 26273: (QA follow-up) Use _escape_str/price for escaping This patch moves the _escape_str and _escape_price functions into the staff-global js include and then uses them in the register page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #46 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- staff-global already includes the afore used escapeHtml prototype extensions and is loaded on all pages... seemed good choice. Tested change in register page and on parcel page too... all working still. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds a release notes| |cashup history table at the | |bottom of the register | |details page. You can then | |use this table to display | |the full summary for any | |cashup that has taken place | |at this cash register. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 --- Comment #47 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I am sorry Martin but I think this patch must be moved to its own bug report for backport. Maybe also remove the '_'? I can do it if you want me to. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 --- Comment #48 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I can do it.. I was just hoping to avoid holding this bug up with another SO + QA cycle on a new bug. Alas, I do agree with you really though. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27930 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27930 [Bug 27930] Move _escape_* functions from acq/parcel.tt to be re-usable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118125|0 |1 is obsolete| | --- Comment #49 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 118129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118129&action=edit Bug 26273: (QA follow-up) Use _escape_str/price for escaping This patch moves the _escape_str and _escape_price functions into the staff-global js include and then uses them in the register page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 --- Comment #50 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Done, bug 27930 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 --- Comment #51 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 118130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118130&action=edit Bug 26273: (QA follow-up) Use escape_str/price for escaping This patch uses the global escape_str/escape_price functions in the register page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118129|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 --- Comment #52 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Just a rewording of the commit message to account for most of the actual change being moved to another bug ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117829|0 |1 is obsolete| | Attachment #117830|0 |1 is obsolete| | Attachment #117831|0 |1 is obsolete| | Attachment #117832|0 |1 is obsolete| | Attachment #117833|0 |1 is obsolete| | Attachment #117834|0 |1 is obsolete| | Attachment #118130|0 |1 is obsolete| | --- Comment #53 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 118149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118149&action=edit Bug 26273: Add historic cashups table to register page This patch adds a historic cashups table to the bottom of the register transaction details page. It will only display if one or more cashups have taken place and contains links to allow display of the summary detail modal for each cashup. Test plan 1/ Enable UseCashRegisters 2/ Undertake a few transactions and cashups 3/ View the 'Register details' page 4/ Note the appearance of a 'Cashup history' section at the bottom of the page 5/ Note that 'Summary' button displays the relevant modal 6/ Signoff Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Daniel Jones <daniel.jones@cheshiresharedservices.gov.uk> Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Bug 26273: (QA follow-up) Remove unrequired table_controls div Looks like a copy/paste issue.. I don't believe we need this div at all for the table to function as expected and adding it just creates uneeded whitespace. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Bug 26273: (QA follow-up) Add horizontal rule to distinguish tables Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 --- Comment #54 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 118150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118150&action=edit Bug 26273: (follow-up) Format dates and money correctly. This patch adds the missing formatting for the Datetime and Amount fields. Test plan 1/ Apply patch and reload register page to re-display the cashups table 2/ Note that the 'Date' field now displays a nicely formatted date without an offset. 3/ Note that the 'Amount' field now displays the number according to your money formatting preferences (with 2 decimal places in most cases) 4/ Signoff Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 --- Comment #55 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 118151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118151&action=edit Bug 26273: (follow-up) Add 'Cashier' to the cashups table This patch adds the 'Cashier' field as discussed on the bug report. Test plan 1/ Apply patch and reload the register page to refresh the table 2/ Note that a 'Cashier' field now appears in the table 3/ Sorting and searching on 'Cashier' should work as expected 4/ Default sorting should remain as 'Date' order. 5/ Signoff Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Bug 26273: (QA follow-up) Check for null firstname This patch adds a test for firstname being defined before constructing fullname from it. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 --- Comment #56 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 118152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118152&action=edit Bug 26273: (QA follow-up) Use escape_str/price for escaping This patch uses the global escape_str/escape_price functions in the register page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 --- Comment #57 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #58 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 20.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 Bug 26273 depends on bug 27680, which changed state. Bug 27680 Summary: API DataTables Wrapper fails for ordering on multi-data-field columns https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 Bug 26273 depends on bug 27930, which changed state. Bug 27930 Summary: Move _escape_* functions from acq/parcel.tt to be re-usable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27930 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 --- Comment #59 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 120403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120403&action=edit Bug 28273: Unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 --- Comment #60 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 120404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120404&action=edit Bug 28273: Add Koha::Biblios->pickup_locations -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120403|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120404|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org