[Bug 26469] New: Register_id saves incorrect value in accountlnes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26469 Bug ID: 26469 Summary: Register_id saves incorrect value in accountlnes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org To recreate: - turn on cash registers in sysprefs - define at least 2 cash registers in Admin - create a manual invoice on a patron - pay off half of your fee, selecting the first register - pay off the remaining fee, selecting the second register - query accountlines.register_id for your two payments - see that they both show the first register confirmed in master and 19.11. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26469 --- Comment #1 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Verified that the register is recorded incorrectly regardless of which pay button one uses (Pay, Pay Selected, or Pay Amount) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26469 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26469 Eric Swenson <tech@salinapublic.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tech@salinapublic.org --- Comment #2 from Eric Swenson <tech@salinapublic.org> --- I can also confirm that paying a total line from a different register, other than ID=1, did not log that in the table. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26469 --- Comment #3 from Eric Swenson <tech@salinapublic.org> --- We are very new to community koha (just migrated this past weekend) and this is one of those features that excites us the most since we see the potential to make reporting "End of Day" totals a breeze. We currently have 2 primary locations that take payments that stay separate from each other and it would very helpful to group those locations using these register_id rather than our previous method of searching for all the possible manager_ids that might be taking payments at that location. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26469 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Eric, thx for adding more details to this bug report and welcome to the Koha community! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26469 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26469 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26469 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Welcome to the Commmunity Eric. I developed the cash management handling in Koha and we're still refining it with the key stakeholders here so watch this space for further enhancements which may be of interest to you. Thanks for reporting the bug Andrew; I'm on the case now.. if feels like a regression since the original push as I'm confident we tested this functionality back then :(. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26469 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110160&action=edit Bug 26269: Fix variable name mismatch for cash_register in paycollect It appears that through various rebases the variable names in the form and the controller script have become mismatched. This patch corrects the situation and clarifies their intended use. Test plan: 1/ Turn on cash registers in sysprefs 2/ Define at least 2 cash registers in Admin 3/ Create a manual invoice on a patron 4/ Pay off half of your fee, selecting the first register 5/ Pay off the remaining fee, selecting the second register 6/ Query accountlines.register_id for your two payments 8/ Confirm the two accountlines.register_id's do not match (thus the passed variable was used) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26469 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26469 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24786 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24786 [Bug 24786] Allow setting a cash register for a login session -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26469 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Also rebased bug 24786 atop this.. might be a nice enhancement to test once this one is done. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26469 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26469 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110160|0 |1 is obsolete| | --- Comment #8 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 110173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110173&action=edit Bug 26269: Fix variable name mismatch for cash_register in paycollect It appears that through various rebases the variable names in the form and the controller script have become mismatched. This patch corrects the situation and clarifies their intended use. Test plan: 1/ Turn on cash registers in sysprefs 2/ Define at least 2 cash registers in Admin 3/ Create a manual invoice on a patron 4/ Pay off half of your fee, selecting the first register 5/ Pay off the remaining fee, selecting the second register 6/ Query accountlines.register_id for your two payments 8/ Confirm the two accountlines.register_id's do not match (thus the passed variable was used) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26469 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110173|0 |1 is obsolete| | --- Comment #9 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 110182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110182&action=edit Bug 26269: Fix variable name mismatch for cash_register in paycollect It appears that through various rebases the variable names in the form and the controller script have become mismatched. This patch corrects the situation and clarifies their intended use. Test plan: 1/ Turn on cash registers in sysprefs 2/ Define at least 2 cash registers in Admin 3/ Create a manual invoice on a patron 4/ Pay off half of your fee, selecting the first register 5/ Pay off the remaining fee, selecting the second register 6/ Query accountlines.register_id for your two payments 8/ Confirm the two accountlines.register_id's do not match (thus the passed variable was used) https://bugs.koha-community.org/show_bug.cgi?id=26469 Signed-off-by: Jessie Zairo <jzairo@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26469 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Register_id saves incorrect |Register_id saves incorrect |value in accountlnes |value in accountlines -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26469 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26469 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110182|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 110230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110230&action=edit Bug 26269: Fix variable name mismatch for cash_register in paycollect It appears that through various rebases the variable names in the form and the controller script have become mismatched. This patch corrects the situation and clarifies their intended use. Test plan: 1/ Turn on cash registers in sysprefs 2/ Define at least 2 cash registers in Admin 3/ Create a manual invoice on a patron 4/ Pay off half of your fee, selecting the first register 5/ Pay off the remaining fee, selecting the second register 6/ Query accountlines.register_id for your two payments 8/ Confirm the two accountlines.register_id's do not match (thus the passed variable was used) https://bugs.koha-community.org/show_bug.cgi?id=26469 Signed-off-by: Jessie Zairo <jzairo@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26469 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Passed QA |Pushed to master --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26469 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Wrong bug number in commit message, caught too late. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26469 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- That will require manual editing of the release notes!(In reply to Jonathan Druart from comment #12)
Wrong bug number in commit message, caught too late.
Note to RMaints: this will require manual editing of the release notes so this fix shows up and not the wrong one! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26469 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |RELEASE NOTE ADJUSTMENT release notes| |NEEDED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26469 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26469 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org