[Bug 32065] New: Invalid for some system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32065 Bug ID: 32065 Summary: Invalid for some system preferences Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: victor@tuxayo.net QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Follow up are needed here after bug 31952 and bug 31886 CI caught this: (https://jenkins.koha-community.org/view/master/job/Koha_Master_U18/1639/cons...) koha_1 | # Failed test '/kohadevbox/koha/xt/../koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/serials.pref is YAML' koha_1 | # at xt/yaml_valid.t line 41. koha_1 | koha_1 | # Failed test '/kohadevbox/koha/xt/../koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/local_use.pref is YAML' koha_1 | # at xt/yaml_valid.t line 41. koha_1 | koha_1 | # Failed test '/kohadevbox/koha/xt/../koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/i18n_l10n.pref is YAML' koha_1 | # at xt/yaml_valid.t line 41. koha_1 | # Looks like you failed 3 tests of 17. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32065 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31952, 31886 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 [Bug 31886] No side menu when searching for syspref https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31952 [Bug 31952] Sending an empty system preference search breaks layout -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32065 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|31886, 31952 | Depends on| |31886, 31952 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 [Bug 31886] No side menu when searching for syspref https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31952 [Bug 31952] Sending an empty system preference search breaks layout -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32065 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Invalid for some system |Invalid YAML for some |preferences |system preferences -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32065 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The test isn't failing for me on master. Is this maybe fixed already? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32065 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32065 --- Comment #2 from Victor Grousset/tuxayo <victor@tuxayo.net> --- It's only happening the Ubuntu 18.04 on the CI Which I also happen to use, let's try. Confirmed! Maybe the YAML is valid and the particular version of the OS of the failing build has a bug. Checking against external tools and YAML specs might be needed to be sure what's wrong. root@kohadevbox:koha((2200b4aa3d...))$ prove xt/yaml_valid.t xt/yaml_valid.t .. 1/18 # Failed test '/kohadevbox/koha/xt/../koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/i18n_l10n.pref is YAML' # at xt/yaml_valid.t line 41. # Failed test '/kohadevbox/koha/xt/../koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/serials.pref is YAML' # at xt/yaml_valid.t line 41. # Failed test '/kohadevbox/koha/xt/../koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/local_use.pref is YAML' # at xt/yaml_valid.t line 41. # Looks like you failed 3 tests of 18. xt/yaml_valid.t .. Dubious, test returned 3 (wstat 768, 0x300) Failed 3/18 subtests Test Summary Report ------------------- xt/yaml_valid.t (Wstat: 768 Tests: 18 Failed: 3) Failed tests: 9, 15, 17 Non-zero exit status: 3 Files=1, Tests=18, 1 wallclock secs ( 0.03 usr 0.00 sys + 0.62 cusr 0.02 csys = 0.67 CPU) Result: FAIL -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32065 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Victor Grousset/tuxayo from comment #2)
It's only happening the Ubuntu 18.04 on the CI Which I also happen to use, let's try.
Confirmed! Maybe the YAML is valid and the particular version of the OS of the failing build has a bug. Checking against external tools and YAML specs might be needed to be sure what's wrong.
root@kohadevbox:koha((2200b4aa3d...))$ prove xt/yaml_valid.t xt/yaml_valid.t .. 1/18 # Failed test '/kohadevbox/koha/xt/../koha-tmpl/intranet-tmpl/prog/en/modules/admin/ preferences/i18n_l10n.pref is YAML' # at xt/yaml_valid.t line 41.
# Failed test '/kohadevbox/koha/xt/../koha-tmpl/intranet-tmpl/prog/en/modules/admin/ preferences/serials.pref is YAML' # at xt/yaml_valid.t line 41.
# Failed test '/kohadevbox/koha/xt/../koha-tmpl/intranet-tmpl/prog/en/modules/admin/ preferences/local_use.pref is YAML' # at xt/yaml_valid.t line 41. # Looks like you failed 3 tests of 18. xt/yaml_valid.t .. Dubious, test returned 3 (wstat 768, 0x300) Failed 3/18 subtests
Test Summary Report ------------------- xt/yaml_valid.t (Wstat: 768 Tests: 18 Failed: 3) Failed tests: 9, 15, 17 Non-zero exit status: 3 Files=1, Tests=18, 1 wallclock secs ( 0.03 usr 0.00 sys + 0.62 cusr 0.02 csys = 0.67 CPU) Result: FAIL
Hm I cannot test that. How should we proceed here and does only the test fail or are there also issues in the GUI? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32065 --- Comment #4 from Victor Grousset/tuxayo <victor@tuxayo.net> ---
Hm I cannot test that
This should work: cd stuff/cats/world-domination-plan/koha-testing-docker-directory ; KOHA_IMAGE=master-bionic bin/ktd up
How should we proceed here and does only the test fail or are there also issues in the GUI?
Good question, I didn't check which UI action access this data. Even if it's a bug in the version of some YAML lib in Ubuntu 18.04 (and so the YAML is valid) it's possible that it causes an issue when Koha on Ubuntu 18.04 tries to access the data with that same lib. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32065 Bug 32065 depends on bug 31886, which changed state. Bug 31886 Summary: No side menu when searching for syspref https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32065 Bug 32065 depends on bug 31952, which changed state. Bug 31952 Summary: Sending an empty system preference search breaks layout https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31952 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org