[Bug 31879] New: Convert mainpage.css to SCSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31879 Bug ID: 31879 Summary: Convert mainpage.css to SCSS Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Now that we are making more use of SCSS variables it would be efficient to be able to use them in mainpage.css where some common colors are specified. Plus any additional auto-minification we can do is helpful. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31879 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31879 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 142199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142199&action=edit Bug 31879: Convert mainpage.css to SCSS This patch creates a new SCSS file to be used to generate mainpage.css, the stylesheet used specifically for the staff interface home page. The patch makes visible changes in only two places: Removing borders from two elements to make them consistent with the new staff interface design: - div.pending-info, where pending actions like patrons requesting modifications are shown. - div#area-userblock, where the contents of the IntranetmainUserblock system preference are displayed. Otherwise the changes are all for the purpose of properly nesting elements according to SCSS rules and other fixes related to stylelint rules. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). View the main page of the staff interface. Everything should look like it did before except for those elements which have had their borders removed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31879 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31879 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142199|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 142203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142203&action=edit Bug 31879: Convert mainpage.css to SCSS This patch creates a new SCSS file to be used to generate mainpage.css, the stylesheet used specifically for the staff interface home page. The patch makes visible changes in only two places: Removing borders from two elements to make them consistent with the new staff interface design: - div.pending-info, where pending actions like patrons requesting modifications are shown. - div#area-userblock, where the contents of the IntranetmainUserblock system preference are displayed. Otherwise the changes are all for the purpose of properly nesting elements according to SCSS rules and other fixes related to stylelint rules. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). View the main page of the staff interface. Everything should look like it did before except for those elements which have had their borders removed. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31879 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Testing notes (using koha-testing-docker): - Added a purchase suggestion to show the pending area. - Added some text to IntranetmainUserblock system preference. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31879 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31879 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142203|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 142458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142458&action=edit Bug 31879: Convert mainpage.css to SCSS This patch creates a new SCSS file to be used to generate mainpage.css, the stylesheet used specifically for the staff interface home page. The patch makes visible changes in only two places: Removing borders from two elements to make them consistent with the new staff interface design: - div.pending-info, where pending actions like patrons requesting modifications are shown. - div#area-userblock, where the contents of the IntranetmainUserblock system preference are displayed. Otherwise the changes are all for the purpose of properly nesting elements according to SCSS rules and other fixes related to stylelint rules. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). View the main page of the staff interface. Everything should look like it did before except for those elements which have had their borders removed. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31879 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31879 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31879 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31879 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org