[Bug 29103] New: reserves.desk_id for desk of waiting hold only updates when printing new hold sip
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29103 Bug ID: 29103 Summary: reserves.desk_id for desk of waiting hold only updates when printing new hold sip Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 24412 To recreate: - turn on UseCirculationDesks and define at least 2 for your library - set yourself to a desk using "Set library and desk" - place a hold for pickup at your library - check the item in, confirm the hold and print slip - check reserves.desk_id, see it has updated to the desk you're at - change your desk - check the item in again, click Confirm - check reserves.desk_id, see it has not changed - check the item in a third again, click Confirm and Print Slip - check reserves.desk_id again, see it has changed Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 [Bug 24412] Attach waiting hold to desk -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29103 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|reserves.desk_id for desk |reserves.desk_id for desk |of waiting hold only |of waiting hold only |updates when printing new |updates when printing new |hold sip |hold slip -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29103 Nicolas Legrand <nicolas.legrand@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicolas.legrand@bulac.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29103 Nicolas Legrand <nicolas.legrand@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29103 --- Comment #1 from Nicolas Legrand <nicolas.legrand@bulac.fr> --- Thanks a lot Andrew! My colleagues just pointed me this one yesterday. I may try to fix it, but I'll have soon a new child so I'm not sure I'll have time to work on this one before November. I'll try next week. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29103 Nicolas Legrand <nicolas.legrand@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29103 --- Comment #2 from Nicolas Legrand <nicolas.legrand@bulac.fr> --- Created attachment 129546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129546&action=edit Bug 29103: Change desk when checking in a waiting reserve A check in should relocate a waiting hold under the current desk. But the current behaviour when confirming the hold is to dismiss the modal, the item is still attached to the preceding desk. This patch mimicks the print and confirm behaviour to trigger the desk change. Plan test: 1. Add some desks to you library (syspref UseCirculationDesks and Administration -> Patrons and circulation -> Circulation desks. 2. Set a desk in your session (Circulation -> Set library and desk) 3. Have some waiting hold attach to a desk (make a hold on a checked out item and return it). 4. Change your current desk. 5. Check in again the item, click on confirm. 6. Go to the item notice detail, it appears as waiting at your first desk. 7. Apply patch. 8. Check in again the item. 9. go to the item notice detail, it should appear at your current desk. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29103 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29103 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129546|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 129648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129648&action=edit Bug 29103: Change desk when checking in a waiting reserve A check in should relocate a waiting hold under the current desk. But the current behaviour when confirming the hold is to dismiss the modal, the item is still attached to the preceding desk. This patch mimicks the print and confirm behaviour to trigger the desk change. Plan test: 1. Add some desks to you library (syspref UseCirculationDesks and Administration -> Patrons and circulation -> Circulation desks. 2. Set a desk in your session (Circulation -> Set library and desk) 3. Have some waiting hold attach to a desk (make a hold on a checked out item and return it). 4. Change your current desk. 5. Check in again the item, click on confirm. 6. Go to the item notice detail, it appears as waiting at your first desk. 7. Apply patch. 8. Check in again the item. 9. go to the item notice detail, it should appear at your current desk. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29103 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I don't really understand the change. Isn't it weird to force the submission when the button has a data-dismiss="modal"? Shouldn't we remove this "dismiss" attribute instead? We had lot of regressions on this page, I am a bit reluctant to submit when we were supposed not to... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29103 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nicolas.legrand@bulac.fr |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29103 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129648|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 132194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132194&action=edit Bug 29103: Change desk when checking in a waiting reserve A check in should relocate a waiting hold under the current desk. But the current behaviour when confirming the hold is to dismiss the modal, the item is still attached to the preceding desk. This patch mimicks the print and confirm behaviour to trigger the desk change. Plan test: 1. Add some desks to you library (syspref UseCirculationDesks and Administration -> Patrons and circulation -> Circulation desks. 2. Set a desk in your session (Circulation -> Set library and desk) 3. Have some waiting hold attach to a desk (make a hold on a checked out item and return it). 4. Change your current desk. 5. Check in again the item, click on confirm. 6. Go to the item notice detail, it appears as waiting at your first desk. 7. Apply patch. 8. Check in again the item. 9. go to the item notice detail, it should appear at your current desk. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29103 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Good catch, simple fix, works and no regressions found. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29103 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29103 --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29103 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.11.05 released in| | CC| |kyle@bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.11.x for 21.11.05 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org