[Bug 30251] New: With IndependentBranches non-superlibrarians do not get autocomplete list in circulation module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30251 Bug ID: 30251 Summary: With IndependentBranches non-superlibrarians do not get autocomplete list in circulation module Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: januszop@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Having IndependentBranches on, a librarian who is not superlibrarian does not get a autocomplete hint list when entering a part of the patron's name (while performing check out, etc.) Koha registers an error: DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Column 'branchcode' in where clause is ambiguous at .../Koha/Objects.pm line 312 This is due to fix to the bug 10902 -- addig "prefetch => 'branchcode'" to the attributes of the query in circ/ysearch.pl, while having branchcode in the search parameters. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30251 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |januszop@gmail.com |ity.org | Status|NEW |Needs Signoff --- Comment #1 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 131503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131503&action=edit Bug 30251: (bug 10902 follow-up) With IndependentBranches non-superlibrarians do not get autocomplete list in circulation module Having IndependentBranches on, a librarian who is not superlibrarian does not get a autocomplete hint list when entering a part of the patron's name (while performing check out, etc.) Koha registers an error: DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Column 'branchcode' in where clause is ambiguous at .../Koha/Objects.pm line 312 This is due to fix to the bug 10902 -- addig "prefetch => 'branchcode'" to the attributes of the query in circ/ysearch.pl, while having branchcode in the search parameters. Test plan: ---------- 1. Have IndependentBranches on. Be a librarian without superlibrarian privileges. Have some patrons defined. 2. In the main input field on the top, with Check out active, try to put 3+ characters from the known user name/cardnumber etc. You will get no hint. 3. Apply the patch. 4. Repeat 2. You should now see an autocomplete hint list. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30251 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 Patch complexity|--- |Trivial patch CC| |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30251 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131503|0 |1 is obsolete| | --- Comment #2 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 131504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131504&action=edit Bug 30251: (bug 10902 follow-up) With IndependentBranches non-superlibrarians do not get autocomplete list in circulation module Having IndependentBranches on, a librarian who is not superlibrarian does not get a autocomplete hint list when entering a part of the patron's name (while performing check out, etc.) Koha registers an error: DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Column 'branchcode' in where clause is ambiguous at .../Koha/Objects.pm line 312 This is due to fix to the bug 10902 -- addig "prefetch => 'branchcode'" to the attributes of the query in circ/ysearch.pl, while having branchcode in the search parameters. Test plan: ---------- 1. Have IndependentBranches on, PatronAutoComplete set to 'Try. Be a librarian without superlibrarian privileges. Have some patrons defined. 2. In the main input field on the top, with Check out active, try to put 3+ characters from the known user name/cardnumber etc. You will get no hint. 3. Apply the patch. 4. Repeat 2. You should now see an autocomplete hint list. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30251 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10902 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10902 [Bug 10902] Highlight patrons from logged-in library in patron searches -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30251 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30251 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131504|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 131509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131509&action=edit Bug 30251: (bug 10902 follow-up) With IndependentBranches non-superlibrarians do not get autocomplete list in circulation module Having IndependentBranches on, a librarian who is not superlibrarian does not get a autocomplete hint list when entering a part of the patron's name (while performing check out, etc.) Koha registers an error: DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Column 'branchcode' in where clause is ambiguous at .../Koha/Objects.pm line 312 This is due to fix to the bug 10902 -- addig "prefetch => 'branchcode'" to the attributes of the query in circ/ysearch.pl, while having branchcode in the search parameters. Test plan: ---------- 1. Have IndependentBranches on, PatronAutoComplete set to 'Try. Be a librarian without superlibrarian privileges. Have some patrons defined. 2. In the main input field on the top, with Check out active, try to put 3+ characters from the known user name/cardnumber etc. You will get no hint. 3. Apply the patch. 4. Repeat 2. You should now see an autocomplete hint list. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30251 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major Keywords| |rel_21_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30251 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131509|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 132184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132184&action=edit Bug 30251: (bug 10902 follow-up) With IndependentBranches non-superlibrarians do not get autocomplete list in circulation module Having IndependentBranches on, a librarian who is not superlibrarian does not get a autocomplete hint list when entering a part of the patron's name (while performing check out, etc.) Koha registers an error: DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Column 'branchcode' in where clause is ambiguous at .../Koha/Objects.pm line 312 This is due to fix to the bug 10902 -- addig "prefetch => 'branchcode'" to the attributes of the query in circ/ysearch.pl, while having branchcode in the search parameters. Test plan: ---------- 1. Have IndependentBranches on, PatronAutoComplete set to 'Try. Be a librarian without superlibrarian privileges. Have some patrons defined. 2. In the main input field on the top, with Check out active, try to put 3+ characters from the known user name/cardnumber etc. You will get no hint. 3. Apply the patch. 4. Repeat 2. You should now see an autocomplete hint list. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30251 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Works as expected, no regressions found. PQA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30251 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30251 --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30251 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|22.05.00 |22.05.00,21.11.05 released in| | CC| |kyle@bywatersolutions.com --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.11.x for 21.11.05 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org