[Bug 19692] New: Unclosed div in opac-shelves.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19692 Bug ID: 19692 Summary: Unclosed div in opac-shelves.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: victor.grousset@biblibre.com QA Contact: testopia@bugs.koha-community.org It was found when customizing an instance. The comment makes it clear that it should be a closing tag. http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=koha-tmpl/opac-tmp... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19692 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |victor.grousset@biblibre.co | |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19692 --- Comment #1 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- Created attachment 69336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69336&action=edit Bug 19692 : fix unclosed div in opac-shelves.tt Test plan: 1. set syspref OpacKohaUrl to "Show" 2. Log into the OPAC 3. /cgi-bin/koha/opac-shelves.pl 4. Notice that "Powered by Koha" is not in the footer in this page. When on the other tabs it's in the footer (out of .main) 5. Apply this patch 6. Notice that "Powered by Koha" now in the footer in the "your lists" page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19692 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19692 Dominic Pichette <dominic.pichette@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69336|0 |1 is obsolete| | --- Comment #2 from Dominic Pichette <dominic.pichette@inlibro.com> --- Created attachment 69337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69337&action=edit Bug 19692 : fix unclosed div in opac-shelves.tt Test plan: 1. set syspref OpacKohaUrl to "Show" 2. Log into the OPAC 3. /cgi-bin/koha/opac-shelves.pl 4. Notice that "Powered by Koha" is not in the footer in this page. When on the other tabs it's in the footer (out of .main) 5. Apply this patch 6. Notice that "Powered by Koha" now in the footer in the "your lists" page Signed-off-by: Dominic Pichette <dominic@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19692 Dominic Pichette <dominic.pichette@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |dominic.pichette@inlibro.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19692 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19692 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69337|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 69376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69376&action=edit Bug 19692 : fix unclosed div in opac-shelves.tt Test plan: 1. set syspref OpacKohaUrl to "Show" 2. Log into the OPAC 3. /cgi-bin/koha/opac-shelves.pl 4. Notice that "Powered by Koha" is not in the footer in this page. When on the other tabs it's in the footer (out of .main) 5. Apply this patch 6. Notice that "Powered by Koha" now in the footer in the "your lists" page Signed-off-by: Dominic Pichette <dominic@inlibro.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19692 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19692 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69376|0 |1 is obsolete| | --- Comment #4 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- Created attachment 69379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69379&action=edit Bug 19692 : fix unclosed div in opac-shelves.tt Test plan: 1. set syspref OpacKohaUrl to "Show" 2. Log into the OPAC 3. /cgi-bin/koha/opac-shelves.pl 4. Notice that "Powered by Koha" is not in the footer in this page. When on the other tabs it's in the footer (out of .main) 5. Apply this patch 6. Notice that "Powered by Koha" now in the footer in the "your lists" page Signed-off-by: Dominic Pichette <dominic@inlibro.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19692 --- Comment #5 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- I've changed the author of the commit to Simon Pouchol (the work was on my machine). That might be their first contribution to the codebase, that's why it might matters :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19692 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Passed QA |Pushed to Master --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Patch has been pushed to master for 18.05. Congratulations Simon for your first patch in! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19692 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|victor.grousset@biblibre.co |simon.pouchol@biblibre.com |m | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19692 --- Comment #7 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- Hooray :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19692 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Pushed to Master |Pushed to Stable --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Pushed to stable for 17.11.01, awesome work all! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19692 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #9 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in v17.05.07 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org