[Bug 19533] New: Hold pulldown for itemtype is empty if hold placement needs override
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19533 Bug ID: 19533 Summary: Hold pulldown for itemtype is empty if hold placement needs override Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com To recreate: 1) Enable AllowHoldPolicyOverride 2) Enable AllowHoldItemTypeSelection 3) Create a situation where adding a hold for a patron would trigger a tooManyReserves warning. 4) Note the itemtype pulldown is empty -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19533 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19533 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19533 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 68593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68593&action=edit Bug 19533 - Hold pulldown for itemtype is empty if hold placement needs override Test Plan: 1) Enable AllowHoldPolicyOverride 2) Enable AllowHoldItemTypeSelection 3) Create a situation where adding a hold for a patron would trigger a tooManyReserves warning. 4) Note the itemtype pulldown is empty 5) Apply this patch 6) Reload the page 7) Itemtype pulldown should have values -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19533 Andreas Hedström Mace <andreas.hedstrom.mace@sub.su.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |andreas.hedstrom.mace@sub.s | |u.se --- Comment #2 from Andreas Hedström Mace <andreas.hedstrom.mace@sub.su.se> --- Even after applying the patch, the itemtype dropdown remains empty when a staff override is required. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19533 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19533 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68593|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 68723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68723&action=edit Bug 19533 - Hold pulldown for itemtype is empty if hold placement needs override Test Plan: 1) Enable AllowHoldPolicyOverride 2) Enable AllowHoldItemTypeSelection 3) Create a situation where adding a hold for a patron would trigger a tooManyReserves warning. 4) Note the itemtype pulldown is empty 5) Apply this patch 6) Reload the page 7) Itemtype pulldown should have values -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19533 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19533 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19533 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68723|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 68805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68805&action=edit Bug 19533 - Hold pulldown for itemtype is empty if hold placement needs override Test Plan: 1) Enable AllowHoldPolicyOverride 2) Enable AllowHoldItemTypeSelection 3) Create a situation where adding a hold for a patron would trigger a tooManyReserves warning. 4) Note the itemtype pulldown is empty 5) Apply this patch 6) Reload the page 7) Itemtype pulldown should have values Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19533 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19533 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68805|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 69372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69372&action=edit Bug 19533 - Hold pulldown for itemtype is empty if hold placement needs override Test Plan: 1) Enable AllowHoldPolicyOverride 2) Enable AllowHoldItemTypeSelection 3) Create a situation where adding a hold for a patron would trigger a tooManyReserves warning. 4) Note the itemtype pulldown is empty 5) Apply this patch 6) Reload the page 7) Itemtype pulldown should have values Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19533 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19533 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19533 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |nick@bywatersolutions.com --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Pushed to stable for 17.11.01, awesome work all! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19533 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #8 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in v17.05.07 Looks like the same code is in if and else now, strange o_O -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org