[Bug 41778] New: Broken display of not for loan status on item detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41778 Bug ID: 41778 Summary: Broken display of not for loan status on item detail page Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org On the item details page the section heading, which shows the barcode or item number, is supposed to also show the not for loan status if there is one. The way the template variables are defined the status cannot be shown. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41778 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41778 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41778 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 192538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192538&action=edit Bug 41778: Fix broken display of not for loan status on item detail page This patch makes some corrections to the way the item detail page template defines and display an item's not for loan status. To test you must have at least one not-for-loan item attached to a bibliographic record. - If necessary, edit an item to set a "Not for loan" status. - View the bibliographic detail page for that item's record. - Click the "Items" tab from the bibliographic detail page. - Find the section on the page showing the item you edited. - You should see "Barcode XXXX" (or "Item number XXXX") along with the not for loan status you defined. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41778 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41778 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192538|0 |1 is obsolete| | --- Comment #2 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 192543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192543&action=edit Bug 41778: Fix broken display of not for loan status on item detail page This patch makes some corrections to the way the item detail page template defines and display an item's not for loan status. To test you must have at least one not-for-loan item attached to a bibliographic record. - If necessary, edit an item to set a "Not for loan" status. - View the bibliographic detail page for that item's record. - Click the "Items" tab from the bibliographic detail page. - Find the section on the page showing the item you edited. - You should see "Barcode XXXX" (or "Item number XXXX") along with the not for loan status you defined. Sponsored-by: Athens County Public Libraries Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41778 Anneli Österman <anneli.osterman@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anneli.osterman@koha-suomi. | |fi --- Comment #3 from Anneli Österman <anneli.osterman@koha-suomi.fi> --- I don't think the Not for loan status has ever been shown after the barcode in Items tab. Has it always been broken? I think it has always been shown after the "Statuses" heading. See the picture attached. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41778 --- Comment #4 from Anneli Österman <anneli.osterman@koha-suomi.fi> --- Created attachment 192903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192903&action=edit Not for loan status after Statuses heading -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41778 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192543|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41778 --- Comment #5 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 195703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195703&action=edit Bug 41778: Fix broken display of not for loan status on item detail page This patch makes some corrections to the way the item detail page template defines and display an item's not for loan status. To test you must have at least one not-for-loan item attached to a bibliographic record. - If necessary, edit an item to set a "Not for loan" status. - View the bibliographic detail page for that item's record. - Click the "Items" tab from the bibliographic detail page. - Find the section on the page showing the item you edited. - You should see "Barcode XXXX" (or "Item number XXXX") along with the not for loan status you defined. Sponsored-by: Athens County Public Libraries Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41778 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |emily.lamancusa@montgomeryc | |ountymd.gov --- Comment #6 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- (In reply to Anneli Österman from comment #3)
I don't think the Not for loan status has ever been shown after the barcode in Items tab. Has it always been broken?
I think it has always been shown after the "Statuses" heading. See the picture attached.
Apparently a minor typo broke it in 2022 and no one noticed until now! Good catch, Owen! Before that typo, it was showing in both places (like it does with Owen's patch). This looks good to me - passing QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41778 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk Text to go in the| |This patch makes some release notes| |corrections to the way the | |item detail page template | |defines and display an | |item's not for loan status. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41778 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41778 --- Comment #7 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Thanks for all the hard work! Pushed to main for the next 26.05.00 release as RM Assistant -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41778 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41778 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00 |26.05.00,25.11.05 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41778 --- Comment #8 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org