[Bug 41760] New: Fix <tbody> and <tfoot> in several templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41760 Bug ID: 41760 Summary: Fix <tbody> and <tfoot> in several templates Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org There was a time when the W3C wanted us to put <tfoot> betwee, <thead> and <tbody>, but they have changed their minds. There are a few pages which still have the <tfoot> in that position which triggers a validator error. There are also several instances of <tfoot> in tables which lack a <tbody>, which I'm also fixing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41760 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41760 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41760 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 192396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192396&action=edit Bug 41760: Fix <tbody> and <tfoot> in several templates This patch makes corrections to table markup in several templates, fixing these issues: - <tfoot> appearing before <tbody> - <tfoot> appearing without a <tbody> To test, apply the patch and view the following pages in the staff client. In each case the table should look correct, including the appearance of the table footer. - Acquisitions -> Vendor -> Basket. Add orders to a basket if necessary, in order for the "Orders" table to appear. - Acquisitions -> Vendor -> Basket -> Add to basket -> From existing orders (copy) -> Search for orders. You must have existing orders to populate the table of order search results. - Acquisitions -> Vendor -> Receive shipments -> Receive a new shipment. You must have pending orders to populate the table. Receive at least one order to ensure data for the next step. - Acquisitions home page -> "All available funds" table -> Click an amount linked in the "Spent" column. - Administration -> Funds. You must have at least one budget and at least one fund under that budget. - Administration -> Record overlay rules. - Patrons -> View a patron record -> Accounting -> Transactions. If necessary you can use "Create manual invoice" to add a charge to the account. - From the list of transactions, click the "Pay" button next to one of them. - Reports -> Cash register statistics wizard. - ?? - Reports -> Catalog by item type. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41760 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192396|0 |1 is obsolete| | CC| |emmi.takkinen@koha-suomi.fi --- Comment #2 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 192534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192534&action=edit Bug 41760: Fix <tbody> and <tfoot> in several templates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41760 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Works as expected on pages changed in the patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41760 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com --- Comment #4 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Testing notes - Acquisitions -> Vendor -> Basket. Add orders to a basket if necessary, in order for the "Orders" table to appear. => Ok - Acquisitions -> Vendor -> Basket -> Add to basket -> From existing orders (copy) -> Search for orders. You must have existing orders to populate the table of order search results. => Ok - Acquisitions -> Vendor -> Receive shipments -> Receive a new shipment. You must have pending orders to populate the table. Receive at least one order to ensure data for the next step. => Ok - Acquisitions home page -> "All available funds" table -> Click an amount linked in the "Spent" column. => Ok - Administration -> Funds. You must have at least one budget and at least one fund under that budget. => Ok - Administration -> Record overlay rules. => Ok - Patrons -> View a patron record -> Accounting -> Transactions. If necessary you can use "Create manual invoice" to add a charge to the account. - From the list of transactions, click the "Pay" button next to one of them. => Ok - Reports -> Cash register statistics wizard. - ?? -> This array http://koha-ktd:8081/cgi-bin/koha/reports/cash_register_stats.pl?from=2026-04-09&to=2026-04-09&transaction_type=ACT&branch=ALL&output=screen&basename=Export&do_it=Submit, it is fine - Reports -> Catalog by item type. -> Ok -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41760 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |baptiste.wojtkowski@biblibr |y.org |e.com Sponsorship status|--- |Sponsored Status|Signed Off |Passed QA Comma delimited| |Athens County Public list of Sponsors| |Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41760 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192534|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41760 --- Comment #5 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 197003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197003&action=edit Bug 41760: Fix <tbody> and <tfoot> in several templates This patch makes corrections to table markup in several templates, fixing these issues: - <tfoot> appearing before <tbody> - <tfoot> appearing without a <tbody> To test, apply the patch and view the following pages in the staff client. In each case the table should look correct, including the appearance of the table footer. - Acquisitions -> Vendor -> Basket. Add orders to a basket if necessary, in order for the "Orders" table to appear. - Acquisitions -> Vendor -> Basket -> Add to basket -> From existing orders (copy) -> Search for orders. You must have existing orders to populate the table of order search results. - Acquisitions -> Vendor -> Receive shipments -> Receive a new shipment. You must have pending orders to populate the table. Receive at least one order to ensure data for the next step. - Acquisitions home page -> "All available funds" table -> Click an amount linked in the "Spent" column. - Administration -> Funds. You must have at least one budget and at least one fund under that budget. - Administration -> Record overlay rules. - Patrons -> View a patron record -> Accounting -> Transactions. If necessary you can use "Create manual invoice" to add a charge to the account. - From the list of transactions, click the "Pay" button next to one of them. - Reports -> Cash register statistics wizard. - ?? - Reports -> Catalog by item type. Sponsored-by: Athens County Public Libraries Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41760 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41760 --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41760 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00 |26.05.00,25.11.05 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41760 --- Comment #7 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org