[Bug 34402] New: Sorting holds on patron account includes articles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34402 Bug ID: 34402 Summary: Sorting holds on patron account includes articles Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: kkrueger@cuyahogalibrary.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Created attachment 153892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153892&action=edit SortHoldsScreenShot When sorting checkouts by title on a patron's account, articles are ignored. When sorting holds by title, articles are included. It would be great if the holds tab of a patron's account also ignored articles (a, an, the) when sorting by title. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34402 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Version|unspecified |master Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34402 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34402 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 153923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153923&action=edit Bug 34402: Sorting holds on patron account includes articles This patch adds some configuration to the table of holds shown on the checkout and patron detail pages so that sorting by title correctly excludes articles. To test, apply the patch and clear your browser cache. - Check out to a patron who has multiple holds on titles which include leading articles like "a" "an" and "the." - Click the holds tab and click the "title" column to sort by title. - The titles should be correctly sorted alphabetically while ignoring articles. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34402 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34402 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153923|0 |1 is obsolete| | --- Comment #2 from Sam Lau <samalau@gmail.com> --- Created attachment 154129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154129&action=edit Bug 34402: Sorting holds on patron account includes articles This patch adds some configuration to the table of holds shown on the checkout and patron detail pages so that sorting by title correctly excludes articles. To test, apply the patch and clear your browser cache. - Check out to a patron who has multiple holds on titles which include leading articles like "a" "an" and "the." - Click the holds tab and click the "title" column to sort by title. - The titles should be correctly sorted alphabetically while ignoring articles. Signed-off-by: Sam Lau <samalau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34402 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34402 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154129|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 154135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154135&action=edit Bug 34402: Sorting holds on patron account includes articles This patch adds some configuration to the table of holds shown on the checkout and patron detail pages so that sorting by title correctly excludes articles. To test, apply the patch and clear your browser cache. - Check out to a patron who has multiple holds on titles which include leading articles like "a" "an" and "the." - Click the holds tab and click the "title" column to sort by title. - The titles should be correctly sorted alphabetically while ignoring articles. Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34402 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34402 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34402 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34402 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Bug description describes the problem. But the commit message should describe the solution, ie : "Exclude articles from title when sorting holds on patron account" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34402 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.04 released in| | --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34402 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33528 Status|Pushed to stable |RESOLVED CC| |matt.blenkinsop@ptfs-europe | |.com Resolution|--- |FIXED --- Comment #7 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- patron-detail-tabs.inc does not exist in 22.11.x as bug 33528 was not backported - unable to backport to 22.11.x Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33528 [Bug 33528] Use template wrapper for tabs: Patron details and circulation -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org