[Bug 32765] New: Retry transfer after cancelling hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32765 Bug ID: 32765 Summary: Retry transfer after cancelling hold Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Circulation Assignee: julian.maurice@biblibre.com Reporter: julian.maurice@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com When trying to manually transfer an item that is on hold, we have the choice to cancel the hold and try the transfer again. When choosing this option, the hold is correctly cancelled but the transfer is not tried again. Steps to reproduce: 1. Place a hold on a specific item 2. Try to transfer it manually (Circulation » Transfer) 3. Choose the option to "Cancel hold and then attempt transfer" 4. See that the hold was cancelled, but no transfer was made -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32765 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 145839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145839&action=edit Bug 32765: Retry transfer after cancelling hold When trying to manually transfer an item that is on hold, we have the choice to cancel the hold and try the transfer again. When choosing this option, the hold is correctly cancelled but the transfer is not tried again. This patch fixes that Test plan: 1. Place a hold on a specific item 2. Try to transfer it manually (Circulation » Transfer) 3. Choose the option to "Cancel hold and then attempt transfer" 4. See that the hold was cancelled, but no transfer was made 5. Apply the patch 6. Repeat step 1-3 7. See that the hold was cancelled, and the transfer was made -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32765 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32765 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Retry transfer after |Transfer is not retried |cancelling hold |after cancelling hold -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32765 --- Comment #2 from Julian Maurice <julian.maurice@biblibre.com> --- Regression apparently caused by: 6ac4542948c451595a154a5467e548a43e9817e8 Bug 27064: (QA follow-up) Do not create transfer prior to accepting it -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32765 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32765 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27064 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 [Bug 27064] Transferring an item with a hold allows the user to set a hold waiting without transferring to the correct branch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32765 --- Comment #3 from Fridolin Somers <fridolin.somers@biblibre.com> --- I'm on applying on 21.11.x : Looks like Bug 31781 made some move in koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32765 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31781 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32765 --- Comment #4 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 145915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145915&action=edit Bug 32765: [21.11.x] Retry transfer after cancelling hold When trying to manually transfer an item that is on hold, we have the choice to cancel the hold and try the transfer again. When choosing this option, the hold is correctly cancelled but the transfer is not tried again. This patch fixes that Test plan: 1. Place a hold on a specific item 2. Try to transfer it manually (Circulation » Transfer) 3. Choose the option to "Cancel hold and then attempt transfer" 4. See that the hold was cancelled, but no transfer was made 5. Apply the patch 6. Repeat step 1-3 7. See that the hold was cancelled, and the transfer was made -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32765 Stina Hallin <stina.hallin@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stina.hallin@ub.lu.se --- Comment #5 from Stina Hallin <stina.hallin@ub.lu.se> --- Found some code bits in the GUI, at the Transfer items page: ======= >>>>>>> Bug 32765: [21.11.x] Retry transfer after cancelling hold, and Transfer item to Fairfield: <<<<<<< HEAD, and ======= >>>>>>> Bug 32765: [21.11.x] Retry transfer after cancelling hold. Didn't manage to see that the transfer was made after clicking Cancel reservation and then attempt transfer:, maybe I didn't chose pickup location the way I should have. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32765 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- These are merge markers. There is a separate patch attached here for master and 21.11, which makes this not testable in a sandbox. On master, only the first patch needs to be applied. I wonder if there is a way we could make this work better, if we need patches for different versions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32765 Nicolas Giraud <nicolas.giraud@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145839|0 |1 is obsolete| | --- Comment #7 from Nicolas Giraud <nicolas.giraud@inlibro.com> --- Created attachment 150801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150801&action=edit Bug 32765: Retry transfer after cancelling hold When trying to manually transfer an item that is on hold, we have the choice to cancel the hold and try the transfer again. When choosing this option, the hold is correctly cancelled but the transfer is not tried again. This patch fixes that Test plan: 1. Place a hold on a specific item 2. Try to transfer it manually (Circulation » Transfer) 3. Choose the option to "Cancel hold and then attempt transfer" 4. See that the hold was cancelled, but no transfer was made 5. Apply the patch 6. Repeat step 1-3 7. See that the hold was cancelled, and the transfer was made Signed-off-by: Nicolas Giraud <nicolas.giraud@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32765 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #8 from David Nind <david@davidnind.com> --- Hi Nicolas. Another one for you to change the status to Signed Off, so that you get the credit on the dashboard. 8-) David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32765 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |samalau@gmail.com Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32765 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32765 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145915|0 |1 is obsolete| | --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Comment on attachment 145915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145915 Bug 32765: [21.11.x] Retry transfer after cancelling hold I set 21.11 patch obsolete so the one for master can be tested. We will recreate a version for backported after pushed master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32765 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Applies on current master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32765 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32765 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150801|0 |1 is obsolete| | --- Comment #11 from Sam Lau <samalau@gmail.com> --- Created attachment 152528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152528&action=edit Bug 32765: Retry transfer after cancelling hold When trying to manually transfer an item that is on hold, we have the choice to cancel the hold and try the transfer again. When choosing this option, the hold is correctly cancelled but the transfer is not tried again. This patch fixes that Test plan: 1. Place a hold on a specific item 2. Try to transfer it manually (Circulation » Transfer) 3. Choose the option to "Cancel hold and then attempt transfer" 4. See that the hold was cancelled, but no transfer was made 5. Apply the patch 6. Repeat step 1-3 7. See that the hold was cancelled, and the transfer was made Signed-off-by: Nicolas Giraud <nicolas.giraud@inlibro.com> Signed-off-by: Sam Lau <samalau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32765 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32765 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32765 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152528|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 154073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154073&action=edit Bug 32765: Retry transfer after cancelling hold When trying to manually transfer an item that is on hold, we have the choice to cancel the hold and try the transfer again. When choosing this option, the hold is correctly cancelled but the transfer is not tried again. This patch fixes that Test plan: 1. Place a hold on a specific item 2. Try to transfer it manually (Circulation » Transfer) 3. Choose the option to "Cancel hold and then attempt transfer" 4. See that the hold was cancelled, but no transfer was made 5. Apply the patch 6. Repeat step 1-3 7. See that the hold was cancelled, and the transfer was made Signed-off-by: Nicolas Giraud <nicolas.giraud@inlibro.com> Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32765 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32765 --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32765 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.04 released in| | Status|Pushed to master |Pushed to stable --- Comment #14 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32765 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.11.00,23.05.04 |23.11.00,23.05.04,22.11.10 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32765 --- Comment #15 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org