https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18211 --- Comment #1 from Christopher Brannon <cbrannon@cdalibrary.org> --- Created attachment 60997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60997&action=edit Bug 18211: Corrected intended id's in jquery. To test: 1) Checkout items - if you can, have items checked out from previous day too, but not necessary. 2) Review source code and see that the ids on the <tr> and <td> for cells containing "Today's checkouts" and "Previous checkouts" labels have some crazy ids with partial html tags (strong) and other unnecessary elements. 3) Apply patch. 4) Examine source code again and see a better and smaller id. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18211 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley@catalyst.net.nz Status|Needs Signoff |In Discussion --- Comment #2 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Hi Christopher I am still seeing partial html tags in the ids for todays checkout and previous checkouts with your patch applied, for example: var RENEWALS_REMAINING = _("%s of %s renewals remaining"); var HOLD_IS_SUSPENDED = _("Hold is <strong>suspended</strong>"); var UNTIL = _("until %s"); var NEXT_AVAILABLE_ITYPE = _("Next available %s item"); var ITEM_IS_WAITING = _("Item is <strong>waiting</strong>"); var ITEM_IS_WAITING_HERE = _("Item is <strong>waiting here</strong>"); var AT = _("at %s"); var ITEM_IS_IN_TRANSIT = _("Item is <strong>in transit</strong> from %s since %s"); Can you please clarify your test plan further to clarify if this is intended or not -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18211 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60997|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 78989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78989&action=edit Bug 18211: Corrected intended id's in jquery. To test: 1) Checkout items - if you can, have items checked out from previous day too, but not necessary. 2) Review source code and see that the ids on the <tr> and <td> for cells containing "Today's checkouts" and "Previous checkouts" labels have some crazy ids with partial html tags (strong) and other unnecessary elements. 3) Apply patch. 4) Examine source code again and see a better and smaller id. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18211 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78989|0 |1 is obsolete| | --- Comment #4 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 79001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79001&action=edit Bug 18211: Corrected intended id's in jquery. To test: 1) Checkout items - if you can, have items checked out from previous day too, but not necessary. 2) Review source code and see that the ids on the <tr> and <td> for cells containing "Today's checkouts" and "Previous checkouts" labels have some crazy ids with partial html tags (strong) and other unnecessary elements. 3) Apply patch. 4) Examine source code again and see a better and smaller id. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18211 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Changes made to jquery.dataTables.rowGrouping.js will be overwritten when we will upgrade to a newer version, we should not modify these jQuery plugins. What is your need exactly? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18211 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- This is not clear to me, switching back to Signed off to get other opinions. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18211 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #9 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Jonathan Druart from comment #5)

... we should not modify these jQuery plugins.

I agree. If this is a dependency, then we shouldn't be tweaking it. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18211 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Jonathan Druart from comment #5)

Changes made to jquery.dataTables.rowGrouping.js will be overwritten when we will upgrade to a newer version, we should not modify these jQuery plugins.

Agreed. While I was focusing on the effect of the patch I wasn't looking at how the changes were made -- my bad. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18211 --- Comment #13 from Christopher Brannon <cbrannon@cdalibrary.org> --- I think I am going to scrap this bug altogether. Id's seem to be created by jquery.dataTables.rowGrouping.js, which is an outside library that was written in 2013. I am not seeing a newer version of it. There are other scripts written for row grouping. In particular, one that appears to be active is: https://cdn.datatables.net/v/dt/dt-1.10.18/rg-1.0.3/datatables.min.js This is a bit beyond me in tackling a project like this. If someone else wants to see if this particular script would work and improve on the id's, that would be great. For now, I am unable to do so. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18211 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|cbrannon@cdalibrary.org |koha-bugs@lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.