[Bug 36291] New: Scrolling glitch on ILL batches table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36291 Bug ID: 36291 Summary: Scrolling glitch on ILL batches table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com CC: pedro.amorim@ptfs-europe.com On testing bug 36130, I found that scrolling had some glitch (at least on my computer, Firefox on ARM64 macOS). I used the following command to fill the DB with several batches: ``` PERL5LIB=$PERL5LIB:./lib perl fake_data.pl --how-many 100 --entity ill for x in {1..21}; do echo "INSERT INTO illbatches (name, backend, library_id, status_code, patron_id) VALUES ('$x', 'FreeForm', 'CPL', 'NEW', 52);"; done | koha-mysql kohadev ``` -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36291 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|NEW |ASSIGNED Depends on| |36130 Assignee|koha-bugs@lists.koha-commun |pedro.amorim@ptfs-europe.co |ity.org |m Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36130 [Bug 36130] ILL batches table not showing all batches -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36291 --- Comment #1 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Hi Tomas, thanks for this. I'm unable to look at it properly but will as soon as I can. It seems you're running 2 different commands, one for requests data and one for batches data. This shouldn't cause any issue, but it's not something I've done before. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36291 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Pedro Amorim from comment #1)
Hi Tomas, thanks for this. I'm unable to look at it properly but will as soon as I can. It seems you're running 2 different commands, one for requests data and one for batches data. This shouldn't cause any issue, but it's not something I've done before.
Heh, I think I'm just used to run it before doing ILL things on my dev env. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36291 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36291 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Steps to reproduce: 1. Have a fresh KTD 2. Run: $ ktd --shell k$ bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) k$ cd k$ git clone https://github.com/ammopt/koha-ill-dev.git k$ cd koha-ill-dev/ k$ sudo apt install libdata-faker-perl libtext-lorem-perl k$ PERL5LIB=$PERL5LIB:./lib perl fake_data.pl --how-many 200 --entity ill k$ for x in {1..21}; do echo "INSERT INTO illbatches (name, backend, library_id, status_code, patron_id) VALUES ('$x', 'FreeForm', 'CPL', 'NEW', 52);"; done | koha-mysql kohadev 3. Go to /cgi-bin/koha/ill/ill-requests.pl?method=batch_list 4. Scroll down => FAIL: Koha is your enemy! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36291 Bug 36291 depends on bug 36130, which changed state. Bug 36130 Summary: ILL batches table not showing all batches https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36130 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36291 --- Comment #4 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Can reproduce (only on Firefox tho, it doesn't happen in Chrome). Firefox throws this console entry: This site appears to use a scroll-linked positioning effect. This may not work well with asynchronous panning; see https://firefox-source-docs.mozilla.org/performance/scroll-linked_effects.ht... for further details and to join the discussion on related tools and features! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36291 Bug 36291 depends on bug 36130, which changed state. Bug 36130 Summary: ILL batches table not showing all batches https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36130 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36291 Bug 36291 depends on bug 36130, which changed state. Bug 36130 Summary: ILL batches table not showing all batches https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36130 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36291 Slava Shishkin <slavashishkin@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |slavashishkin@gmail.com --- Comment #5 from Slava Shishkin <slavashishkin@gmail.com> --- We probably have a very similar issue, with any DataTables elements with sticky header. Here we found a reference from another reporter, even with video: https://www.datatables.net/forums/discussion/74201 https://www.youtube.com/watch?v=u0_N_GRL--M it's tricky to reproduce, it should be some coincidence of data/table size and window size, so this kinda of pixel-hunting sometimes, but it happens, and it is present and reported by our librarians a lot. We temporarily solved this by disabling "fixedHeader": koha-tmpl/intranet-tmpl/prog/js/datatables.js 53: "fixedHeader": true, -> 53: "fixedHeader": false, but this is only a workaround. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36291 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36291 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber@kit.edu --- Comment #6 from Michaela Sieber <michaela.sieber@kit.edu> --- (In reply to Slava Shishkin from comment #5)
We probably have a very similar issue, with any DataTables elements with sticky header.
Here we found a reference from another reporter, even with video: https://www.datatables.net/forums/discussion/74201 https://www.youtube.com/watch?v=u0_N_GRL--M
it's tricky to reproduce, it should be some coincidence of data/table size and window size, so this kinda of pixel-hunting sometimes, but it happens, and it is present and reported by our librarians a lot.
We temporarily solved this by disabling "fixedHeader":
koha-tmpl/intranet-tmpl/prog/js/datatables.js 53: "fixedHeader": true,
->
53: "fixedHeader": false,
but this is only a workaround.
We agree, this seems to be a problem anywhere in Koha where DataTables elements with sticky headers are used, for example when using batch deletion of items of a biblio (/cgi-bin/koha/tools/batchMod.pl) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36291 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Scrolling glitch on ILL |Scrolling glitch on |batches table |datatables with fixed | |header CC| |oleonard@myacpl.org Component|ILL |Templates --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am moving this to the "Templates" component. I have confirmed the issue on the batch item edit page and seen it on others as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36291 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW Assignee|pedro.amorim@ptfs-europe.co |oleonard@myacpl.org |m | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36291 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major CC| |fridolin.somers@biblibre.co | |m --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Changing importance to major because end of the page can not be accessed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36291 --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Can this be linked to Bug 35810 ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36291 --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Found this: https://stackoverflow.com/questions/72177644/datatables-fixedheader-gets-con... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36291 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36291 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |baptiste.wojtkowski@biblibr | |e.com CC| |baptiste.wojtkowski@biblibr | |e.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36291 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bibliothek@th-wildau.de --- Comment #11 from Jan Kissig <bibliothek@th-wildau.de> --- I confirm this issue for Firefox (Ubuntu). Chrome browser is not affected in my case. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36291 --- Comment #12 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- according to this thread: https://datatables.net/forums/discussion/76463/missing-versions-or-fix-of-fi..., it looks like it should be fixed by upgrading fixedheader and one css change. I tested it on my machine and this fixed the problem, we need to update the proper dependency in order to fix this one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36291 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=36640 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36291 --- Comment #13 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- We have two choices, either try and update fixedHeader or work on Bug 36640 to update all debendencies -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36291 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- One sounds much bigger than the other. In terms of being able to backport - maybe we should do both? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36291 --- Comment #15 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 171962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171962&action=edit Bug 36291: Update fixedHeader to v4.0.1 On testing bug 36130, I found that scrolling had some glitch (at least on my computer, Firefox on ARM64 macOS). I used the following command to fill the DB with several batches: ``` PERL5LIB=$PERL5LIB:./lib perl fake_data.pl --how-many 100 --entity ill for x in {1..21}; do echo "INSERT INTO illbatches (name, backend, library_id, status_code, patron_id) VALUES ('$x', 'FreeForm', 'CPL', 'NEW', 52);"; done | koha-mysql kohadev ``` In order to solve this bug, we decided to update fixedHeader to v4.0.1 TEST PLAN: 1. Have a fresh KTD 2. Run: $ ktd --shell k$ bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) k$ cd k$ git clone https://github.com/ammopt/koha-ill-dev.git k$ cd koha-ill-dev/ k$ sudo apt install libdata-faker-perl libtext-lorem-perl k$ PERL5LIB=$PERL5LIB:./lib perl fake_data.pl --how-many 200 --entity ill k$ for x in {1..21}; do echo "INSERT INTO illbatches (name, backend, library_id, status_code, patron_id) VALUES ('$x', 'FreeForm', 'CPL', 'NEW', 52);"; done | koha-mysql kohadev 3. Go to /cgi-bin/koha/ill/ill-requests.pl?method=batch_list 4. Scroll down => FAIL: Koha is your enemy! 5. Apply patch and refresh cache from server 6. Go to /cgi-bin/koha/ill/ill-requests.pl?method=batch_list Koha and you signed a peace treaty! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36291 --- Comment #16 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Note: From the patch, it looks like there are a lot of little changes, but the workflow for this update was: deleting the whole concerned part and replace with files found here: https://cdn.datatables.net/fixedheader/4.0.1/ //cdn.datatables.net/fixedheader/4.0.1/js/dataTables.fixedHeader.js and //cdn.datatables.net/fixedheader/4.0.1/css/fixedHeader.dataTables.css -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36291 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36291 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171962|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 172022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172022&action=edit Bug 36291: Update fixedHeader to v4.0.1 On testing bug 36130, I found that scrolling had some glitch (at least on my computer, Firefox on ARM64 macOS). I used the following command to fill the DB with several batches: ``` PERL5LIB=$PERL5LIB:./lib perl fake_data.pl --how-many 100 --entity ill for x in {1..21}; do echo "INSERT INTO illbatches (name, backend, library_id, status_code, patron_id) VALUES ('$x', 'FreeForm', 'CPL', 'NEW', 52);"; done | koha-mysql kohadev ``` In order to solve this bug, we decided to update fixedHeader to v4.0.1 TEST PLAN: 1. Have a fresh KTD 2. Run: $ ktd --shell k$ bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) k$ cd k$ git clone https://github.com/ammopt/koha-ill-dev.git k$ cd koha-ill-dev/ k$ sudo apt install libdata-faker-perl libtext-lorem-perl k$ PERL5LIB=$PERL5LIB:./lib perl fake_data.pl --how-many 200 --entity ill k$ for x in {1..21}; do echo "INSERT INTO illbatches (name, backend, library_id, status_code, patron_id) VALUES ('$x', 'FreeForm', 'CPL', 'NEW', 52);"; done | koha-mysql kohadev 3. Go to /cgi-bin/koha/ill/ill-requests.pl?method=batch_list 4. Scroll down => FAIL: Koha is your enemy! 5. Apply patch and refresh cache from server 6. Go to /cgi-bin/koha/ill/ill-requests.pl?method=batch_list Koha and you signed a peace treaty! Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36291 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36291 --- Comment #18 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Works well for me, thanks Baptiste. Signing off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36291 --- Comment #19 from Jan Kissig <bibliothek@th-wildau.de> --- I applied the patch on ktd running main but the glitch still remains for me on http://localhost:8081/cgi-bin/koha/acqui/parcel.pl What I did: - created several orders but have not automated it yet - on the given page parcel.pl with more shipments than the screen can show I try to scroll down but it still glitches - yarn build - flush_memcached - restart_all - still glitches when scrolling Did I miss something? Using Firefox 130 on Kubuntu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36291 --- Comment #20 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Hi, Have you reloaded all caches from navigator ? Can you please open a firefox console and type "fn.dataTable.FixedHeader.version" to check the update has been performed ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36291 --- Comment #21 from Jan Kissig <bibliothek@th-wildau.de> --- Cache should be emptied in browser as my WebDevTools were open with no caching acivated. This is the output from fn.dataTable.FixedHeader.version fn.dataTable.FixedHeader.version Uncaught ReferenceError: fn is not defined <anonymous> debugger eval code:1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36291 --- Comment #22 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- You get this on the glitching page ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36291 --- Comment #23 from Jan Kissig <bibliothek@th-wildau.de> --- unfortunately yes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36291 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@gmail.com --- Comment #24 from Jonathan Druart <jonathan.druart@gmail.com> --- I think we should provide the min files here (datatables.min.css, datatables.min.js). They should be generated using DT's official website: https://datatables.net/download/ FixedHeader Sticky header and / or footer for the table. v4.0.1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36291 --- Comment #25 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #24)
I think we should provide the min files here (datatables.min.css, datatables.min.js). They should be generated using DT's official website:
https://datatables.net/download/
FixedHeader Sticky header and / or footer for the table. v4.0.1
Owen, can you please confirm this? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36291 Anni Rajala <anni.rajala@turku.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anni.rajala@turku.fi -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36291 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36291 --- Comment #26 from Jonathan Druart <jonathan.druart@gmail.com> --- Please focus on bug 36640 if you want to see this fixed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36291 --- Comment #27 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Jonathan Druart from comment #26)
Please focus on bug 36640 if you want to see this fixed.
Bug 36640 is now pushed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36291 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |DUPLICATE --- Comment #28 from Jonathan Druart <jonathan.druart@gmail.com> --- *** This bug has been marked as a duplicate of bug 36640 *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36291 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=37024 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org