https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22755 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |josef.moravec@gmail.com |ity.org | Depends on| |22603, 16149 Status|NEW |ASSIGNED --- Comment #1 from Josef Moravec <josef.moravec@gmail.com> --- Bug 22603 added Koha::Script module to create some userenv when running commands/cronjobs. Patron emailer cronjob from bug 16149 was written before, so it is missing this import. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149 [Bug 16149] Generate and send custom notices based on report output https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22603 [Bug 22603] Move boilerplate into Koha::Cron class -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22755 --- Comment #3 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 88402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88402&action=edit Bug 22755: Import Koha::Script into patron_emailer cronjob Test plan: Run patron_emailer.pl cronjob to ensure it is not broken after this patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22755 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22755 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88403|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 88525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88525&action=edit Bug 22755: Fix pod in patron_emailer.pl Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22755 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Good catch Josef.. going straight for PQA as it's a trivial patch. Also, I'm going to log an issue to add a check for a 'use Koha::Script' statement in the QA tools for anything under /scripts -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22755 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22755 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00 released in| | Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Dependency not in 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.