https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22749 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch CC| |tomascohen@gmail.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22749 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 88385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88385&action=edit Bug 22749: Make Koha::Item->hidden_in_opac respect hidelostitems This patch makes Koha::Item->hidden_in_opac take hidelostitems into account when performing the calculation. To test: - Apply the regression tests patch - Run: $ kshell k$ prove t/db_dependent/Koha/Item.t => FAIL: Tests fail because the code doesn't (yet) care about the syspref - Apply this patch - Run: k$ prove t/db_dependent/Koha/Item.t => SUCCESS: Tests pass! - Sign off :-D -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22749 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88384|0 |1 is obsolete| | Attachment #88385|0 |1 is obsolete| | --- Comment #3 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 88387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88387&action=edit Bug 22749: Regression tests for Koha::Item->hidden_in_opac This patch introduces regression tests for Koha::Item->hidden_in_opac to verify it is not considering the hidelostitems syspref when determining if an item should be hidden (per policy) in the OPAC. To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Koha/Item.t => FAIL: Tests fail! Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22749 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88387|0 |1 is obsolete| | --- Comment #4 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 88388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88388&action=edit Bug 22749: Regression tests for Koha::Item->hidden_in_opac This patch introduces regression tests for Koha::Item->hidden_in_opac to verify it is not considering the hidelostitems syspref when determining if an item should be hidden (per policy) in the OPAC. To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Koha/Item.t => FAIL: Tests fail! Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22749 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22454 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22454 [Bug 22454] Add Koha::Item::hidden_in_opac method -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22749 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88388|0 |1 is obsolete| | Attachment #88389|0 |1 is obsolete| | --- Comment #6 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 88404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88404&action=edit Bug 22749: Regression tests for Koha::Item->hidden_in_opac This patch introduces regression tests for Koha::Item->hidden_in_opac to verify it is not considering the hidelostitems syspref when determining if an item should be hidden (per policy) in the OPAC. To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Koha/Item.t => FAIL: Tests fail! Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22749 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22749 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00 released in| | Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Depends on bug not in 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.