[Bug 22099] New: "List requests" button displays when listing requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22099 Bug ID: 22099 Summary: "List requests" button displays when listing requests Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: andrew.isherwood@ptfs-europe.com Target Milestone: --- On the main ILL Requests page that lists all requests ("illlist" action), the "List request" button is displayed, which makes no sense since we're already listing requests. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22099 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22099 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no --- Comment #1 from Magnus Enger <magnus@libriotech.no> --- I find that button quite handy as a way to refresh the page. :-) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22099 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |hayleymapley@catalyst.net.n | |z Assignee|koha-bugs@lists.koha-commun |hayleymapley@catalyst.net.n |ity.org |z -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22099 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22099 --- Comment #2 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Created attachment 86839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86839&action=edit Bug 22099: Fixed ILL toolbar to say Refresh when displaying requests On the ILL requests page that lists all requests, the List Request button is displayed as part of the ILL toolbar. This patch fixes this by instead changing the wording of the button to Refresh when on the main page. Test plan: 1) More -> ILL Requests, note that the List Requests button displays while all the requests are already displayed 2) Apply the patch and restart things 3) More -> ILL Requests, note that the button now says Refresh, and clicking it refreshes the page 4) Check that on all the other functions of the ILLs the button says List Requests 5) Sign off! Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22099 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22099 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22099 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86839|0 |1 is obsolete| | --- Comment #3 from Magnus Enger <magnus@libriotech.no> --- Created attachment 90029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90029&action=edit Bug 22099: Fixed ILL toolbar to say Refresh when displaying requests On the ILL requests page that lists all requests, the List Request button is displayed as part of the ILL toolbar. This patch fixes this by instead changing the wording of the button to Refresh when on the main page. Test plan: 1) More -> ILL Requests, note that the List Requests button displays while all the requests are already displayed 2) Apply the patch and restart things 3) More -> ILL Requests, note that the button now says Refresh, and clicking it refreshes the page 4) Check that on all the other functions of the ILLs the button says List Requests 5) Sign off! Sponsored-by: Catalyst IT Signed-off-by: Magnus Enger <magnus@libriotech.no> Small conflict resolved. Works as advertised. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22099 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22099 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90029|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 90137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90137&action=edit Bug 22099: Fixed ILL toolbar to say Refresh when displaying requests On the ILL requests page that lists all requests, the List Request button is displayed as part of the ILL toolbar. This patch fixes this by instead changing the wording of the button to Refresh when on the main page. Test plan: 1) More -> ILL Requests, note that the List Requests button displays while all the requests are already displayed 2) Apply the patch and restart things 3) More -> ILL Requests, note that the button now says Refresh, and clicking it refreshes the page 4) Check that on all the other functions of the ILLs the button says List Requests 5) Sign off! Sponsored-by: Catalyst IT Signed-off-by: Magnus Enger <magnus@libriotech.no> Small conflict resolved. Works as advertised. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22099 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Not sure if this should be enhancement instead of trivial. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22099 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|trivial |minor CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22099 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22099 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22099 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|19.11.00 |19.11.00,19.05.01 released in| | Status|Pushed to Master |Pushed to Stable --- Comment #7 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 19.05.x for 19.05.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22099 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 18.11.x for 18.11.07 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org