[Bug 22955] New: Markup error in OPAC lists template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22955 Bug ID: 22955 Summary: Markup error in OPAC lists template Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Keywords: Academy Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Target Milestone: --- There is a minor markup error in the OPAC lists template: A missing "alt" attribute. It triggers this error: - "An img element must have an alt attribute, except under certain conditions." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22955 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22955 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 89949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89949&action=edit Bug 22955: Markup error in OPAC lists template This patch makes a minor correction to the template for OPAC lists. This correction fixes an error returned by the HTML validator by adding an empty "alt" attribute to an image tag. To reproduce the problem you should have at least one list available in the OPAC with one or more items on it. View the contents of that list in the OPAC. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch addresses one specific error: - "An img element must have an alt attribute, except under certain conditions." To test, apply the patch and try again to reproduce the validation error. The error should no longer be present. There should be no visible change to the page. Click "Download list." A modal window should appear with a "Loading" message, followed by a form for selecting a download format. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22955 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22955 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89949|0 |1 is obsolete| | --- Comment #2 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 90091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90091&action=edit Bug 22955: Markup error in OPAC lists template This patch makes a minor correction to the template for OPAC lists. This correction fixes an error returned by the HTML validator by adding an empty "alt" attribute to an image tag. To reproduce the problem you should have at least one list available in the OPAC with one or more items on it. View the contents of that list in the OPAC. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch addresses one specific error: - "An img element must have an alt attribute, except under certain conditions." To test, apply the patch and try again to reproduce the validation error. The error should no longer be present. There should be no visible change to the page. Click "Download list." A modal window should appear with a "Loading" message, followed by a form for selecting a download format. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22955 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |maryse.simard@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22955 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22955 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90091|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 90131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90131&action=edit Bug 22955: Markup error in OPAC lists template This patch makes a minor correction to the template for OPAC lists. This correction fixes an error returned by the HTML validator by adding an empty "alt" attribute to an image tag. To reproduce the problem you should have at least one list available in the OPAC with one or more items on it. View the contents of that list in the OPAC. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch addresses one specific error: - "An img element must have an alt attribute, except under certain conditions." To test, apply the patch and try again to reproduce the validation error. The error should no longer be present. There should be no visible change to the page. Click "Download list." A modal window should appear with a "Loading" message, followed by a form for selecting a download format. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22955 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22955 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22955 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00 |19.11.00,19.05.01 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to Master |Pushed to Stable --- Comment #5 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 19.05.x for 19.05.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22955 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 18.11.x for 18.11.07 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org