[Bug 9326] New: New database update system suggests running duplicate updates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9326 Bug ID: 9326 Summary: New database update system suggests running duplicate updates Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs@lists.koha-community.org Reporter: jcamins@cpbibliography.com CC: gmcharlt@gmail.com Depends on: 7167 When an update has been renamed, the new database update system suggests running the duplicate update, even though when you tell it to go ahead and do that, it informs you that it is a duplicate update. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9326 Bug 9326 depends on bug 7167, which changed state. Bug 7167 Summary: updatedatabase improvements http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9326 Bug 9326 depends on bug 7167, which changed state. Bug 7167 Summary: updatedatabase improvements http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9326 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion CC| |jonathan.druart@biblibre.co | |m --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- I understand what we discuss yesterday :) It is the normal behavior: A new version is available, you execute it. This version is an already executed file (same md5) so you must mark it as "ok" . The execute routine checks the md5 before any operation and returns this error if the same md5 already exists in DB. It is not a bug for me. What do you propose? Do you have a better way to manage this kind of files? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9326 --- Comment #2 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- (In reply to comment #1)
I understand what we discuss yesterday :)
It is the normal behavior: A new version is available, you execute it. This version is an already executed file (same md5) so you must mark it as "ok" . The execute routine checks the md5 before any operation and returns this error if the same md5 already exists in DB.
It is not a bug for me.
What do you propose? Do you have a better way to manage this kind of files?
Since it is impossible to rerun the update even if you want to, the MD5 needs to be checked prior to deciding that there are database updates to run. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9326 --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- It would be possible to let the user choose what to do: "version xxx already executed in version yyy, [mark as OK] or [apply anyway]" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9326 --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 14391 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14391&action=edit Bug 9326, 7167: Add a "execute anyway" link for versions already executed If a version has the same md5 than an version already executed, a link allows the administrator to execute this version anyway. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9326 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9326 MJ Ray (software.coop) <mjr@software.coop> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |mjr@software.coop --- Comment #5 from MJ Ray (software.coop) <mjr@software.coop> --- Applying: Bug 9326, 7167: Add a "execute anyway" link for versions already executed error: C4/Update/Database.pm: does not exist in index error: admin/updatedatabase.pl: does not exist in index error: koha-tmpl/intranet-tmpl/prog/en/modules/admin/updatedatabase.tt: does not exist in index Patch failed at 0001 Bug 9326, 7167: Add a "execute anyway" link for versions already executed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9326 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- This development depends on bug 7167 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9326 MJ Ray (software.coop) <mjr@software.coop> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|blocker |new feature --- Comment #7 from MJ Ray (software.coop) <mjr@software.coop> --- Downgrading to the same status as 7167 until 7167 is pushed, because this is not blocking the release. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9326 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Assignee|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9326 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |gitbot@bugs.koha-community. | |org --- Comment #8 from I'm just a bot <gitbot@bugs.koha-community.org> --- Applying: Bug 9326, 7167: Add a "execute anyway" link for versions already executed Using index info to reconstruct a base tree... A C4/Update/Database.pm A admin/updatedatabase.pl A koha-tmpl/intranet-tmpl/prog/en/modules/admin/updatedatabase.tt Falling back to patching base and 3-way merge... CONFLICT (modify/delete): koha-tmpl/intranet-tmpl/prog/en/modules/admin/updatedatabase.tt deleted in HEAD and modified in Bug 9326, 7167: Add a "execute anyway" link for versions already executed. Version Bug 9326, 7167: Add a "execute anyway" link for versions already executed of koha-tmpl/intranet-tmpl/prog/en/modules/admin/updatedatabase.tt left in tree. CONFLICT (modify/delete): admin/updatedatabase.pl deleted in HEAD and modified in Bug 9326, 7167: Add a "execute anyway" link for versions already executed. Version Bug 9326, 7167: Add a "execute anyway" link for versions already executed of admin/updatedatabase.pl left in tree. CONFLICT (modify/delete): C4/Update/Database.pm deleted in HEAD and modified in Bug 9326, 7167: Add a "execute anyway" link for versions already executed. Version Bug 9326, 7167: Add a "execute anyway" link for versions already executed of C4/Update/Database.pm left in tree. Patch failed at 0001 Bug 9326, 7167: Add a "execute anyway" link for versions already executed The copy of the patch that failed is found in: /home/christopher/git/koha/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9326 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to I'm just a bot from comment #8) This development depends on bug 7167 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9326 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- When did the bot| |2013-09-29 last check this| | --- Comment #10 from I'm just a bot <gitbot@bugs.koha-community.org> --- This bug depends on 7167 which has no valid patches -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9326 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Bot Control|--- |Ignore this bug -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9326 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9326 Bug 9326 depends on bug 7167, which changed state. Bug 7167 Summary: updatedatabase improvements http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9326 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |RESOLVED CC| |paul.poulain@biblibre.com Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org