[Bug 9328] New: File::Find::Rule should not be a mandatory dependency for installation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9328 Bug ID: 9328 Summary: File::Find::Rule should not be a mandatory dependency for installation Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: gmcharlt@gmail.com File::Find::Rule is introduced as a dependency in the work for bug 7167. However, since it's indirectly invoked via C4::Installer, that module must be present for Makefile.PL to compile during installation. I suggest making a new convention that it be possible to run Makefile.PL without requiring non-core Perl modules. F::F::Rule doesn't introduce functionality that is not available to File::Find, just some (admittedly useful) syntactical sugar, so one possibility would be cutting out that dependency entirely. If that's not preferred, it at least should not be required for Makefile.PL to run. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9328 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7167 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9328 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jonathan.druart@biblibre.co | |m Assignee|gmcharlt@gmail.com |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9328 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 14311 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14311&action=edit Bug 9328, 7167: Remove the File::Find::Rule dependency F::F::Rule doesn't introduce functionality that is not available to File::Find, just some (admittedly useful) syntactical sugar. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9328 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- To apply on top of patches for Bug 7167 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9328 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14311|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 16118 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16118&action=edit Bug 9328, 7167: Remove the File::Find::Rule dependency F::F::Rule doesn't introduce functionality that is not available to File::Find, just some (admittedly useful) syntactical sugar. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9328 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9328 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16118|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 17715 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17715&action=edit Bug 9328, 7167: Remove the File::Find::Rule dependency F::F::Rule doesn't introduce functionality that is not available to File::Find, just some (admittedly useful) syntactical sugar. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9328 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #5 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- The status of 7167 is not clear to me. That makes testing this patch even harder.. What I read here, sounds good to me. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9328 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |katrin.fischer@bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch does no longer apply: Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying: Bug 9328, 7167: Remove the File::Find::Rule dependency fatal: sha1 information is lacking or useless (C4/Update/Database.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 9328, 7167: Remove the File::Find::Rule dependency When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9328 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #6)
This patch does no longer apply:
This patch depends on bug 7167. Back to Signed Off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9328 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|7167 | Depends on| |7167 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9328 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am not sure how to proceed with this as I think it currently can't be tested. I am moving it to 'BLOCKED' for now. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9328 --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #8)
I am not sure how to proceed with this as I think it currently can't be tested. I am moving it to 'BLOCKED' for now.
I know bug 7167 is not a priority for Galen but this path can be tested. Especially because it is a small and easy patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9328 Bug 9328 depends on bug 7167, which changed state. Bug 7167 Summary: updatedatabase improvements http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9328 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |RESOLVED CC| |paul.poulain@biblibre.com Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org