[Bug 42920] New: Looking up authority records in Advanced editor appends 20 extra spaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42920 Bug ID: 42920 Summary: Looking up authority records in Advanced editor appends 20 extra spaces Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Keywords: regression Severity: normal Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs@lists.koha-community.org Reporter: phil@chetcolibrary.org QA Contact: testopia@bugs.koha-community.org Depends on: 21453 Target Milestone: --- The patch for bug 21453 replaced an Advanced editor-specific (in the "[% IF rancor %]" block) "[%- END -%]‡9[% authid | html %]";" which trims whitespace with several lines of "[% ... %]" which do not trim whitespace. The result is that when you look up an authority from the Advanced editor, you get something like ‡aBildungsromans. ‡9220 with twenty extra spaces before the ‡9. While we could restore trimming the whitespace, that section of the patch wasn't needed, and has made things incorrect for anyone who dares to use the Advanced editor with UNIMARC (probably nobody, since it doesn't do UNIMARC fixed-field builders): since the Advanced editor is only used for biblio records, not authority records, it *should* be putting the authid in ‡9 for both MARC flavors the way it was before, but now it will put it in ‡3, the right field for auth-to-auth linking but the wrong field for biblio-to-auth linking. So the right fix is just to revert the changes to the [% IF rancor %]" block. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21453 [Bug 21453] blinddetail-biblio-search.pl/.tt use hardcoded subfield values for MARC21 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42920 Kendall Purser <bcldteam.kendall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bcldteam.kendall@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42920 --- Comment #1 from Kendall Purser <bcldteam.kendall@gmail.com> --- Saw this same behavior when we updated to 25.11.05 affecting the 650 field on a lookup. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42920 Megan McShane <megan.mcshane@churchofjesuschrist.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |megan.mcshane@churchofjesus | |christ.org --- Comment #2 from Megan McShane <megan.mcshane@churchofjesuschrist.org> --- We've been seeing this as well. Has it caused any problems down the line with searching for catalog records or anything that anyone has seen? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42920 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |phil@chetcolibrary.org |ity.org | Patch complexity|--- |Trivial patch Comma delimited| |Chetco Community Public list of Sponsors| |Library Sponsorship status|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42920 --- Comment #3 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 201468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201468&action=edit Bug 42920: Looking up authority records in Advanced editor shouldn't append spaces The patch for bug 21453 replaced an Advanced editor-specific (in the "[% IF rancor %]" block) "[%- END -%]‡9[% authid | html %]";" which trims whitespace with several lines of "[% ... %]" which do not trim whitespace. The result is that when you look up an authority from the Advanced editor, you get extra whitespace between the last subfield from the authority record and the $9 field with the authority id. Test plan: 1. Without the patch, set the preference EnableAdvancedCatalogingEditor to Enable 2. Cataloging - Advanced editor 3. Click in any line of the editor and press Return to get a blank line 4. Type 655 and press Tab three times 5. Type Ctrl+Shift+L to open the authority search popup 6. Click Search (no need for search terms) and click Choose for any record 7. Note that the editor shows twenty blank spaces between the end of the subfield a contents and the ‡9 8. Apply patch 9. Repeat steps 3-6, note that now there is no extra space between the end of the content and the ‡9 Sponsored-by: Chetco Community Public Library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42920 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42920 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201468|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42920 --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 201471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201471&action=edit Bug 42920: Looking up authority records in Advanced editor shouldn't append spaces The patch for bug 21453 replaced an Advanced editor-specific (in the "[% IF rancor %]" block) "[%- END -%]‡9[% authid | html %]";" which trims whitespace with several lines of "[% ... %]" which do not trim whitespace. The result is that when you look up an authority from the Advanced editor, you get extra whitespace between the last subfield from the authority record and the $9 field with the authority id. Test plan: 1. Without the patch, set the preference EnableAdvancedCatalogingEditor to Enable 2. Cataloging - Advanced editor 3. Click in any line of the editor and press Return to get a blank line 4. Type 655 and press Tab three times 5. Type Ctrl+Shift+L to open the authority search popup 6. Click Search (no need for search terms) and click Choose for any record 7. Note that the editor shows twenty blank spaces between the end of the subfield a contents and the ‡9 8. Apply patch 9. Repeat steps 3-6, note that now there is no extra space between the end of the content and the ‡9 Sponsored-by: Chetco Community Public Library Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42920 Paul Slaughter <paul.slaughter@neill-lib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.slaughter@neill-lib.or | |g -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42920 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42920 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201471|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42920 --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 201592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201592&action=edit Bug 42920: Looking up authority records in Advanced editor shouldn't append spaces The patch for bug 21453 replaced an Advanced editor-specific (in the "[% IF rancor %]" block) "[%- END -%]‡9[% authid | html %]";" which trims whitespace with several lines of "[% ... %]" which do not trim whitespace. The result is that when you look up an authority from the Advanced editor, you get extra whitespace between the last subfield from the authority record and the $9 field with the authority id. Test plan: 1. Without the patch, set the preference EnableAdvancedCatalogingEditor to Enable 2. Cataloging - Advanced editor 3. Click in any line of the editor and press Return to get a blank line 4. Type 655 and press Tab three times 5. Type Ctrl+Shift+L to open the authority search popup 6. Click Search (no need for search terms) and click Choose for any record 7. Note that the editor shows twenty blank spaces between the end of the subfield a contents and the ‡9 8. Apply patch 9. Repeat steps 3-6, note that now there is no extra space between the end of the content and the ‡9 Sponsored-by: Chetco Community Public Library Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42920 lhilleary@wrl.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lhilleary@wrl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42920 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42920 --- Comment #6 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42920 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.11.00 |26.11.00,26.05.03 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42920 --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to 26.05.x for the upcoming 26.05.03 release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42920 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.11.00,26.05.03 |26.11.00,26.05.03,25.11.09 released in| | CC| |baptiste.wojtkowski@biblibr | |e.com Status|Pushed to stable |Pushed to oldstable --- Comment #8 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Pushed into 25.11.x for 25.11.09 nice work everyone -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org