[Bug 42598] New: Spent totals on acq homepage and funds page should calculate using quantity received
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42598 Bug ID: 42598 Summary: Spent totals on acq homepage and funds page should calculate using quantity received Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org The GetBudgetHierarchy sub from C4/Budgets.pm is used to calculate the Spent amount shown on the acq homepage (/cgi-bin/koha/acqui/acqui-home.pl) and the funds page in admin (/cgi-bin/koha/admin/aqbudgets.pl). This sub calculates using aqorders.quantity rather than aqorders.quantityreceived, which is not strictly accurate. It is possible to receive more items than were ordered, in which case quantity will show the number ordered while quantityreceived will show the number actually received (and therefore the number actually paid for). Note that /cgi-bin/koha/acqui/spent.pl does use quantityreceived, which will lead the two given totals to disagree. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42598 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |andrew@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42598 --- Comment #1 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 199114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199114&action=edit Bug 42598: Calculate spend on quantityreceived To test: 1 - create a new basket with "Create items when" set to "cataloging the record" 2 - add an order to your basket with quantity 1, vendor price $10, no tax, no discount. for clarity, charge it to a fund with no previous orders 3 - close your basket 4 - receive your order, setting quantityreceived to 2 (you'll have to click Confirm twice and then click Continue on a warning) 5 - go to admin/aqbudgets.pl, find the spent values for the fund your order was on, confirm they show $10 6 - go to acqui-home, find the Spent value for the fund your order was on, confirm it shows $10 7 - click that Spent value to go to spent.pl for your fund, confirm it shows $20 8 - apply patch, restart_all 9 - reload all three pages, confirm all three now show $20 spent -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42598 --- Comment #2 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 199115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199115&action=edit Bug 42598: Add missing POD Patch from commit c802f78 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42598 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #3 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- I'm unsure of this as I poke at it further. When receiving more items than I ordered, my invoice shows a total that matches the quantity ordered rather than the quantity received. Perhaps the assumption should be that any copies beyond the number ordered were not paid for? If that's the case, then this bug should be marked invalid and we should instead patch /cgi-bin/koha/acqui/spent.pl to use quantity. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42598 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |nick@bywatersolutions.com, | |rkuiper@roundrocktexas.gov --- Comment #4 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- I don't think we should be able to receive more copies than we ordered, or if we can, then receiving an additional copy should increase the order quantity - CCing Katrin and Rhonda for wider opinion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42598 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It seems logical to me to calculate the amount spent on the number of items received and not on the quantity ordered. I am thinking about standing orders where you always have a quantity ordered of 1. I am not sure if the quantity ordered is adjusted later to the actual number you receive. So this might be a common case present in a lot of databases where you might want to receive more than ordered to be able to create the items you need. I haven't confirmed the behavior explicitly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42598 --- Comment #6 from Rhonda Kuiper <rkuiper@roundrocktexas.gov> --- I put out a question to the ACQ SIG and the one case that was mentioned was when an order is cancelled by the vendor and the library reorders the item later and then both the cancelled order and the reordered items come in. In this case they need to update the amount ordered to reflect what was actually received. In this example, updating the amount ordered to reflect the amount received is the behavior the library prefers. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42598 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com, | |clemens.tubach@kit.edu, | |jonathan.field@openfifth.co | |.uk, | |michaela.sieber@kit.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42598 --- Comment #7 from Michaela Sieber <michaela.sieber@kit.edu> --- If the basket setting "Create items when" is set to "Placing orders" then it is not possible to receive more items than ordered. Any entry in the Quantity received: field is overwritten with the quantity ordered as soon as you leave the field, and there is a warning: "Warning, you have entered more items than expected. Items will not be created." If the basket setting "Create items when" is set to "Receiving items" then it is also not possible to receive more items than ordered. You can only add as many items as you have ordered. This means the problem only exists if the basket setting "Create items when" is set to "Cataloguing items" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42598 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33756 CC| |emmi.takkinen@koha-suomi.fi -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org