[Bug 8993] New: LDAP authentication improvements: multiple branch and transformation modules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 Priority: P5 - low Change sponsored?: --- Bug ID: 8993 CC: dpavlin@rot13.org Assignee: julian.maurice@biblibre.com Summary: LDAP authentication improvements: multiple branch and transformation modules Severity: enhancement Classification: Unclassified OS: All Reporter: julian.maurice@biblibre.com Hardware: All Status: ASSIGNED Version: master Component: Authentication Product: Koha -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 13129 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13129&action=edit Bug 8993: LDAP authentication improvements 1) allow multiple branch authentication 2) allow to use a Perl module to transform ldap entry into a Koha borrower These improvements needs koha-conf.xml to be modified. However, the old authentication mechanism is still there, and if you do not change your configuration file, it must continue to work exactly the same way. There's a POD file describing new features C4/LDAPAuthMethodTutorial.pod -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 --- Comment #2 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 13130 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13130&action=edit Bug 8993: Sample LDAP transformation module This is a sample transformation module for the new LDAP authentication system. It should not be pushed as it is customer-specific, but it should demonstrate how to implement your own. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 --- Comment #3 from Julian Maurice <julian.maurice@biblibre.com> --- Contents of POD file: LDAP auth_method configuration This document is a step by step explaination for the new LDAP configuration method. The old one (see C4::Auth_with_ldap) still exists and you should give it a try if your needs of mappings and transformations are low. What do I have to ask to the directory administrator How to reach the service What we need is build the url of the ldap service we want to reach. So ask him for the URL. If he don't know, ask for the scheme (or protocol), the hostname and the port of the directory. Only hostname and scheme are mandatory. The scheme must be ldap or ldaps (ldaps is for crypted ldap, ldap over SSL). The url construction is: scheme://hostname:port scheme://hostname examples host=directory.example.com port=389 scheme=ldap gives you: ldap://directory.example.com:389 Also: Active Directory (the Microsoft implementation) is an LDAP alike directory but Koha have to know it's active directory to use it, so please ask. What is the binding method ? Are anonymous allowed to make some searches on the server? If not, what is the credentials for the koha account ? Credentials are a pair (DN, password) uid=koha,ou=people,dc=example,dc=com MYS3CRET in Active Directory, it can be a login@example.com with a password koha@example.com MYS3CRET Now configure koha This is a basic exemple of things you will add in the "/config" part of "koha-conf.xml". First of all, you need to tell koha that ldap authentication is now relevant <useldapserver>1</useldapserver> If you use anonymous method, you have to give credentials of koha account <ldapserver url="ldap://directory.example.com" manager="uid=koha,ou=people,dc=example,dc=com" password="MYS3CRET" authmethod="search_dn" > Also, you can set the values for replication and update (documented in legacy pod): <ldapserver url="ldap://directory.example.com" manager="uid=koha,ou=people,dc=example,dc=com" password="MYS3CRET" authmethod="search_dn" replicate="1" update="1" > You must now tell koha the ldap branches where to find users <useldapserver>1</useldapserver> <ldapserver url="ldap://directory.example.com" manager="uid=koha,ou=people,dc=example,dc=com" password="MYS3CRET" authmethod="search_dn" replicate="1" update="1" > <branch dn="ou=people,dc=site1,dc=example,dc=com" /> <branch dn="ou=people,dc=site2,dc=example,dc=com" /> <branch dn="ou=people,dc=site4,dc=example,dc=com" /> The best part of this new config is that you don't have to rely on simple mappings anymore (but you still can): you can use a perl module to write much sofisticated transformations directly in perl: <transformation module="C4::LDAPTransform::CustomTransform" /> This module only have to define a subroutine named get_borrower -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13129|0 |1 is obsolete| | --- Comment #4 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 13131 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13131&action=edit Bug 8993: LDAP authentication improvements 1) allow multiple branch authentication 2) allow to use a Perl module to transform ldap entry into a Koha borrower These improvements needs koha-conf.xml to be modified. However, the old authentication mechanism is still there, and if you do not change your configuration file, it must continue to work exactly the same way. There's a POD file describing new features C4/LDAPAuthMethodTutorial.pod -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13130|0 |1 is obsolete| | --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 13132 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13132&action=edit Bug 8993: Sample LDAP transformation module -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 --- Comment #6 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 14219 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14219&action=edit Bug 8993: Follow-up - LDAP authentication improvements sub SetBorrowerAttributes which is used in set_xattr is not exported. So i get the following error when login using ldap: "Software error: Undefined subroutine &C4::Auth_with_ldap::SetBorrowerAttributes called at /home/koha/src/C4/Auth_with_ldap.pm line 166, <DATA> line 522." So here is a follow-up patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13132|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- The content of attachment 13130 has been deleted by Chris Cormack <chris@bigballofwax.co.nz> who provided the following reason: Asked for by Julian The token used to delete this attachment was generated at 2012-12-24 21:47:36 NZDT. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> --- The content of attachment 13132 has been deleted by Chris Cormack <chris@bigballofwax.co.nz> who provided the following reason: Asked for by Julian The token used to delete this attachment was generated at 2012-12-24 21:48:42 NZDT. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13131|0 |1 is obsolete| | --- Comment #9 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 14460 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14460&action=edit Bug 8993: LDAP authentication improvements 1) allow multiple branch authentication 2) allow to use a Perl module to transform ldap entry into a Koha borrower These improvements needs koha-conf.xml to be modified. However, the old authentication mechanism is still there, and if you do not change your configuration file, it must continue to work exactly the same way. There's a POD file describing new features C4/LDAPAuthMethodTutorial.pod -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14219|0 |1 is obsolete| | --- Comment #10 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 14461 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14461&action=edit Bug 8993: Follow-up - LDAP authentication improvements -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 --- Comment #11 from Julian Maurice <julian.maurice@biblibre.com> --- Patches rebased on master. Removed 2 scripts from the first patch that were not intended to be included. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 --- Comment #12 from Chris Cormack <chris@bigballofwax.co.nz> --- The content of attachment 13129 has been deleted by Chris Cormack <chris@bigballofwax.co.nz> without providing any reason. The token used to delete this attachment was generated at 2013-01-11 06:38:38 NZDT. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 --- Comment #13 from Chris Cormack <chris@bigballofwax.co.nz> --- The content of attachment 13131 has been deleted by Chris Cormack <chris@bigballofwax.co.nz> without providing any reason. The token used to delete this attachment was generated at 2013-01-11 06:39:27 NZDT. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 Thibault Le Meur <thibault.lemeur@supelec.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |thibault.lemeur@supelec.fr --- Comment #14 from Thibault Le Meur <thibault.lemeur@supelec.fr> --- The patch is applied in our production environment which has several LDAP branches on a single LDAP server. It is fully working. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 Gaetan Boisson <gaetan.boisson@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gaetan.boisson@biblibre.com --- Comment #15 from Gaetan Boisson <gaetan.boisson@biblibre.com> --- Patch tested on an instance with a "regular" single branch LDAP : everything working as expected, no regression! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 Elliott Davis <elliott@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |elliott@bywatersolutions.co | |m --- Comment #16 from Elliott Davis <elliott@bywatersolutions.com> --- Sorry fir butting in here but I am confused. Is this intended to be pushed or just for a customer? Elliott -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 --- Comment #17 from Julian Maurice <julian.maurice@biblibre.com> --- Hi Elliott, this patch is not customer-specific and is intended to be integrated into master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 --- Comment #18 from Dobrica Pavlinusic <dpavlin@rot13.org> --- This change will conflict with Bug 7973 so it should probably be re-based if 7973 gets into master first. I think we should also provide example transformation module, because it's non-obvious how to write transformation module from looking at code alone (at least for me). Good example of transformation module might be one which converts repeatable values in ldap into multiple fields for easier import into koha since right now koha just concatenates all values with spaces which is sub-optimal if you want just one value from repeatable field. I would love to write one, but I don't really know where to start. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 --- Comment #19 from Dobrica Pavlinusic <dpavlin@rot13.org> --- I also don't like that existing LDAP configuration stops working with this patch applied (think about package upgrade) and only indication that something changed is message in error log: "deprecated ldap configuration, see documentation". It might at least point to C4/LDAPAuthMethodTutorial.pod as source of that documentation, but ideal solution would be to support old configuration if possible. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 --- Comment #20 from Dobrica Pavlinusic <dpavlin@rot13.org> --- Created attachment 16659 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16659&action=edit Bug 8993 - my attempt to get this module working QA note: please fail this patch. With all this changes, I'm still not able to login using following configuration: <ldapserver uri="ldaps://ldap.ffzg.hr" authmethod="search_dn" replicate="1" update="0" userid_from="uid"
<branch dn="dc=ffzg,dc=hr" /> <transformation module="C4::LDAPTransform::RepeatableValues" /> </ldapserver> This should be one of more simple configuration, and it doesn't work with this patch. While I would love to have LDAP transformations in perl code, I think this patch is too big rewrite with a lot of edge cases which aren't convered. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 --- Comment #21 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 16796 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16796&action=edit Bug 8993 [Follow-up] update and replicate options used at wrong place update was used instead of replicate and vice versa Also the package name of LDAPTransformation module was wrong. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #22 from Julian Maurice <julian.maurice@biblibre.com> --- With this patch and Dobrica's patch applied, I'm able to get into the login process: ldap binding is successful and if user is not existing in koha database, it is created. Note: to really be able to login I had to modify C4::LDAPTransform::RepeatableValues to fill values for categorycode and branchcode since user creation fails if they are empty. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 --- Comment #23 from Dobrica Pavlinusic <dpavlin@rot13.org> --- We should include all required fields (categorycode and branchcode) in example plugin so people don't have to look at this bug to find that out :-) OOH, now that I have had enough sleep, is there really a good reason to introduce completely different configuration for LDAP server? Adding <branch>, <transform> and few other tags into existing configuration would probably result in simpler code and easier upgrade path. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14460|0 |1 is obsolete| | --- Comment #24 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 18804 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18804&action=edit Bug 8993: LDAP authentication improvements Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14461|0 |1 is obsolete| | --- Comment #25 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 18805 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18805&action=edit Bug 8993: Follow-up - LDAP authentication improvements Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16659|0 |1 is obsolete| | --- Comment #26 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 18806 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18806&action=edit Bug 8993 - my attempt to get this module working Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16796|0 |1 is obsolete| | --- Comment #27 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 18807 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18807&action=edit Bug 8993 [Follow-up] update and replicate options used at wrong place Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 --- Comment #28 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 18808 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18808&action=edit Bug 8993: Add branchcode and categorycode mappings for sample module -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 --- Comment #29 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to comment #23)
OOH, now that I have had enough sleep, is there really a good reason to introduce completely different configuration for LDAP server? Adding <branch>, <transform> and few other tags into existing configuration would probably result in simpler code and easier upgrade path.
If you are refering to the use of xml attributes instead of xml tags, I think you can use the one you prefer, as: <ldapserver update="1" /> and <ldapserver> <update>1</update> </ldapserver> will both result in a hash: { update => "1" } -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |gitbot@bugs.koha-community. | |org --- Comment #30 from I'm just a bot <gitbot@bugs.koha-community.org> --- Applying: Bug 8993: LDAP authentication improvements Using index info to reconstruct a base tree... M C4/Auth_with_ldap.pm Falling back to patching base and 3-way merge... Auto-merging C4/Auth_with_ldap.pm CONFLICT (content): Merge conflict in C4/Auth_with_ldap.pm Patch failed at 0001 Bug 8993: LDAP authentication improvements The copy of the patch that failed is found in: /home/christopher/git/koha/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18804|0 |1 is obsolete| | --- Comment #31 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 21345 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21345&action=edit Bug 8993: LDAP authentication improvements 1) allow multiple branch authentication 2) allow to use a Perl module to transform ldap entry into a Koha borrower These improvements needs koha-conf.xml to be modified. However, the old authentication mechanism is still there, and if you do not change your configuration file, it must continue to work exactly the same way. There's a POD file describing new features C4/LDAPAuthMethodTutorial.pod -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18805|0 |1 is obsolete| | --- Comment #32 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 21346 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21346&action=edit Bug 8993: Follow-up - LDAP authentication improvements -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18806|0 |1 is obsolete| | --- Comment #33 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 21347 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21347&action=edit Bug 8993 - my attempt to get this module working QA note: please fail this patch. With all this changes, I'm still not able to login using following configuration: <ldapserver uri="ldaps://ldap.ffzg.hr" authmethod="search_dn" replicate="1" update="0" userid_from="uid"
<branch dn="dc=ffzg,dc=hr" /> <transformation module="C4::LDAPTransform::RepeatableValues" /> </ldapserver> This should be one of more simple configuration, and it doesn't work with this patch. While I would love to have LDAP transformations in perl code, I think this patch is too big rewrite with a lot of edge cases which aren't convered. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18807|0 |1 is obsolete| | --- Comment #34 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 21348 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21348&action=edit Bug 8993 [Follow-up] update and replicate options used at wrong place update was used instead of replicate and vice versa Also the package name of LDAPTransformation module was wrong. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18808|0 |1 is obsolete| | --- Comment #35 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 21349 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21349&action=edit Bug 8993: Add branchcode and categorycode mappings for sample module -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #36 from Julian Maurice <julian.maurice@biblibre.com> --- All patches rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- When did the bot| |2013-09-24 last check this| | --- Comment #37 from I'm just a bot <gitbot@bugs.koha-community.org> --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply When did the bot|2013-09-24 00:00:00 |2013-10-25 last check this| | --- Comment #38 from I'm just a bot <gitbot@bugs.koha-community.org> --- Applying: Bug 8993: LDAP authentication improvements Using index info to reconstruct a base tree... M C4/Auth_with_ldap.pm Falling back to patching base and 3-way merge... Auto-merging C4/Auth_with_ldap.pm CONFLICT (content): Merge conflict in C4/Auth_with_ldap.pm Patch failed at 0001 Bug 8993: LDAP authentication improvements The copy of the patch that failed is found in: /home/christopher/git/koha/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 --- Comment #39 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Any chance of rebasing this again Julian.. I'm hoping to test it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21345|0 |1 is obsolete| | --- Comment #40 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 22580 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22580&action=edit Bug 8993: LDAP authentication improvements Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21346|0 |1 is obsolete| | --- Comment #41 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 22581 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22581&action=edit Bug 8993: Follow-up - LDAP authentication improvements Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21347|0 |1 is obsolete| | --- Comment #42 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 22582 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22582&action=edit Bug 8993 - my attempt to get this module working Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21348|0 |1 is obsolete| | --- Comment #43 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 22583 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22583&action=edit Bug 8993 [Follow-up] update and replicate options used at wrong place Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21349|0 |1 is obsolete| | --- Comment #44 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 22584 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22584&action=edit Bug 8993: Add branchcode and categorycode mappings for sample module Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #45 from Julian Maurice <julian.maurice@biblibre.com> --- I rebased all patches but not tested them. Hope it will works :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 --- Comment #46 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Great fast response Julian.. unfortunately I still can't get it to apply :( Falling back to patching base and 3-way merge... Auto-merging C4/Auth_with_ldap.pm CONFLICT (content): Merge conflict in C4/Auth_with_ldap.pm Failed to merge in the changes. Patch failed at 0001 Bug 8993: LDAP authentication improvements Looking at the merge markers, it looks like the main routine 'checkpw_ldap' is the issue, but it's such an extensive re-write that I don't want to screw it up by trying to merge it myself. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 --- Comment #47 from Julian Maurice <julian.maurice@biblibre.com> --- Hmm I forgot to fetch the git remote before rebasing... Rebased patches are coming. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22580|0 |1 is obsolete| | --- Comment #48 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 22588 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22588&action=edit Bug 8993: LDAP authentication improvements Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22581|0 |1 is obsolete| | --- Comment #49 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 22589 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22589&action=edit Bug 8993: Follow-up - LDAP authentication improvements Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22582|0 |1 is obsolete| | --- Comment #50 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 22590 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22590&action=edit Bug 8993 - my attempt to get this module working Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22583|0 |1 is obsolete| | --- Comment #51 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 22591 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22591&action=edit Bug 8993 [Follow-up] update and replicate options used at wrong place Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22584|0 |1 is obsolete| | --- Comment #52 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 22592 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22592&action=edit Bug 8993: Add branchcode and categorycode mappings for sample module Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 --- Comment #53 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks Julian, Applies beautifully... now for some testing :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |mtompset@hotmail.com --- Comment #54 from M. Tompsett <mtompset@hotmail.com> --- Some of this may also be obsolete. :( -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22588|0 |1 is obsolete| | Attachment #22589|0 |1 is obsolete| | Attachment #22590|0 |1 is obsolete| | Attachment #22591|0 |1 is obsolete| | Attachment #22592|0 |1 is obsolete| | --- Comment #55 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 38270 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38270&action=edit Bug 8993: LDAP authentication improvements 1) allow multiple branch authentication 2) allow to use a Perl module to transform ldap entry into a Koha borrower These improvements needs koha-conf.xml to be modified. However, the old authentication mechanism is still there, and if you do not change your configuration file, it must continue to work exactly the same way. There's a POD file describing new features C4/LDAPAuthMethodTutorial.pod -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 --- Comment #56 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 38271 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38271&action=edit [DO NOT PUSH] Bug 8993: Sample LDAP transformation module -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #57 from Julian Maurice <julian.maurice@biblibre.com> --- Patches rebased and cleaned. All indentation-only stuff was removed from patch to ease reading it (and make it easier to apply in the future). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38270|0 |1 is obsolete| | --- Comment #58 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 38273 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38273&action=edit Bug 8993: LDAP authentication improvements 1) allow multiple branch authentication 2) allow to use a Perl module to transform ldap entry into a Koha borrower These improvements needs koha-conf.xml to be modified. However, the old authentication mechanism is still there, and if you do not change your configuration file, it must continue to work exactly the same way. There's a POD file describing new features C4/LDAPAuthMethodTutorial.pod -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38271|0 |1 is obsolete| | --- Comment #59 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 38274 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38274&action=edit [DO NOT PUSH] Bug 8993: Sample LDAP transformation module -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 Amit <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amitddng135@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 astronomypt@gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |astronomypt@gmail.com --- Comment #60 from astronomypt@gmail.com --- Apparently it is not possible to specify in the LDAP XML configuration something such as: <base>OU=subunit,OU=unit,OU=supraunit,DC=dc1,DC=dc0;OU=othersubunit,OU=unit,OU=supraunit,DC=dc1,DC=dc0</base> Only one search context is allowed at a given time, i.e., <base>OU=subunit,OU=unit,OU=supraunit,DC=dc1,DC=dc0</base> As far as I understand (sorry, very new to Koha and perl) this patch will solve the problem? (I have one solution working already, with very minor changes to Auth_with_ldap.pm, based on this idea: my @base = split(';',$ldap->{base}) or die ldapserver_error('base'); but would like to see a solution upstream) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 --- Comment #61 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Rui from comment #60)
Apparently it is not possible to specify in the LDAP XML configuration something such as:
<base>OU=subunit,OU=unit,OU=supraunit,DC=dc1,DC=dc0;OU=othersubunit,OU=unit, OU=supraunit,DC=dc1,DC=dc0</base>
It is possible with this patch, try something like this: <ldapserver uri="ldap://directory.example.com" manager="uid=koha,ou=people,dc=example,dc=com" password="MYS3CRET" authmethod="search_dn" replicate="1" update="1"> <branch dn="ou=people,dc=site1,dc=example,dc=com" /> <branch dn="ou=people,dc=site2,dc=example,dc=com" /> <branch dn="ou=people,dc=site4,dc=example,dc=com" /> </ldapserver> This example comes from C4/LDAPAuthMethodTutorial.pod -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org