[Bug 14470] New: Renewals should be disabled in OPAC if are referred to an on-site checkout
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14470 Bug ID: 14470 Summary: Renewals should be disabled in OPAC if are referred to an on-site checkout Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: costalc@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Performing an on-site checkout should disable renewals in OPAC as happens in staff client side. Attached is an step-by-step sample. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14470 --- Comment #1 from bondiurbano <costalc@gmail.com> --- Created attachment 40706 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40706&action=edit step-by-step sample -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14470 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |katrin.fischer@bsz-bw.de --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Katrin, do you agree this is a bug? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14470 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think if we block renewals in the staff client, we should do the same in OPAC - normally staff client allows more than OPAC, the opposite behaviour seems unexpected. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14470 --- Comment #4 from bondiurbano <costalc@gmail.com> --- (In reply to Katrin Fischer from comment #3)
I think if we block renewals in the staff client, we should do the same in OPAC - normally staff client allows more than OPAC, the opposite behaviour seems unexpected.
Katrin, despite of your comment (that I agree), the behaviour in staff, as I understand, is the correct behaviour. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14470 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think we are not disagreeing - I think the OPAC should also block renewals in this case if it was designed to do so in staff. It doesn't make sense to treat both separately. It would be nice if there was also a way to define the number of renewals possible for on-site-checkouts in the future. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14470 --- Comment #6 from bondiurbano <costalc@gmail.com> --- (In reply to Katrin Fischer from comment #5)
I think we are not disagreeing - I think the OPAC should also block renewals in this case if it was designed to do so in staff. It doesn't make sense to treat both separately. It would be nice if there was also a way to define the number of renewals possible for on-site-checkouts in the future.
That was the meaning of my comment. I agree with you. Sorry if there was a misunderstanding. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14470 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14470 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 41336 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41336&action=edit Bug 14470: Do not allow renew for on-site checkouts At the opac, the renew checkbox should not be displayed if it's an on-site checkout (same on the intranet). On the way, this patch adds a specific message to the intranet if the librarian try to renew an on-site checkout. Indeed before this patch a renew was allowed if the barcode was scanned. Test plan: 1/ Create an on-site checkout for a patron 2/ Confirm that the checkbox 'renew' is not displayed on the checkout list tables 3/ At the OPAC, the renew should not be allowed (no checkbox) 4/ Try to check the item out to the same patron, confirm that you get a specifig message to inform you the renew is not allowed for on-site checkouts. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14470 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10860 Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 [Bug 10860] On-site checkouts (was In-House Use) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14470 --- Comment #8 from bondiurbano <costalc@gmail.com> --- Jonathan, I was testing in a local installation. All works fine if I discard checkout.js modifications. If I consider checkout.js modifications all checkouts in the checkout patron view are missing. Please see attached PDF. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14470 --- Comment #9 from bondiurbano <costalc@gmail.com> --- Created attachment 41430 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41430&action=edit Missing data display in checkout patron view -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14470 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- It seems to work here. Are you sure you have correctly refreshed the page (to take into account the JS changes)? You certainly got a JS error, please report it here. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14470 --- Comment #11 from bondiurbano <costalc@gmail.com> --- You are wright Jonathan, I'm soooooo sorry. All work fine, great job! I've attached a PDF file with some legends suggestions. Thank you very much Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14470 --- Comment #12 from bondiurbano <costalc@gmail.com> --- Created attachment 41440 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41440&action=edit Legends suggestions -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14470 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14470 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41336|0 |1 is obsolete| | --- Comment #13 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 41444 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41444&action=edit Bug 14470: Do not allow renew for on-site checkouts At the opac, the renew checkbox should not be displayed if it's an on-site checkout (same on the intranet). On the way, this patch adds a specific message to the intranet if the librarian try to renew an on-site checkout. Indeed before this patch a renew was allowed if the barcode was scanned. Test plan: 1/ Create an on-site checkout for a patron 2/ Confirm that the checkbox 'renew' is not displayed on the checkout list tables 3/ At the OPAC, the renew should not be allowed (no checkbox) 4/ Try to check the item out to the same patron, confirm that you get a specifig message to inform you the renew is not allowed for on-site checkouts. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14470 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko@abunchofthings.net --- Comment #14 from Mirko Tietgen <mirko@abunchofthings.net> --- The display is not consistent. I observed: OPAC (opac-user.pl, column »Renew«) before patch (if renewal allowed according to circ matrix): »[checkbox] Renew (x of x renewals remaining)« before patch (if renewal not allowed): »[no checkbox] Not renewable« after patch: [empty] Staff (Checkouts, tab »Check out«, column »Renew«) before patch (if renewal allowed): »0« before patch (if renewal not allowed): »0 Not renewable« after patch: »0« OPAC should display no checkbox, but the message »Not renewable«, as it does if renewal is not allowed for other reasons. Staff should display »Not renewable« -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14470 --- Comment #15 from bondiurbano <costalc@gmail.com> --- It's fine for me. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14470 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Patch doesn't apply due to a conflict in Circulation.t - can you please fix? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14470 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14470 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41444|0 |1 is obsolete| | --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 42195 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42195&action=edit Bug 14470: Do not allow renew for on-site checkouts At the opac, the renew checkbox should not be displayed if it's an on-site checkout (same on the intranet). On the way, this patch adds a specific message to the intranet if the librarian try to renew an on-site checkout. Indeed before this patch a renew was allowed if the barcode was scanned. Test plan: 1/ Create an on-site checkout for a patron 2/ Confirm that the checkbox 'renew' is not displayed on the checkout list tables 3/ At the OPAC, the renew should not be allowed (no checkbox) 4/ Try to check the item out to the same patron, confirm that you get a specifig message to inform you the renew is not allowed for on-site checkouts. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14470 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14470 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42195|0 |1 is obsolete| | --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 42365 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42365&action=edit [PASSED QA] Bug 14470: Do not allow renew for on-site checkouts At the opac, the renew checkbox should not be displayed if it's an on-site checkout (same on the intranet). On the way, this patch adds a specific message to the intranet if the librarian try to renew an on-site checkout. Indeed before this patch a renew was allowed if the barcode was scanned. Test plan: 1/ Create an on-site checkout for a patron 2/ Confirm that the checkbox 'renew' is not displayed on the checkout list tables 3/ At the OPAC, the renew should not be allowed (no checkbox) 4/ Try to check the item out to the same patron, confirm that you get a specifig message to inform you the renew is not allowed for on-site checkouts. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Changed 'issue' to 'item' in the error message. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14470 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is good - but I agree with bondiurbano - we should really mark the on-site checkouts in the checkouts list, maybe similar to how it is in the staff client. It's visible in the reading history only. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14470 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42365|0 |1 is obsolete| | --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 42366 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42366&action=edit [PASSED QA] Bug 14470: Do not allow renew for on-site checkouts At the opac, the renew checkbox should not be displayed if it's an on-site checkout (same on the intranet). On the way, this patch adds a specific message to the intranet if the librarian try to renew an on-site checkout. Indeed before this patch a renew was allowed if the barcode was scanned. Test plan: 1/ Create an on-site checkout for a patron 2/ Confirm that the checkbox 'renew' is not displayed on the checkout list tables 3/ At the OPAC, the renew should not be allowed (no checkbox) 4/ Try to check the item out to the same patron, confirm that you get a specifig message to inform you the renew is not allowed for on-site checkouts. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Changed 'issue' to 'item' in the error message. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14470 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #21 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14470 --- Comment #22 from bondiurbano <costalc@gmail.com> --- Thanks to all! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14470 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #23 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.20.x will be in 3.20.4 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14470 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz@catalyst.net.nz --- Comment #24 from Liz Rea <liz@catalyst.net.nz> --- Pushed to 3.18.x will be in 3.18.11 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14470 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14884 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org