[Bug 13601] New: Get rid of DateTime::Format::DateParse
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 Bug ID: 13601 Summary: Get rid of DateTime::Format::DateParse Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: jonathan.druart@biblibre.com QA Contact: testopia@bugs.koha-community.org For a couple of reasons, dt_from_string should not use DateTime::Format::DateParse: 1/ It does not manage date < 1900 (certainly caused by l.47 of this module: $p{ year } = $year ? $year + 1900 : DateTime->now->year; 2/ It considers 31/01/2015 as a valid us date, which is not. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |jonathan.druart@biblibre.co | |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 35405 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35405&action=edit Bug 13601: Add tests to highlight the problems with DateTime::Format::DateParse -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 35406 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35406&action=edit Bug 13601: Make dt_from_string not using DateTime::Format::DateParse For a couple of reasons, dt_from_string should not use DateTime::Format::DateParse: 1/ It does not manage date < 1900, certainly caused by l.47 of this module: $p{ year } = $year ? $year + 1900 : DateTime->now->year; 2/ It considers 31/01/2015 as a valid us date, which is not. Test plan: 1/ Verify that prove t/DateUtils.t returns green 2/ Play with dates in Koha (yes I know, it's vague...) 3/ Try to find a regression with dates 4/ Create a date with year <= 1900 and confirm it works QA comment: Why the sql format switch was: - $date_string =~ -s/(\d{4})(\d{2})(\d{2})\s+(\d{2})(\d{2})(\d{2})/$1-$2-$3T$4:$5:$6/;
From where a date like "yyyymmdd hhmmss" can come?
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 35407 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35407&action=edit Bug 13601: get rid of DateTime::Format::DateParse This module is used in C4::Members::GetPendingIssues too, but we can use dt_from_string. Test plan: 1/ Verify that prove t/db_dependent/Members/GetPendingIssues.t returns green 2/ On the patron pending issue list, verify that the issue and the due dates are correctly displayed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 35408 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35408&action=edit Bug 13601: Add a fallback check for compability with existing code There are a lot of places where the date comes from the DB but the dateformat parameter is not set to 'sql'. dt_from_string needs to fallback with this format if the pref format does not match. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell@ptfs-europe. | |com --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Colin, As you are the main author of Koha::DateUtils, I really would like to get your opinion on this patch set :) Especially on the QA comment (second patch). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 --- Comment #6 from Colin Campbell <colin.campbell@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #0)
For a couple of reasons, dt_from_string should not use DateTime::Format::DateParse: 1/ It does not manage date < 1900 (certainly caused by l.47 of this module: $p{ year } = $year ? $year + 1900 : DateTime->now->year; 2/ It considers 31/01/2015 as a valid us date, which is not.
The reason dates before 1900 are not handled is in the doc for Date::Parse Date::Parse uses Time::Local internally, so is limited to only parsing dates which result in valid values for Time::Local::timelocal. This generally means dates between 1901-12-17 00:00:00 GMT and 2038-01-16 23:59:59 GMT That wasnt a problem with DateUtils as it was just ensuring the old C4::Dates routines could be handled which were also unable to handle pre 1900 dates -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 --- Comment #7 from Colin Campbell <colin.campbell@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #2)
Created attachment 35406 [details] [review] Bug 13601: Make dt_from_string not using DateTime::Format::DateParse
For a couple of reasons, dt_from_string should not use DateTime::Format::DateParse: 1/ It does not manage date < 1900, certainly caused by l.47 of this module: $p{ year } = $year ? $year + 1900 : DateTime->now->year;
2/ It considers 31/01/2015 as a valid us date, which is not.
Test plan: 1/ Verify that prove t/DateUtils.t returns green 2/ Play with dates in Koha (yes I know, it's vague...) 3/ Try to find a regression with dates 4/ Create a date with year <= 1900 and confirm it works
QA comment: Why the sql format switch was: - $date_string =~ -s/(\d{4})(\d{2})(\d{2})\s+(\d{2})(\d{2})(\d{2})/$1-$2-$3T$4:$5:$6/;
From where a date like "yyyymmdd hhmmss" can come?
C4::Dates supported the format so DateUtils had to accept it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11120 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 35433 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35433&action=edit Bug 13601: Fix special case in basket.pl There is a badly managed date in acqui/basket.pl: if the date is 15/01/2015 (metric format), it will become 2015-1-15 after the following line: $estimateddeliverydate = "$year-$month-$day"; Add_Delta_Days is used at several place, and the ouput is forced to display date on 4 digits and month/day on 2 digits. This patch does the same thing for $estimateddeliverydate. Note that I previously developed a patch to take this format into account (with missing 0) in Koha::DateUtils::dt_from_string, but I don't think it's a good idea to manage bad formated dates. We will certainly find some issues after previous patches, but it will permit to catch them! IMO it's preferable than to keep them hidden. The patch was: diff --git a/Koha/DateUtils.pm b/Koha/DateUtils.pm index 5fe2653..4434a67 100644 --- a/Koha/DateUtils.pm +++ b/Koha/DateUtils.pm @@ -72,17 +72,17 @@ sub dt_from_string { my $fallback_re = qr| (?<year>\d{4}) - - (?<month>\d{2}) + (?<month>\d{1,2}) - - (?<day>\d{2}) + (?<day>\d{1,2}) |xms; if ( $date_format eq 'metric' ) { # metric format is "dd/mm/yyyy[ hh:mm:ss]" $regex = qr| - (?<day>\d{2}) + (?<day>\d{1,2}) / - (?<month>\d{2}) + (?<month>\d{1,2}) / (?<year>\d{4}) |xms; @@ -90,9 +90,9 @@ sub dt_from_string { elsif ( $date_format eq 'us' ) { # us format is "mm/dd/yyyy[ hh:mm:ss]" $regex = qr| - (?<month>\d{2}) + (?<month>\d{1,2}) / - (?<day>\d{2}) + (?<day>\d{1,2}) / (?<year>\d{4}) |xms; diff --git a/t/DateUtils.t b/t/DateUtils.t index 886e1d6..0877240 100755 --- a/t/DateUtils.t +++ b/t/DateUtils.t @@ -189,3 +189,8 @@ is( output_pref( { dt => $dt } ), '31/01/2015 12:34', 'dt_from_string should mat # date before 1900 $dt = dt_from_string('01/01/1900'); is( output_pref( { dt => $dt, dateonly => 1 } ), '01/01/1900', 'dt_from_string should manage date < 1900' ); + +# missing 0 +$dt = dt_from_string('1/1/2015'); +is( output_pref( { dt => $dt, dateonly => 1 } ), '01/01/2015', 'dt_from_string should generate a DT object even if 0 are missing' ); -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> ---
display date on 4 digits and month/day on 2 digits.
It was display *year* on 4 digits and month/day on 2 digits. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10995 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #10 from M. Tompsett <mtompset@hotmail.com> --- There are conflicts in: - t/DateUtils.t - Koha/DateUtils.pm - and something sha1 blob fatal in basket.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35405|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 36733 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36733&action=edit Bug 13601: Add tests to highlight the problems with DateTime::Format::DateParse -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35406|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 36734 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36734&action=edit Bug 13601: Make dt_from_string not using DateTime::Format::DateParse For a couple of reasons, dt_from_string should not use DateTime::Format::DateParse: 1/ It does not manage date < 1900, certainly caused by l.47 of this module: $p{ year } = $year ? $year + 1900 : DateTime->now->year; 2/ It considers 31/01/2015 as a valid us date, which is not. Test plan: 1/ Verify that prove t/DateUtils.t returns green 2/ Play with dates in Koha (yes I know, it's vague...) 3/ Try to find a regression with dates 4/ Create a date with year <= 1900 and confirm it works QA comment: Why the sql format switch was: - $date_string =~ -s/(\d{4})(\d{2})(\d{2})\s+(\d{2})(\d{2})(\d{2})/$1-$2-$3T$4:$5:$6/;
From where a date like "yyyymmdd hhmmss" can come?
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35407|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 36735 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36735&action=edit Bug 13601: get rid of DateTime::Format::DateParse This module is used in C4::Members::GetPendingIssues too, but we can use dt_from_string. Test plan: 1/ Verify that prove t/db_dependent/Members/GetPendingIssues.t returns green 2/ On the patron pending issue list, verify that the issue and the due dates are correctly displayed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35408|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 36736 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36736&action=edit Bug 13601: Add a fallback check for compability with existing code There are a lot of places where the date comes from the DB but the dateformat parameter is not set to 'sql'. dt_from_string needs to fallback with this format if the pref format does not match. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35433|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 36737 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36737&action=edit Bug 13601: Fix special case in basket.pl There is a badly managed date in acqui/basket.pl: if the date is 15/01/2015 (metric format), it will become 2015-1-15 after the following line: $estimateddeliverydate = "$year-$month-$day"; Add_Delta_Days is used at several place, and the ouput is forced to display date on 4 digits and month/day on 2 digits. This patch does the same thing for $estimateddeliverydate. Note that I previously developed a patch to take this format into account (with missing 0) in Koha::DateUtils::dt_from_string, but I don't think it's a good idea to manage bad formated dates. We will certainly find some issues after previous patches, but it will permit to catch them! IMO it's preferable than to keep them hidden. The patch was: diff --git a/Koha/DateUtils.pm b/Koha/DateUtils.pm index 5fe2653..4434a67 100644 --- a/Koha/DateUtils.pm +++ b/Koha/DateUtils.pm @@ -72,17 +72,17 @@ sub dt_from_string { my $fallback_re = qr| (?<year>\d{4}) - - (?<month>\d{2}) + (?<month>\d{1,2}) - - (?<day>\d{2}) + (?<day>\d{1,2}) |xms; if ( $date_format eq 'metric' ) { # metric format is "dd/mm/yyyy[ hh:mm:ss]" $regex = qr| - (?<day>\d{2}) + (?<day>\d{1,2}) / - (?<month>\d{2}) + (?<month>\d{1,2}) / (?<year>\d{4}) |xms; @@ -90,9 +90,9 @@ sub dt_from_string { elsif ( $date_format eq 'us' ) { # us format is "mm/dd/yyyy[ hh:mm:ss]" $regex = qr| - (?<month>\d{2}) + (?<month>\d{1,2}) / - (?<day>\d{2}) + (?<day>\d{1,2}) / (?<year>\d{4}) |xms; diff --git a/t/DateUtils.t b/t/DateUtils.t index 886e1d6..0877240 100755 --- a/t/DateUtils.t +++ b/t/DateUtils.t @@ -189,3 +189,8 @@ is( output_pref( { dt => $dt } ), '31/01/2015 12:34', 'dt_from_string should mat # date before 1900 $dt = dt_from_string('01/01/1900'); is( output_pref( { dt => $dt, dateonly => 1 } ), '01/01/1900', 'dt_from_string should manage date < 1900' ); + +# missing 0 +$dt = dt_from_string('1/1/2015'); +is( output_pref( { dt => $dt, dateonly => 1 } ), '01/01/2015', 'dt_from_string should generate a DT object even if 0 are missing' ); -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 --- Comment #16 from Jonathan Druart <jonathan.druart@biblibre.com> --- Rebase not trivial, please check there is no regression with bug 12669. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12072 CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 --- Comment #17 from Marc Véron <veron@veron.ch> --- Patch did not apply: Applying: Bug 13601: Add tests to highlight the problems with DateTime::Format::DateParse Applying: Bug 13601: Make dt_from_string not using DateTime::Format::DateParse Applying: Bug 13601: get rid of DateTime::Format::DateParse Applying: Bug 13601: Add a fallback check for compability with existing code Applying: Bug 13601: Fix special case in basket.pl fatal: corrupt patch at line 55 Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 13601: Fix special case in basket.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 --- Comment #18 from Marc Véron <veron@veron.ch> --- Created attachment 36745 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36745&action=edit [Signed-off] Bug 13601: Add tests to highlight the problems with DateTime::Format::DateParse Test behaves as expected (Fail as expected with first patch only, OK after 3rd patch) Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36733|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 --- Comment #19 from Marc Véron <veron@veron.ch> --- Created attachment 36746 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36746&action=edit [Signed-off] Bug 13601: Make dt_from_string not using DateTime::Format::DateParse For a couple of reasons, dt_from_string should not use DateTime::Format::DateParse: 1/ It does not manage date < 1900, certainly caused by l.47 of this module: $p{ year } = $year ? $year + 1900 : DateTime->now->year; 2/ It considers 31/01/2015 as a valid us date, which is not. Test plan: 1/ Verify that prove t/DateUtils.t returns green 2/ Play with dates in Koha (yes I know, it's vague...) 3/ Try to find a regression with dates 4/ Create a date with year <= 1900 and confirm it works QA comment: Why the sql format switch was: - $date_string =~ -s/(\d{4})(\d{2})(\d{2})\s+(\d{2})(\d{2})(\d{2})/$1-$2-$3T$4:$5:$6/;
From where a date like "yyyymmdd hhmmss" can come?
Tested patches 1 - 3 together. Worked as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36734|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36735|0 |1 is obsolete| | --- Comment #20 from Marc Véron <veron@veron.ch> --- Created attachment 36747 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36747&action=edit Bug 13601: get rid of DateTime::Format::DateParse This module is used in C4::Members::GetPendingIssues too, but we can use dt_from_string. Test plan: 1/ Verify that prove t/db_dependent/Members/GetPendingIssues.t returns green 2/ On the patron pending issue list, verify that the issue and the due dates are correctly displayed. Tested together with other patches (except "Fix special cases). Worked as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36747|Bug 13601: get rid of |[Signed-off] Bug 13601: get description|DateTime::Format::DateParse |rid of | |DateTime::Format::DateParse -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 --- Comment #21 from Marc Véron <veron@veron.ch> --- Created attachment 36748 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36748&action=edit [Signed-off] Bug 13601: Add a fallback check for compability with existing code There are a lot of places where the date comes from the DB but the dateformat parameter is not set to 'sql'. dt_from_string needs to fallback with this format if the pref format does not match. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36736|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 --- Comment #22 from Marc Véron <veron@veron.ch> --- After signing off the first 4 patches I tried again with "Fix secial case in basket.pl", this one still does not apply with: fatal: corrupt patch at line 55 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13813 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36737|0 |1 is obsolete| | --- Comment #23 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 36754 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36754&action=edit Bug 13601: Fix special case in basket.pl There is a badly managed date in acqui/basket.pl: if the date is 15/01/2015 (metric format), it will become 2015-1-15 after the following line: $estimateddeliverydate = "$year-$month-$day"; Add_Delta_Days is used at several place, and the ouput is forced to display date on 4 digits and month/day on 2 digits. This patch does the same thing for $estimateddeliverydate. Note that I previously developed a patch to take this format into account (with missing 0) in Koha::DateUtils::dt_from_string, but I don't think it's a good idea to manage bad formated dates. We will certainly find some issues after previous patches, but it will permit to catch them! IMO it's preferable than to keep them hidden. The patch was: -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36754|0 |1 is obsolete| | --- Comment #24 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 36755 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36755&action=edit Bug 13601: Fix special case in basket.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 --- Comment #25 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Marc Véron from comment #22)
After signing off the first 4 patches I tried again with "Fix secial case in basket.pl", this one still does not apply with: fatal: corrupt patch at line 55
I c/p a diff in the commit message, git does not like that :) Should be fixed now (I added a tab at the beginning of the lines). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 --- Comment #26 from Marc Véron <veron@veron.ch> --- Created attachment 36756 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36756&action=edit [Signed-off] Bug 13601: Fix special case in basket.pl There is a badly managed date in acqui/basket.pl: if the date is 15/01/2015 (metric format), it will become 2015-1-15 after the following line: $estimateddeliverydate = "$year-$month-$day"; Add_Delta_Days is used at several place, and the ouput is forced to display date on 4 digits and month/day on 2 digits. This patch does the same thing for $estimateddeliverydate. Note that I previously developed a patch to take this format into account (with missing 0) in Koha::DateUtils::dt_from_string, but I don't think it's a good idea to manage bad formated dates. We will certainly find some issues after previous patches, but it will permit to catch them! IMO it's preferable than to keep them hidden. The patch was: diff --git a/Koha/DateUtils.pm b/Koha/DateUtils.pm index 5fe2653..4434a67 100644 --- a/Koha/DateUtils.pm +++ b/Koha/DateUtils.pm @@ -72,17 +72,17 @@ sub dt_from_string { my $fallback_re = qr| (?<year>\d{4}) - - (?<month>\d{2}) + (?<month>\d{1,2}) - - (?<day>\d{2}) + (?<day>\d{1,2}) |xms; if ( $date_format eq 'metric' ) { # metric format is "dd/mm/yyyy[ hh:mm:ss]" $regex = qr| - (?<day>\d{2}) + (?<day>\d{1,2}) / - (?<month>\d{2}) + (?<month>\d{1,2}) / (?<year>\d{4}) |xms; @@ -90,9 +90,9 @@ sub dt_from_string { elsif ( $date_format eq 'us' ) { # us format is "mm/dd/yyyy[ hh:mm:ss]" $regex = qr| - (?<month>\d{2}) + (?<month>\d{1,2}) / - (?<day>\d{2}) + (?<day>\d{1,2}) / (?<year>\d{4}) |xms; diff --git a/t/DateUtils.t b/t/DateUtils.t index 886e1d6..0877240 100755 --- a/t/DateUtils.t +++ b/t/DateUtils.t @@ -189,3 +189,8 @@ is( output_pref( { dt => $dt } ), '31/01/2015 12:34', 'dt_from_string should mat # date before 1900 $dt = dt_from_string('01/01/1900'); is( output_pref( { dt => $dt, dateonly => 1 } ), '01/01/1900', 'dt_from_string should manage date < 1900' ); + +# missing 0 +$dt = dt_from_string('1/1/2015'); +is( output_pref( { dt => $dt, dateonly => 1 } ), '01/01/2015', 'dt_from_string should generate a DT object even if 0 are missing' ); Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36755|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 --- Comment #27 from Marc Véron <veron@veron.ch> --- Hi Jonathan, Is it possible to extract the regexp part in patch "Make dt_from_string not using DateTime::Format::DateParse" to a separate sub (as replacement for the regexp function in C4::Dates)? Or should it be done in Bug 13813? Marc -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 --- Comment #28 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Marc Véron from comment #27)
Hi Jonathan,
Is it possible to extract the regexp part in patch "Make dt_from_string not using DateTime::Format::DateParse" to a separate sub (as replacement for the regexp function in C4::Dates)?
Or should it be done in Bug 13813?
Marc
Hello Marc, I would prefer not to add any other changes to this patch set. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 --- Comment #29 from Marc Véron <veron@veron.ch> --- Ok, I set to Signed-off and hope that it will be soon QAed and pushed to master :-) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13813 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer@bsz-bw.de --- Comment #30 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This breaks t/Letters.t - tests pass OK on master: perl t/Letters.t 1..5 ok 1 - use C4::Letters; ok 2 - letter name for "ISBN" letter is book ok 3 - GetLetters returns the 2 inserted letters Use of uninitialized value $date_format in string eq at /home/katrin/kohaclone/Koha/DateUtils.pm line 79. Use of uninitialized value $date_format in string eq at /home/katrin/kohaclone/Koha/DateUtils.pm line 89. Use of uninitialized value $date_format in string eq at /home/katrin/kohaclone/Koha/DateUtils.pm line 99. Use of uninitialized value $date_format in string eq at /home/katrin/kohaclone/Koha/DateUtils.pm line 99. Use of uninitialized value $date_format in concatenation (.) or string at /home/katrin/kohaclone/Koha/DateUtils.pm line 104. Invalid dateformat parameter () at /home/katrin/kohaclone/Koha/DateUtils.pm line 104. # Looks like you planned 5 tests but ran 3. # Looks like your test exited with 255 just after 3. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 --- Comment #31 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 36928 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36928&action=edit Bug 13601: t/Letters.t needs to mock the dateformat pref -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 --- Comment #32 from Marc Véron <veron@veron.ch> --- Created attachment 36933 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36933&action=edit [Signed-off] Bug 13601: t/Letters.t needs to mock the dateformat pref Test passes OK. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36928|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #33 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am having problems checking out items with a certain due time with this date. For a test I am checking out an item, with the due date specified to: 19/03/2015 07:45 But the item checks out with: 19/03/2015 00:00 But... in the database it shows the correct due date, it's just not being displayed? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 --- Comment #34 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 36939 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36939&action=edit Bug 13601: The fallback regex should contain the time part On displaying a sql date, if the dateformat is not set to sql, the output should contain the date. In the previous version, the fallback regex (used for sql format) did not included the time part (hh:mm:ss). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 --- Comment #35 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #33)
I am having problems checking out items with a certain due time with this date.
For a test I am checking out an item, with the due date specified to: 19/03/2015 07:45 But the item checks out with: 19/03/2015 00:00
But... in the database it shows the correct due date, it's just not being displayed?
Good catch Katrin! All sql dates were impacted. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 --- Comment #36 from Marc Véron <veron@veron.ch> --- Created attachment 37023 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37023&action=edit [Signed-off] Bug 13601: The fallback regex should contain the time part On displaying a sql date, if the dateformat is not set to sql, the output should contain the date. In the previous version, the fallback regex (used for sql format) did not included the time part (hh:mm:ss). Checked out an item with due date an ddue time. Time displays as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36939|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36933|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36745|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36746|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36747|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36748|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36756|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37023|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 --- Comment #37 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 37087 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37087&action=edit [PASSED QA] Bug 13601: Add tests to highlight the problems with DateTime::Format::DateParse Test behaves as expected (Fail as expected with first patch only, OK after 3rd patch) Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 --- Comment #38 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 37088 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37088&action=edit [PASSED QA] Bug 13601: Make dt_from_string not using DateTime::Format::DateParse For a couple of reasons, dt_from_string should not use DateTime::Format::DateParse: 1/ It does not manage date < 1900, certainly caused by l.47 of this module: $p{ year } = $year ? $year + 1900 : DateTime->now->year; 2/ It considers 31/01/2015 as a valid us date, which is not. Test plan: 1/ Verify that prove t/DateUtils.t returns green 2/ Play with dates in Koha (yes I know, it's vague...) 3/ Try to find a regression with dates 4/ Create a date with year <= 1900 and confirm it works QA comment: Why the sql format switch was: - $date_string =~ -s/(\d{4})(\d{2})(\d{2})\s+(\d{2})(\d{2})(\d{2})/$1-$2-$3T$4:$5:$6/;
From where a date like "yyyymmdd hhmmss" can come?
Tested patches 1 - 3 together. Worked as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 --- Comment #39 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 37089 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37089&action=edit [PASSED QA] Bug 13601: get rid of DateTime::Format::DateParse This module is used in C4::Members::GetPendingIssues too, but we can use dt_from_string. Test plan: 1/ Verify that prove t/db_dependent/Members/GetPendingIssues.t returns green 2/ On the patron pending issue list, verify that the issue and the due dates are correctly displayed. Tested together with other patches (except "Fix special cases). Worked as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 --- Comment #40 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 37090 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37090&action=edit [PASSED QA] Bug 13601: Add a fallback check for compability with existing code There are a lot of places where the date comes from the DB but the dateformat parameter is not set to 'sql'. dt_from_string needs to fallback with this format if the pref format does not match. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 --- Comment #41 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 37091 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37091&action=edit [PASSED QA] Bug 13601: Fix special case in basket.pl There is a badly managed date in acqui/basket.pl: if the date is 15/01/2015 (metric format), it will become 2015-1-15 after the following line: $estimateddeliverydate = "$year-$month-$day"; Add_Delta_Days is used at several place, and the ouput is forced to display date on 4 digits and month/day on 2 digits. This patch does the same thing for $estimateddeliverydate. Note that I previously developed a patch to take this format into account (with missing 0) in Koha::DateUtils::dt_from_string, but I don't think it's a good idea to manage bad formated dates. We will certainly find some issues after previous patches, but it will permit to catch them! IMO it's preferable than to keep them hidden. The patch was: diff --git a/Koha/DateUtils.pm b/Koha/DateUtils.pm index 5fe2653..4434a67 100644 --- a/Koha/DateUtils.pm +++ b/Koha/DateUtils.pm @@ -72,17 +72,17 @@ sub dt_from_string { my $fallback_re = qr| (?<year>\d{4}) - - (?<month>\d{2}) + (?<month>\d{1,2}) - - (?<day>\d{2}) + (?<day>\d{1,2}) |xms; if ( $date_format eq 'metric' ) { # metric format is "dd/mm/yyyy[ hh:mm:ss]" $regex = qr| - (?<day>\d{2}) + (?<day>\d{1,2}) / - (?<month>\d{2}) + (?<month>\d{1,2}) / (?<year>\d{4}) |xms; @@ -90,9 +90,9 @@ sub dt_from_string { elsif ( $date_format eq 'us' ) { # us format is "mm/dd/yyyy[ hh:mm:ss]" $regex = qr| - (?<month>\d{2}) + (?<month>\d{1,2}) / - (?<day>\d{2}) + (?<day>\d{1,2}) / (?<year>\d{4}) |xms; diff --git a/t/DateUtils.t b/t/DateUtils.t index 886e1d6..0877240 100755 --- a/t/DateUtils.t +++ b/t/DateUtils.t @@ -189,3 +189,8 @@ is( output_pref( { dt => $dt } ), '31/01/2015 12:34', 'dt_from_string should mat # date before 1900 $dt = dt_from_string('01/01/1900'); is( output_pref( { dt => $dt, dateonly => 1 } ), '01/01/1900', 'dt_from_string should manage date < 1900' ); + +# missing 0 +$dt = dt_from_string('1/1/2015'); +is( output_pref( { dt => $dt, dateonly => 1 } ), '01/01/2015', 'dt_from_string should generate a DT object even if 0 are missing' ); Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 --- Comment #42 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 37092 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37092&action=edit [PASSED QA] Bug 13601: t/Letters.t needs to mock the dateformat pref Test passes OK. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 --- Comment #43 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 37093 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37093&action=edit [PASSED QA] Bug 13601: The fallback regex should contain the time part On displaying a sql date, if the dateformat is not set to sql, the output should contain the date. In the previous version, the fallback regex (used for sql format) did not included the time part (hh:mm:ss). Checked out an item with due date an ddue time. Time displays as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #44 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Good job Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13933 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14016 See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10423, | |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12847 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14194 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|13813 | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12072 | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14794 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org