[Bug 8056] New: CircAutoPrintQuickSlip set to clear doesn't work
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8056 Priority: P5 - low Change sponsored?: --- Bug ID: 8056 CC: gmcharlt@gmail.com Assignee: kyle.m.hall@gmail.com Summary: CircAutoPrintQuickSlip set to clear doesn't work Severity: critical Classification: Unclassified OS: All Reporter: nengard@gmail.com Hardware: All Status: NEW Version: master Component: Circulation Product: Koha I have CircAutoPrintQuickSlip set to clear the screen but when I enter a blank barcode I get the following error: Software error: Undefined subroutine &main::PrintIssueSlip called at /home/nengard/kohaclone/circ/circulation.pl line 175. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8056 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7001 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8056 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|kyle.m.hall@gmail.com |srdjan@catalyst.net.nz --- Comment #1 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 9468 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9468&action=edit patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8056 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9468|0 |1 is obsolete| | --- Comment #2 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 9472 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9472&action=edit [SIGNED-OFF] bug_8056: sorted out slip print calls Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8056 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8056 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |koha.sekjal@gmail.com --- Comment #3 from Ian Walls <koha.sekjal@gmail.com> --- Breaks Plack scoping fix for our $todaysdate, throwing it back to 'my'. Marking Failed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8056 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9472|0 |1 is obsolete| | --- Comment #4 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 9506 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9506&action=edit patch Well it was an unsolicited change, I'm sorry. However, whatever problem was solved by changing that "my" "our" should be revisited, that is usually more of a hack than a good solution. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8056 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8056 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- I don't know if this file is used, but t/db_dependent/lib/KohaTest/Print.pm contains: my @methods = qw( printslip ); and the patch remove this sub, so I think this file should be modified too. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8056 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9506|0 |1 is obsolete| | --- Comment #6 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 9549 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9549&action=edit patch Good catch, corrected. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8056 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9549|0 |1 is obsolete| | --- Comment #7 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 9557 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9557&action=edit [SIGNED-OFF] bug_8056: sorted out slip print calls Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> preference works as expected. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8056 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8056 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com --- Comment #8 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: * remove more code than it adds. Good point ;-) * clean code, passes perlcritic (remove 1 perlcritic problem. 2 still here, but were here before the patch) passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8056 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_8 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8056 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- No database changes, fixes a regression, pushed to 3.8.x will be in 3.8.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org