[Bug 8014] New: On the patron entry form hide "restricted until" field if "Restricted: No" is checked
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8014 Priority: P5 - low Change sponsored?: --- Bug ID: 8014 CC: gmcharlt@gmail.com Assignee: oleonard@myacpl.org Summary: On the patron entry form hide "restricted until" field if "Restricted: No" is checked QA Contact: koha.sekjal@gmail.com Severity: minor Classification: Unclassified OS: All Reporter: oleonard@myacpl.org URL: /cgi-bin/koha/members/memberentry.pl Hardware: All Status: ASSIGNED Version: master Component: Patrons Product: Koha On the patron entry form I think it would be clearer if the "restricted until" form field was hidden if "Restricted: No" is checked. This remove any ambiguity about whether the field can or should be filled in independently of the "Restricted" options. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8014 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 9312 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9312&action=edit Bug 8014 - On the patron entry form hide "restricted until" field if "Restricted: No" is checked This patch adds JavaScript to automatically hide the "Restricted unil" form field on the patron entry form if "Restricted: No" is selected. If "Restricted: Yes" is chosen the "Until:" field is shown and focus is given to it. The patch also adds a note, "(optional)" after the "Until:" field to make it clearer that a date is not required. To test, open a patron record and try moving the selection between "Restricted: No" and "Restricted: Yes." Confirm that the "Until:" field is shown and hidden as expected. Confirm that the restricted flag is correctly set or unset upon save, including setting the flag with or without a date. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8014 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8014 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9312|0 |1 is obsolete| | --- Comment #2 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 9534 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9534&action=edit Bug 8014 - On the patron entry form hide "restricted until" field if "Restricted: No" is checked This patch adds JavaScript to automatically hide the "Restricted unil" form field on the patron entry form if "Restricted: No" is selected. If "Restricted: Yes" is chosen the "Until:" field is shown and focus is given to it. The patch also adds a note, "(optional)" after the "Until:" field to make it clearer that a date is not required. To test, open a patron record and try moving the selection between "Restricted: No" and "Restricted: Yes." Confirm that the "Until:" field is shown and hidden as expected. Confirm that the restricted flag is correctly set or unset upon save, including setting the flag with or without a date. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8014 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8014 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com --- Comment #3 from Paul Poulain <paul.poulain@biblibre.com> --- QA Comment : tiny patch, js and tt only, nothing specific to say passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8014 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_8 --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> --- pushed, usefull for 3.8 I think, so versionning 3.8 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8014 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- I agree useful for for 3.8.x, will be in 3.8.2 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org