[Bug 24338] New: CASH is missing from the default payment_types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 Bug ID: 24338 Summary: CASH is missing from the default payment_types Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org Bug 23321 added cash registers to koha which utilise a payment_type value of CASH which is expected to be present in the system by default. It appears that this part of the DB update went missing during subsequent rebases of the patchset :( -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22321 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 [Bug 22321] Make it possible to edit illrequests.borrowernumber -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24339 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339 [Bug 24339] SIP codes are missing from the default payment_types on installation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23894 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23894 [Bug 23894] accountlines.payment_type and accountlines.credit_type should be merged -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|22321 |23321 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 [Bug 22321] Make it possible to edit illrequests.borrowernumber https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23321 [Bug 23321] Add 'cash registers' to the accounts system -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 Bug 24338 depends on bug 23321, which changed state. Bug 23321 Summary: Add 'cash registers' to the accounts system https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23321 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 97972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97972&action=edit Bug 24338: Add 'CASH' to default 'PAYMENT_TYPE' AV Bug 23321 adds cash registers to the koha accounts system and as part of that work introduces the 'CASH' payment type as a required option to allow requirment of a 'CASH_REGISTER' when making cash payments. The original patchset, however, forgot to add this new authorised value during installation and upgrade. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com, | |nick@bywatersolutions.com, | |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24525 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24525 [Bug 24525] Hide SIP payment types from the Point of Sale page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #2 from David Nind <david@davidnind.com> --- On master I can already see a CASH payment type, so not sure whether this is required or not. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |19.11 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- OK, so on master it's already added in bug 23354, but it's not in the 19.11 branch yet. Setting branch appropriately. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #4 from David Nind <david@davidnind.com> --- Patch doesn't apply on 19.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97972|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98381&action=edit Bug 24338: Add 'CASH' to default 'PAYMENT_TYPE' AV Bug 23321 adds cash registers to the koha accounts system and as part of that work introduces the 'CASH' payment type as a required option to allow requirment of a 'CASH_REGISTER' when making cash payments. The original patchset, however, forgot to add this new authorised value during installation and upgrade. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Does it matter that this is not idempotent? You can have repeated values in the authorised_values table with no complaints - should there be a key on id,category,authorised_value? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 98388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98388&action=edit Bug 24338: (QA follow-up) Make update idempotent -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Good catch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|24525 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24525 [Bug 24525] Hide SIP payment types from the Point of Sale page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98381|0 |1 is obsolete| | --- Comment #9 from David Nind <david@davidnind.com> --- Created attachment 98412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98412&action=edit Bug 24338: Add 'CASH' to default 'PAYMENT_TYPE' AV Bug 23321 adds cash registers to the koha accounts system and as part of that work introduces the 'CASH' payment type as a required option to allow requirment of a 'CASH_REGISTER' when making cash payments. The original patchset, however, forgot to add this new authorised value during installation and upgrade. Test plan: 1) Check the values shown for the PAYMENT_TYPE authorized value category (Home > Administration > Basic parameters > Authorized values) 2) There should be no CASH authorized value 3) Apply the patch 4) Run the database update (perl installer/data/mysql/updatedatabase.pl) 5) Refresh the PAYMENT_TYPE authorized value page 6) A CASH authorized value should now be one of the values 7) Sign-off! Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98388|0 |1 is obsolete| | --- Comment #10 from David Nind <david@davidnind.com> --- Created attachment 98413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98413&action=edit Bug 24338: (QA follow-up) Make update idempotent Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Do we really need the print statements? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #11)
Do we really need the print statements?
Oops, not at all.. leftover debugging whilst I was working on the DB update.. my bad. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98412|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 98490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98490&action=edit Bug 24338: Add 'CASH' to default 'PAYMENT_TYPE' AV Bug 23321 adds cash registers to the koha accounts system and as part of that work introduces the 'CASH' payment type as a required option to allow requirment of a 'CASH_REGISTER' when making cash payments. The original patchset, however, forgot to add this new authorised value during installation and upgrade. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98413|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 98491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98491&action=edit Bug 24338: (QA follow-up) Make update idempotent Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Second patch now corrected to remove debug print lines. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98490|0 |1 is obsolete| | Attachment #98491|0 |1 is obsolete| | --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98504&action=edit Bug 24338: Add 'CASH' to default 'PAYMENT_TYPE' AV Bug 23321 adds cash registers to the koha accounts system and as part of that work introduces the 'CASH' payment type as a required option to allow requirment of a 'CASH_REGISTER' when making cash payments. The original patchset, however, forgot to add this new authorised value during installation and upgrade. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98505&action=edit Bug 24338: (QA follow-up) Make update idempotent Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.03 released in| | Status|Passed QA |Pushed to stable CC| |joy@bywatersolutions.com --- Comment #18 from Joy Nelson <joy@bywatersolutions.com> --- Pushed to 19.11.x branch for 19.11.03 release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fix adds CASH as an release notes| |authorized value for | |PAYMENT_TYPES. This is | |required for the new cash | |register feature. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #19 from Lucas Gass <lucas@bywatersolutions.com> --- missing dependencies for 19.05.x, no backport -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 Bug 24338 depends on bug 24339, which changed state. Bug 24339 Summary: SIP codes are missing from the default payment_types on installation https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org