[Bug 24339] New: SIP codes are missing from the default payment_types on installation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339 Bug ID: 24339 Summary: SIP codes are missing from the default payment_types on installation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org Bug 22610 moved the sip payment types out of accounttypes and into the payment_types authorized values.. however, it appears during rebases that the installation side of this was lost and only existing systems will populate the payment_type defaults on upgrade. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22610 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 [Bug 22610] SIP Payment Types should be moved out of accountype -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24338 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 [Bug 24338] CASH is missing from the default payment_types -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 96976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96976&action=edit Bug 24339: Add SIP2 payment types for installation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 96988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96988&action=edit Bug 24339: Remove SIP payment types from staff pay screens -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Test plan 1) Perform a fresh install and note that the SIP code payments types are populated in the authorised_values table. 2) Make a payment via the staff client and note that the payment_type dropdown still does not appear when only the SIP types are defined. 3) Define some additional payment types and make a payment again.. Note that the new payment types are displayed in the dropdown but the SIP one's are not. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |kyle@bywatersolutions.com, | |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell@ptfs-europe. | |com, | |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Martin, can yo help me with the test plan? Where do we define the SIP payment types? Also... this is failing QA tests rather spectacularly: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt OK filters OK forbidden patterns OK git manipulation OK js_in_body OK spelling OK tt_valid FAIL valid_template The method Koha::AuthorisedValue->size is not covered by tests! Trace begun at /home/vagrant/kohaclone/Koha/Object.pm line 670 Koha::Object::AUTOLOAD('Koha::AuthorisedValue=HASH(0x56078bb1a4c0)') called at /home/vagrant/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt line 273 eval {...} at /home/vagrant/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt line 273 eval {...} at /home/vagrant/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt line 7 Template::Document::__ANON__('Template::Context=HASH(0x56078c113160)') called at /usr/lib/x86_64-linux-gnu/perl5/5.24/Template/Document.pm line 163 eval {...} at /usr/lib/x86_64-linux-gnu/perl5/5.24/Template/Document.pm line 161 Template::Document::process('Template::Document=HASH(0x56078bb2c0e0)', 'Template::Context=HASH(0x56078c113160)') called at /usr/lib/x86_64-linux-gnu/perl5/5.24/Template/Context.pm line 351 eval {...} at /usr/lib/x86_64-linux-gnu/perl5/5.24/Template/Context.pm line 321 Template::Context::process('Template::Context=HASH(0x56078c113160)', 'Template::Document=HASH(0x56078bb2c0e0)') called at /usr/lib/x86_64-linux-gnu/perl5/5.24/Template/Service.pm line 94 eval {...} at /usr/lib/x86_64-linux-gnu/perl5/5.24/Template/Service.pm line 91 Template::Service::process('Template::Service=HASH(0x56078bfa9478)', '/home/vagrant/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt', 'HASH(0x56078c03e178)') called at /usr/lib/x86_64-linux-gnu/perl5/5.24/Template.pm line 66 Template::process('Template=HASH(0x56078bf1d2f0)', '/home/vagrant/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt', 'HASH(0x56078c03e178)', 'SCALAR(0x560783ebf940)') called at /home/vagrant/qa-test-tools/QohA/File/Template.pm line 94 QohA::File::Template::check_valid_template('QohA::File::Template=HASH(0x560781181158)') called at /home/vagrant/qa-test-tools/QohA/File/Template.pm line 23 QohA::File::Template::run_checks('QohA::File::Template=HASH(0x560781181158)', 2) called at /home/vagrant/qa-test-tools/koha-qa.pl line 99 eval {...} at /home/vagrant/qa-test-tools/koha-qa.pl line 67 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Regarding test plan, the Payments types are just Authorized Values as they have been for years.. this patch just ensures they are present for installs (currently they're just populated during upgrades). Hmm, I can't replicate your test failure either :( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96976|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 97676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97676&action=edit Bug 24339: Add SIP2 payment types for installation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96988|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 97677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97677&action=edit Bug 24339: Remove SIP payment types from staff pay screens -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- [% SET excluded = ['SIP00', 'SIP01', 'SIP02'] %] [% IF payment_types > 3 %] I do not think it's regression free (maybe SIP* have been removed from the AV?) I would say we should test if payment_types - excluded > 0 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- If we set it to >0 it'll be a regression in so much as we will now always show the 'Payment type' dropdown even if only system types are defined. I'm not sure how we can reduce the payment_types list to not include the SIP types in the first place in those templates.. that would be the better solution. This is really only meant as a stop gap solution.. I hope to merge the payment_types authorized value into the debit_types table and expose more clearly defined options relating to the types in bug 23894 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 97962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97962&action=edit Bug 24339: Do not assume there are exactly 3 SIP* AVs Update DB entry 19.06.00.017: We created SIP* AV from accountlines if '^Pay[[:digit:]]{2}$', so I think we should assume that more than SIP00, SIP01, SIP02 can exist. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Martin Renvoize from comment #9)
If we set it to >0 it'll be a regression in so much as we will now always show the 'Payment type' dropdown even if only system types are defined.
I do not understand what you meant here. I suggested "payment_types - excluded > 0" What about this follow-up? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339 --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Misread your comment -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339 --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- OK, I like your followup, it's much nicer than my original attempt. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97962|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 97963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97963&action=edit Bug 24339: Do not assume there are exactly 3 SIP* AVs Update DB entry 19.06.00.017: We created SIP* AV from accountlines if '^Pay[[:digit:]]{2}$', so I think we should assume that more than SIP00, SIP01, SIP02 can exist. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97676|0 |1 is obsolete| | Attachment #97677|0 |1 is obsolete| | Attachment #97963|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 97965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97965&action=edit Bug 24339: Add SIP2 payment types for installation Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 97966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97966&action=edit Bug 24339: Remove SIP payment types from staff pay screens Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339 --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 97967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97967&action=edit Bug 24339: Do not assume there are exactly 3 SIP* AVs Update DB entry 19.06.00.017: We created SIP* AV from accountlines if '^Pay[[:digit:]]{2}$', so I think we should assume that more than SIP00, SIP01, SIP02 can exist. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339 --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|RM_priority | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24525 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24525 [Bug 24525] Hide SIP payment types from the Point of Sale page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|24525 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24525 [Bug 24525] Hide SIP payment types from the Point of Sale page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24525 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24525 [Bug 24525] Hide SIP payment types from the Point of Sale page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339 --- Comment #19 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Could we unify the code in boraccount please? Also it seems than we will need to move this code in an include file, to avoid seeing it c/p all over the members template modules... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #20 from Joy Nelson <joy@bywatersolutions.com> --- not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339 --- Comment #21 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 104619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104619&action=edit [19.11.x] Bug 24339: Add SIP2 payment types for installation Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339 --- Comment #22 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 104620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104620&action=edit [19.11.x] Bug 24339: Remove SIP payment types from staff pay screens Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339 --- Comment #23 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 104621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104621&action=edit [19.11.x] Bug 24339: Do not assume there are exactly 3 SIP* AVs Update DB entry 19.06.00.017: We created SIP* AV from accountlines if '^Pay[[:digit:]]{2}$', so I think we should assume that more than SIP00, SIP01, SIP02 can exist. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.06 released in| | Status|Pushed to master |Pushed to stable --- Comment #24 from Joy Nelson <joy@bywatersolutions.com> --- backported to 19.11.x for 19.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED CC| |lucas@bywatersolutions.com Resolution|--- |FIXED --- Comment #25 from Lucas Gass <lucas@bywatersolutions.com> --- missing dependencies for 19.05.x, no backport -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org