[Bug 6982] New: Don't show MARC21 tag documentation links for NORMARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6982 Bug #: 6982 Summary: Don't show MARC21 tag documentation links for NORMARC Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: minor Priority: P5 Component: Cataloging AssignedTo: magnus@enger.priv.no ReportedBy: magnus@enger.priv.no QAContact: koha-bugs@lists.koha-community.org CC: ian.walls@bywatersolutions.com Showing the links to MARC21 tag documentation on the cataloguing screen makes little sense when NORMARC is the chosen MARC dialect. The best solution would of course be to link to NORMARC tag documentation instead, but since there is currently no representation of NORMARC on the web where individual tags can be linked to, this will have to wait. The solution I will try to implement is to hide the links alltogether. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6982 --- Comment #1 from Magnus Enger <magnus@enger.priv.no> 2011-10-06 18:24:52 UTC --- Hm, looks like the MARC21 links are shown for UNIMARC as well - does anyone using UNIMARC have an opinion about hiding them for UNIMARC? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6982 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Don't show MARC21 tag |Don't show MARC21 tag |documentation links for |documentation links for |NORMARC |NORMARC (and UNIMARC?) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6982 dev_patches@biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dev_patches@biblibre.com --- Comment #2 from dev_patches@biblibre.com 2011-10-07 10:32:22 UTC --- same feeling for UNIMARC. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6982 --- Comment #3 from Magnus Enger <magnus@enger.priv.no> 2011-10-07 11:54:22 UTC --- Created attachment 5765 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5765 Bug 6982 - Don't show MARC tag documentation links for NORMARC Links to UNIMARC documentation were being shown when marcflavour = NORMARC. This patch hides the doc link functionality for NORMARC by hiding: 1. The checkbox for turning doc links on/off 2. The hyperlinked questionmarks This patch does not hide e.g. the JavaScript functions related to the doc link functionality, in order to make it easy to add doc links for NORMARC in the future (hopefully). The doc link functionality was passing a variable called MARC21 (based on the contents of the marcflavour syspref) to the template and testing the value of this to decide if MARC21 or UNIMARC doc links were to be shown. I have replaced this variable with he standard/full marcflavour syspref, in order to make it possible to test for more then two MARC dialects. To test: - Set the marcflavour syspref to MARC21, NORMARC and UNIMARC, one after the other. - Check that correct doc links are shown for MARC21 and UNIMARC on the cataloguing screen, and that no checkbox and no doc links are displayed for NORMARC. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6982 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff --- Comment #4 from Magnus Enger <magnus@enger.priv.no> 2011-10-07 11:55:56 UTC --- Sorry, I was mistaken in thinking that the wrong doc links were shown for UNIMARC. This patch only addresses NORMARC. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6982 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Don't show MARC21 tag |Don't show MARC21 tag |documentation links for |documentation links for |NORMARC (and UNIMARC?) |NORMARC -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6982 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5765|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-10-17 19:01:47 UTC --- Created attachment 5940 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5940 [SIGNED-OFF] Bug 6982 - Don't show MARC tag documentation links for NORMARC Links to UNIMARC documentation were being shown when marcflavour = NORMARC. This patch hides the doc link functionality for NORMARC by hiding: 1. The checkbox for turning doc links on/off 2. The hyperlinked questionmarks This patch does not hide e.g. the JavaScript functions related to the doc link functionality, in order to make it easy to add doc links for NORMARC in the future (hopefully). The doc link functionality was passing a variable called MARC21 (based on the contents of the marcflavour syspref) to the template and testing the value of this to decide if MARC21 or UNIMARC doc links were to be shown. I have replaced this variable with he standard/full marcflavour syspref, in order to make it possible to test for more then two MARC dialects. To test: - Set the marcflavour syspref to MARC21, NORMARC and UNIMARC, one after the other. - Check that correct doc links are shown for MARC21 and UNIMARC on the cataloguing screen, and that no checkbox and no doc links are displayed for NORMARC. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described - thx for the great test plan! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6982 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6982 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Passed QA --- Comment #6 from Ian Walls <ian.walls@bywatersolutions.com> 2011-10-18 15:28:59 UTC --- Simplifies perl code, and consistently adds more robust support for alternate MARC formats in template. Marking as Passed QA. Hopefully we can find a good source for NORMARC documentation that can be included! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6982 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Passed QA |Patch Pushed --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> 2011-10-19 03:55:15 UTC --- Pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6982 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #8 from Magnus Enger <magnus@enger.priv.no> --- Works in 3.6.4. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org