[Bug 6620] New: Sip Server Output may be buffered
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6620 Bug #: 6620 Summary: Sip Server Output may be buffered Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: SIP2 AssignedTo: colin.campbell@ptfs-europe.com ReportedBy: colin.campbell@ptfs-europe.com QAContact: koha-bugs@lists.koha-community.org Bug fix 5586 correctly removed the linefeed from sipserver output. However as the server writes to stdout which is by default buffered this means that we cannot guarantee that responses are being returned in a timely fashion. In practice this can be perceived as extremely slow performance by the self-check unit or a cease of functioning altogether (the unit timesout). In practice reverting 5586 fixes this but as 5586 'does the right thing' this is not a good solution. The proposed solution is that autoflush is specifically set on the output filehandle, to ensure the response message is not buffered. Note because of the nature of the problem it is hard to reproduce the bug consistently, -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6620 --- Comment #1 from Colin Campbell <colin.campbell@ptfs-europe.com> 2011-07-21 11:26:50 UTC --- Created attachment 4698 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4698 Proposed Patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6620 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Status|NEW |ASSIGNED Patch Status|--- |Needs Signoff Severity|enhancement |major -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6620 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-09-01 11:11:18 UTC --- I think this is difficult to test. Would it be ok to verify that SIP still works after patch was applied? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6620 --- Comment #3 from Colin Campbell <colin.campbell@ptfs-europe.com> 2011-09-01 12:00:29 UTC --- Katrin's correct. If your sipserver works fine with your unit then the test is that it dosen't introduce regressions. If you have 3M (or other) self-checks timing out and restarting or failing this because of timeouts this should fix it. NB logging can be deceptive as the log gets flushed, so you see the outgoing message even if the packet has not been transmitted to the unit. It looks like the unit is at fault unless you monitor the line itself. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6620 --- Comment #4 from Ulrich Kleiber <ulrich.kleiber@bsz-bw.de> 2011-09-13 14:03:34 UTC --- Created attachment 5415 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5415 no regression after applying patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6620 --- Comment #5 from Ulrich Kleiber <ulrich.kleiber@bsz-bw.de> 2011-09-13 14:05:00 UTC --- Comment on attachment 5415 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5415 no regression after applying patch tested with v3.04.04 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6620 Ulrich Kleiber <ulrich.kleiber@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ulrich.kleiber@bsz-bw.de Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6620 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Signed Off |Patch Pushed --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> 2011-09-14 09:42:17 UTC --- Simple patch, pushed -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6620 --- Comment #7 from Chris Nighswonger <cnighswonger@foundations.edu> 2011-10-26 18:02:13 UTC --- The fix for this bug was published in the 3.4.5 release. If you were the reporter of this bug, please take time to verify the fix and update the status of this bug report accordingly. If the bug is fixed to your satisfaction, please close this report. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6620 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #8 from Colin Campbell <colin.campbell@ptfs-europe.com> 2011-10-27 18:57:07 UTC --- Confirmed works in production on sites where buffered i/o was causing failures -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6620 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7619 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org