[Bug 9690] New: Replace YUI buttons on the catalog search results page with Bootstrap
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9690 Bug ID: 9690 Summary: Replace YUI buttons on the catalog search results page with Bootstrap Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/catalogue/search.pl OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org "Save," "Place hold," and "Z39.50 search" buttons on the catalog search results page are generated by YUI. They should use Bootstrap instead. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9690 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9690 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 15634 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15634&action=edit Bug 9690 - Replace YUI buttons on the catalog search results page with Bootstrap "Save," "Place hold," and "Z39.50 search" buttons on the catalog search results page are generated by YUI. This patch removes YUI styling from the "Save" button and uses Bootstrap to apply styling to the "Place hold" and "Z39.50 search" button. The "search to hold" split button menu is converted to Bootstrap as well. The "Save" button's appearance is inconsistent with the Bootstrap ones, but right now we don't have a good method for overriding the default submit button CSS with Bootstrap button styling. I hope this can be dealt with in a more global way in a subsequent patch. To test, search the catalog in the staff client. Confirm that the "Save," "Place hold," and "Z39.50 search" buttons look correct and work correctly. Also select a patron and "search to hold," confirming the functionality of all the opitions added to the "Place hold" button menu. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9690 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15634|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 15636 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15636&action=edit [SIGNED-OFF] Bug 9690 - Replace YUI buttons on the catalog search results page with Bootstrap "Save," "Place hold," and "Z39.50 search" buttons on the catalog search results page are generated by YUI. This patch removes YUI styling from the "Save" button and uses Bootstrap to apply styling to the "Place hold" and "Z39.50 search" button. The "search to hold" split button menu is converted to Bootstrap as well. The "Save" button's appearance is inconsistent with the Bootstrap ones, but right now we don't have a good method for overriding the default submit button CSS with Bootstrap button styling. I hope this can be dealt with in a more global way in a subsequent patch. To test, search the catalog in the staff client. Confirm that the "Save," "Place hold," and "Z39.50 search" buttons look correct and work correctly. Also select a patron and "search to hold," confirming the functionality of all the opitions added to the "Place hold" button menu. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: All buttons works ok, nice looking. No errors. On button 'Place hold', all opitions works :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9690 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9690 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9690 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15636|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 15873 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15873&action=edit [PASSED QA] Bug 9690 - Replace YUI buttons on the catalog search results page with Bootstrap "Save," "Place hold," and "Z39.50 search" buttons on the catalog search results page are generated by YUI. This patch removes YUI styling from the "Save" button and uses Bootstrap to apply styling to the "Place hold" and "Z39.50 search" button. The "search to hold" split button menu is converted to Bootstrap as well. The "Save" button's appearance is inconsistent with the Bootstrap ones, but right now we don't have a good method for overriding the default submit button CSS with Bootstrap button styling. I hope this can be dealt with in a more global way in a subsequent patch. To test, search the catalog in the staff client. Confirm that the "Save," "Place hold," and "Z39.50 search" buttons look correct and work correctly. Also select a patron and "search to hold," confirming the functionality of all the opitions added to the "Place hold" button menu. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: All buttons works ok, nice looking. No errors. On button 'Place hold', all opitions works :) Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works nicely, no problems found. Noticed that buttons here are smaller than in other places, but this has been so before. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9690 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de QA Contact| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9690 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9779 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9690 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org