[Bug 9466] New: Use DataTables on saved reports page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9466 Bug ID: 9466 Summary: Use DataTables on saved reports page Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/reports/guided_reports.pl?phase=Use saved OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org The saved reports page uses the old tablesorter plugin. It should use the DataTables plugin instead. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9466 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9466 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 14799 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14799&action=edit Bug 9466 - Use DataTables on saved reports page Replace the tablesorter plugin with the DataTables plugin on the saved reports page. To test, open the saved reports page (Reports > Use saved). Confirm that table sorting works correctly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9466 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Hi Owen, I found a bug in all the datatable patchs :-/ The iDisplayLength value equal 20 but this value is not in the aLengthMenu, so the selected value is 10. The default values of datatable is 10, 25, 50 and 100. We have 2 solutions: 1/ we defined the aLengthMenu with 10, 20, 50, 100, All 2/ the iDisplayLength has to be equal to 25 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9466 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14799|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 14856 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14856&action=edit Bug 9466 [Revised] Use DataTables on saved reports page Replace the tablesorter plugin with the DataTables plugin on the saved reports page. To test, open the saved reports page (Reports > Use saved). Confirm that table sorting works correctly. Revision makes default result count (20) match options for number of pagination entries (10,20,50,100,all). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9466 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9466 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14856|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 14878 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14878&action=edit Bug 9466 [Revised] Use DataTables on saved reports page Replace the tablesorter plugin with the DataTables plugin on the saved reports page. To test, open the saved reports page (Reports > Use saved). Confirm that table sorting works correctly. Revision makes default result count (20) match options for number of pagination entries (10,20,50,100,all). Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9466 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- *** Bug 9568 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9466 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9466 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9466 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14878|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 15705 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15705&action=edit Bug 9466 [Revised] Use DataTables on saved reports page Replace the tablesorter plugin with the DataTables plugin on the saved reports page. To test, open the saved reports page (Reports > Use saved). Confirm that table sorting works correctly. Revision makes default result count (20) match options for number of pagination entries (10,20,50,100,all). Further revision corrects template path to datatables assets. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9466 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15705|0 |1 is obsolete| | --- Comment #7 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 15833 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15833&action=edit [SIGNED-OFF] Bug 9466 [Revised] Use DataTables on saved reports page Replace the tablesorter plugin with the DataTables plugin on the saved reports page. To test, open the saved reports page (Reports > Use saved). Confirm that table sorting works correctly. Revision makes default result count (20) match options for number of pagination entries (10,20,50,100,all). Further revision corrects template path to datatables assets. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9466 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9466 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: On the reports/guided_reports.pl page, I got a js error: ReferenceError: dt_add_type_uk_date is not defined (js/datatables.js is only loaded if saved1 is defined). Marked as Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9466 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9466 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15833|0 |1 is obsolete| | --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 16135 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16135&action=edit Bug 9466 [Revised] Use DataTables on saved reports page Replace the tablesorter plugin with the DataTables plugin on the saved reports page. To test, open the saved reports page (Reports > Use saved). Confirm that table sorting works correctly. Revision makes default result count (20) match options for number of pagination entries (10,20,50,100,all). Further revision corrects template path to datatables assets. Further revision fixes JavaScript error as reported by QA Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9466 --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Please update the status if you think it's incorrect to keep this "signed off." -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9466 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: This patch replaces tablesorter with DataTables on the saved reports page. No js error with the last patch. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9466 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16135|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 16158 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16158&action=edit Bug 9466 [Revised] Use DataTables on saved reports page Replace the tablesorter plugin with the DataTables plugin on the saved reports page. To test, open the saved reports page (Reports > Use saved). Confirm that table sorting works correctly. Revision makes default result count (20) match options for number of pagination entries (10,20,50,100,all). Further revision corrects template path to datatables assets. Further revision fixes JavaScript error as reported by QA Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9466 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #13 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org