[Bug 26330] New: Subfields constraints editor should hide all new others subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26330 Bug ID: 26330 Summary: Subfields constraints editor should hide all new others subfields Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: pablo.bianchi@gmail.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Created attachment 109386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109386&action=edit Screenshot of the issue To describe items with more detail a librarian needed more subfields on 952 tag, so after using the few available ASCII letters and numbers started using Greek letters, alpha (α), beta (β), gamma (γ)... Then while editing any subfield, currently selected is shown and then all the other new ones (full-page screenshot attached). The problem seems related to the fact that under subfieldtabs id all divs but the selected should have style="display: none;". This is working only with all the ones matching [0-9a-z]. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26330 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Subfields constraints |jQueryUI tabs don't work |editor should hide all new |with non-Latin-1 characters |others subfields | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26330 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26330 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 109422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109422&action=edit Bug 26330: Change encoding of text used as tab triggers in MARC subfield constraints This patch changes the encoding of the data being used to define jQueryUI tabs on the MARC subfield constraints page. A jQueryUI bug prevents non-Latin-1 characters from being used when defining tab controls. Using Template:Toolkit's "uri" filter converts the data to usable characters. To test, apply the patch and go to Administration -> MARC frameworks -> MARC structure -> tag 952 -> Edit subfields. - Under the "New" tab, add a subfield code which is outside the basic Latin character set, e.g. £, §, æ. - Save changes. - Edit any subfield code to load the subfield constraints page again. - Test that the subfield code tabs work correctly: Clicking each tab should load only the corresponding panel. - Test a variety of tabs including the one you created with the non-Latin character. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26330 --- Comment #2 from Pablo AB <pablo.bianchi@gmail.com> --- Wow that was fast! :) One thing to note is that not any character outside the basic Latin character should be accepted, as mentioned in Bug 9874 about ampersand. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26330 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26330 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Pablo AB from comment #2)
One thing to note is that not any character outside the basic Latin character should be accepted, as mentioned in Bug 9874 about ampersand.
If you have more information about how the form should be validated you could file another bug. If my patch is working for you please sign off! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26330 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26330 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26330 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109422|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 109684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109684&action=edit Bug 26330: Change encoding of text used as tab triggers in MARC subfield constraints This patch changes the encoding of the data being used to define jQueryUI tabs on the MARC subfield constraints page. A jQueryUI bug prevents non-Latin-1 characters from being used when defining tab controls. Using Template:Toolkit's "uri" filter converts the data to usable characters. To test, apply the patch and go to Administration -> MARC frameworks -> MARC structure -> tag 952 -> Edit subfields. - Under the "New" tab, add a subfield code which is outside the basic Latin character set, e.g. £, §, æ. - Save changes. - Edit any subfield code to load the subfield constraints page again. - Test that the subfield code tabs work correctly: Clicking each tab should load only the corresponding panel. - Test a variety of tabs including the one you created with the non-Latin character. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26330 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109684|0 |1 is obsolete| | --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 109935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109935&action=edit Bug 26330: Change encoding of text used as tab triggers in MARC subfield constraints This patch changes the encoding of the data being used to define jQueryUI tabs on the MARC subfield constraints page. A jQueryUI bug prevents non-Latin-1 characters from being used when defining tab controls. Using Template:Toolkit's "uri" filter converts the data to usable characters. To test, apply the patch and go to Administration -> MARC frameworks -> MARC structure -> tag 952 -> Edit subfields. - Under the "New" tab, add a subfield code which is outside the basic Latin character set, e.g. £, §, æ. - Save changes. - Edit any subfield code to load the subfield constraints page again. - Test that the subfield code tabs work correctly: Clicking each tab should load only the corresponding panel. - Test a variety of tabs including the one you created with the non-Latin character. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26330 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26330 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26330 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26330 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- enhancement will not be backported to 20.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26330 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26330 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com Version(s)|20.11.00 |20.11.00,20.05.08 released in| | Status|Pushed to master |Pushed to stable --- Comment #8 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- I went ahead and backported this to 20.05.x for 20.05.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26330 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26330 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED CC| |victor@tuxayo.net --- Comment #9 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org