[Bug 27137] New: Move item doesn't show the title of the target record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27137 Bug ID: 27137 Summary: Move item doesn't show the title of the target record Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: aleisha@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Bug 11529 added this change to cataloguing/moveitem.pl my $biblio = Koha::Biblios->find( $biblionumber ); -$template->param(bibliotitle => $biblio->title); +$template->param(biblio => $biblio); But the template was not updated so it still tries to access the bibliotitle variable <div class="dialog message">The item has successfully been attached to [% INCLUDE 'biblio-default-view.inc' %]<i>[% bibliotitle | html %]</i></a>. Which no longer exists. So when the item is successfully moved, no biblio title is shown. This bug exists in 19.11 and 20.05 but not 20.11. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27137 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11529 Severity|enhancement |minor Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 [Bug 11529] Add subtitle, medium and part fields to biblio table -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27137 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27137 --- Comment #1 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 114128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114128&action=edit Bug 27137: Correctly show biblio title after successfully moving item In Bug 11529 we changed the variable that was passed to the template but missed updating the template. This patch ensures we correctly access the variable to show the title of the biblio. To test: 1) Create two biblios (Biblio A and Biblio B) 2) Add an item to Biblio A (Item A) 3) Go to Biblio B 4) In the cataloguing toolbar, click Edit, then Attach item 5) Enter the barcode for Item A and submit 6) Notice the item has successfully moved by Biblio B's title does not show 7) Apply patch 8) Go to Biblio A 9) In the cataloguing toolbar, click Edit, then Attach item 10) Enter the barcode for Item A and submit 11) Confirm Biblio A's title shows correctly Sponsored-by: Toi Ohomai Institute of Technology -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27137 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|koha-bugs@lists.koha-commun |aleisha@catalyst.net.nz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27137 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch fixes a small release notes| |bug to ensure that the | |title of the target | |bibliographic record shows | |as expected upon | |successfully attaching an | |item. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27137 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27137 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114128|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 114144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114144&action=edit Bug 27137: Correctly show biblio title after successfully moving item In Bug 11529 we changed the variable that was passed to the template but missed updating the template. This patch ensures we correctly access the variable to show the title of the biblio. To test: 1) Create two biblios (Biblio A and Biblio B) 2) Add an item to Biblio A (Item A) 3) Go to Biblio B 4) In the cataloguing toolbar, click Edit, then Attach item 5) Enter the barcode for Item A and submit 6) Notice the item has successfully moved by Biblio B's title does not show 7) Apply patch 8) Go to Biblio A 9) In the cataloguing toolbar, click Edit, then Attach item 10) Enter the barcode for Item A and submit 11) Confirm Biblio A's title shows correctly Sponsored-by: Toi Ohomai Institute of Technology Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27137 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27137 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114144|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 114148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114148&action=edit Bug 27137: Correctly show biblio title after successfully moving item In Bug 11529 we changed the variable that was passed to the template but missed updating the template. This patch ensures we correctly access the variable to show the title of the biblio. To test: 1) Create two biblios (Biblio A and Biblio B) 2) Add an item to Biblio A (Item A) 3) Go to Biblio B 4) In the cataloguing toolbar, click Edit, then Attach item 5) Enter the barcode for Item A and submit 6) Notice the item has successfully moved by Biblio B's title does not show 7) Apply patch 8) Go to Biblio A 9) In the cataloguing toolbar, click Edit, then Attach item 10) Enter the barcode for Item A and submit 11) Confirm Biblio A's title shows correctly Sponsored-by: Toi Ohomai Institute of Technology Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27137 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27137 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Passed QA |Pushed to stable --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Sending to 20.05 RM queue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27137 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com Version(s)| |20.05.08 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #5 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 20.05.x for 20.05.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27137 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable CC| |victor@tuxayo.net --- Comment #6 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Backported: Pushed to 19.11.x branch for 19.11.14 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27137 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.08 |20.05.08,19.11.14 released in| | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org