[Bug 42084] New: Incorrect interface shown in log viewer for system preference changes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42084 Bug ID: 42084 Summary: Incorrect interface shown in log viewer for system preference changes Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: hammat.wele@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com The log viewer displays the OPAC interface for system preference changes. Since system preferences cannot be modified from the OPAC, the interface displayed in the logs appears to be incorrect. To reproduce: 1- Change a system preference from the staff interface. 1- Go to Administration -> System preferences. 2- Search for a preference such as AcqCreateItem (any system preference will reproduce the issue). 3- Change the value of the preference. 4- Click Save all Acquisitions preferences (or save the preference). 2- Go to the log viewer: 1- Navigate to Tools -> Log viewer. 2- Fill the form as follows: Librarian: leave empty Modules: uncheck everything except System preferences Actions: keep All actions selected Object: leave empty Info: leave empty Interface: keep All interfaces Display from: choose yesterday Display to: leave empty 3- Click Submit. ==>The log entry shows the OPAC interface. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42084 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |hammat.wele@inlibro.com |ity.org | CC| |caroline.cyr-la-rose@inlibr | |o.com, | |philippe.blouin@inlibro.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42084 --- Comment #1 from Hammat wele <hammat.wele@inlibro.com> --- To reproduce: 1- Disables plack 1- sudo koha-plack --disable kohadev 2- sudo koha-plack --stop kohadev 3- sudo service apache2 restart 2- Change a system preference from the staff interface. 1- Go to Administration -> System preferences. 2- Search for a preference such as AcqCreateItem (any system preference will reproduce the issue). 3- Change the value of the preference. 4- Click Save all Acquisitions preferences (or save the preference). 3- Go to the log viewer: 1- Navigate to Tools -> Log viewer. 2- Fill the form as follows: Librarian: leave empty Modules: uncheck everything except System preferences Actions: keep All actions selected Object: leave empty Info: leave empty Interface: keep All interfaces Display from: choose yesterday Display to: leave empty 3- Click Submit. ==>The log entry shows the OPAC interface. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42084 --- Comment #2 from Hammat wele <hammat.wele@inlibro.com> --- The log viewer displays the OPAC interface for system preference changes. Since system preferences cannot be modified from the OPAC, the interface displayed in the logs appears to be incorrect. To reproduce: 1- Change a system preference from the staff interface. 1- Go to Administration -> System preferences. 2- Search for a preference such as AcqCreateItem (any system preference will reproduce the issue). 3- Change the value of the preference. 4- Click Save all Acquisitions preferences (or save the preference). 2- Go to the log viewer: 1- Navigate to Tools -> Log viewer. 2- Fill the form as follows: Librarian: leave empty Modules: uncheck everything except System preferences Actions: keep All actions selected Object: leave empty Info: leave empty Interface: keep All interfaces Display from: choose yesterday Display to: leave empty 3- Click Submit. ==>The log entry shows the OPAC interface. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42084 --- Comment #3 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 195343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195343&action=edit Bug 42084: Incorrect interface shown in log viewer for system preference changes The log viewer displays the OPAC interface for system preference changes. Since system preferences cannot be modified from the OPAC, the interface displayed in the logs appears to be incorrect. To reproduce: 1- Disables plack 1- sudo koha-plack --disable kohadev 2- sudo koha-plack --stop kohadev 3- sudo service apache2 restart 2- Change a system preference from the staff interface. 1- Go to Administration -> System preferences. 2- Search for a preference such as AcqCreateItem (any system preference will reproduce the issue). 3- Change the value of the preference. 4- Click Save all Acquisitions preferences (or save the preference). 3- Go to the log viewer: 1- Navigate to Tools -> Log viewer. 2- Fill the form as follows: Librarian: leave empty Modules: uncheck everything except System preferences Actions: keep All actions selected Object: leave empty Info: leave empty Interface: keep All interfaces Display from: choose yesterday Display to: leave empty 3- Click Submit. ==>The log entry shows the OPAC interface. 4- Apply the patch 5- Repeat step 1,2,3 ==>The log entry shows the Staff interface. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42084 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42084 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42084 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195343|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42084 --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 195364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195364&action=edit Bug 42084: Incorrect interface shown in log viewer for system preference changes The log viewer displays the OPAC interface for system preference changes. Since system preferences cannot be modified from the OPAC, the interface displayed in the logs appears to be incorrect. To reproduce: 1- Disables plack 1- sudo koha-plack --disable kohadev 2- sudo koha-plack --stop kohadev 3- sudo service apache2 restart 2- Change a system preference from the staff interface. 1- Go to Administration -> System preferences. 2- Search for a preference such as AcqCreateItem (any system preference will reproduce the issue). 3- Change the value of the preference. 4- Click Save all Acquisitions preferences (or save the preference). 3- Go to the log viewer: 1- Navigate to Tools -> Log viewer. 2- Fill the form as follows: Librarian: leave empty Modules: uncheck everything except System preferences Actions: keep All actions selected Object: leave empty Info: leave empty Interface: keep All interfaces Display from: choose yesterday Display to: leave empty 3- Click Submit. ==>The log entry shows the OPAC interface. 4- Apply the patch 5- Repeat step 1,2,3 ==>The log entry shows the Staff interface. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42084 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |david@davidnind.com Text to go in the| |This fixes the logging of release notes| |system preference changes | |so that the log viewer | |shows the change as made by | |the staff interface. | | | |displays the OPAC interface | |for system preference | |changes. Since system | |preferences cannot be | |modified from the OPAC, the | |interface displayed in the | |logs appears to be | |incorrect. Severity|enhancement |normal --- Comment #5 from David Nind <david@davidnind.com> --- After signing off, I now don't think this fixes the issue. Before the patch: 1. If Plack is running, system preference changes show the staff interface as the interface. 2. If Plack is not running, as per the test plan, the OPAC is shown as the interface. After the patch, if Plack is not running (as per the test plan) system preference changes now correctly show as the staff interface. However, with the patch applied, and shutting KTD down and starting it up again, the initial system preference changes still show as the OPAC interface. To reproduce in KTD: 1. Start up KTD. 2. Go to the log viewer (Tools > Additional tools > Log viewer) and click submit. 3. Note that for all the system preference changes from the initial starting up of KTD, that OPAC is shown as the interface. 4. Apply the patch and shut down KTD 5. Start up KTD again. 6. Repeat step 2. 7. OPAC is still shown as the interface. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42084 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This fixes the logging of | release notes|system preference changes | |so that the log viewer | |shows the change as made by | |the staff interface. | | | |displays the OPAC interface | |for system preference | |changes. Since system | |preferences cannot be | |modified from the OPAC, the | |interface displayed in the | |logs appears to be | |incorrect. | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42084 --- Comment #6 from Hammat wele <hammat.wele@inlibro.com> --- (In reply to David Nind from comment #5)
After signing off, I now don't think this fixes the issue.
Before the patch: 1. If Plack is running, system preference changes show the staff interface as the interface. 2. If Plack is not running, as per the test plan, the OPAC is shown as the interface.
After the patch, if Plack is not running (as per the test plan) system preference changes now correctly show as the staff interface.
However, with the patch applied, and shutting KTD down and starting it up again, the initial system preference changes still show as the OPAC interface.
To reproduce in KTD: 1. Start up KTD. 2. Go to the log viewer (Tools > Additional tools > Log viewer) and click submit. 3. Note that for all the system preference changes from the initial starting up of KTD, that OPAC is shown as the interface. 4. Apply the patch and shut down KTD 5. Start up KTD again. 6. Repeat step 2. 7. OPAC is still shown as the interface.
Hi, I believe the test plan describes a different issue The original bug concerns changes made via the Staff interface. The patch correctly fixes that: such changes are now logged as coming from the Staff interface even when Plack is disabled. The OPAC entries seen at KTD startup are for preferences created automatically by KTD and are not related to this bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42084 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #7 from David Nind <david@davidnind.com> --- (In reply to Hammat wele from comment #6)
(In reply to David Nind from comment #5)
After signing off, I now don't think this fixes the issue.
Before the patch: 1. If Plack is running, system preference changes show the staff interface as the interface. 2. If Plack is not running, as per the test plan, the OPAC is shown as the interface.
After the patch, if Plack is not running (as per the test plan) system preference changes now correctly show as the staff interface.
However, with the patch applied, and shutting KTD down and starting it up again, the initial system preference changes still show as the OPAC interface.
To reproduce in KTD: 1. Start up KTD. 2. Go to the log viewer (Tools > Additional tools > Log viewer) and click submit. 3. Note that for all the system preference changes from the initial starting up of KTD, that OPAC is shown as the interface. 4. Apply the patch and shut down KTD 5. Start up KTD again. 6. Repeat step 2. 7. OPAC is still shown as the interface.
Hi,
I believe the test plan describes a different issue The original bug concerns changes made via the Staff interface. The patch correctly fixes that: such changes are now logged as coming from the Staff interface even when Plack is disabled. The OPAC entries seen at KTD startup are for preferences created automatically by KTD and are not related to this bug.
Changing back to signed off! 8-) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42084 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42084 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42084 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195364|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42084 --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 199412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199412&action=edit Bug 42084: Incorrect interface shown in log viewer for system preference changes The log viewer displays the OPAC interface for system preference changes. Since system preferences cannot be modified from the OPAC, the interface displayed in the logs appears to be incorrect. To reproduce: 1- Disables plack 1- sudo koha-plack --disable kohadev 2- sudo koha-plack --stop kohadev 3- sudo service apache2 restart 2- Change a system preference from the staff interface. 1- Go to Administration -> System preferences. 2- Search for a preference such as AcqCreateItem (any system preference will reproduce the issue). 3- Change the value of the preference. 4- Click Save all Acquisitions preferences (or save the preference). 3- Go to the log viewer: 1- Navigate to Tools -> Log viewer. 2- Fill the form as follows: Librarian: leave empty Modules: uncheck everything except System preferences Actions: keep All actions selected Object: leave empty Info: leave empty Interface: keep All interfaces Display from: choose yesterday Display to: leave empty 3- Click Submit. ==>The log entry shows the OPAC interface. 4- Apply the patch 5- Repeat step 1,2,3 ==>The log entry shows the Staff interface. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42084 --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 199413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199413&action=edit Bug 42084: (QA follow-up) Simplify Since this is an intranet svc script (called in intranet js), there is no need to check the session. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42084 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42084 --- Comment #10 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42084 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.11.00 |26.11.00,26.05.01 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42084 --- Comment #11 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to 26.05.x for the upcoming 26.05.01 release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42084 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.11.00,26.05.01 |26.11.00,26.05.01,25.11.05 released in| | Status|Pushed to stable |Pushed to oldstable CC| |baptiste.wojtkowski@biblibr | |e.com --- Comment #12 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Pushed into 25.11.x for 25.11.05 nice work everyone -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42084 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.11.00,26.05.01,25.11.05 |26.11.00,26.05.01,25.11.06 released in| | --- Comment #13 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- EDIT: pushed to 25.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42084 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to oldstable |Needs documenting --- Comment #14 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 25.05.x unless requested -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42084 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the interface release notes| |shown in the log viewer | |when changes to system | |preferences are made. The | |log viewer now correctly | |shows the change to system | |preferences was made from | |the staff interface. | |Previously, the OPAC | |interface was for system | |preference changes-this was | |not correct, as system | |preferences cannot be | |modified from the OPAC. Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #15 from David Nind <david@davidnind.com> --- Bug fix, no changes required to the manual. The log viewer section in the manual does not go into this level of detail, and the example screenshot does not show any system preference changes: https://koha-community.org/manual/latest/en/html/tools.html#log-viewer -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org