[Bug 42445] New: Remove event attributes from list creation template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42445 Bug ID: 42445 Summary: Remove event attributes from list creation template Initiative type: --- Sponsorship Sponsored status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Blocks: 38407 The list creation template has a couple of "onChange" event attributes which should be moved to the JS block in the footer. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38407 [Bug 38407] Eliminate event handler attributes in the staff interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42445 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Comma delimited| |Athens County Public list of Sponsors| |Libraries Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42445 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 198019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198019&action=edit Bug 42445: Remove event attributes from list creation template This patch removes a couple of "onChange" event attributes from the lists template in favor of defining the event handler in the footer JS. To test, apply the patch and go to Lists -> New list. - Choose "Private" from the public dropdown. - In the "Allow changes to contents from" dropdown select "Permitted staff only" - A note should appear about the setting having no effect. - You should see a similar note displayed when you select "Staff only" or "Anyone seeing this list" Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42445 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42445 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198019|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42445 --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 198205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198205&action=edit Bug 42445: Remove event attributes from list creation template This patch removes a couple of "onChange" event attributes from the lists template in favor of defining the event handler in the footer JS. To test, apply the patch and go to Lists -> New list. - Choose "Private" from the public dropdown. - In the "Allow changes to contents from" dropdown select "Permitted staff only" - A note should appear about the setting having no effect. - You should see a similar note displayed when you select "Staff only" or "Anyone seeing this list" Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42445 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. Things continue to work the same before and after the patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42445 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42445 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198205|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42445 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 198603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198603&action=edit Bug 42445: Remove event attributes from list creation template This patch removes a couple of "onChange" event attributes from the lists template in favor of defining the event handler in the footer JS. To test, apply the patch and go to Lists -> New list. - Choose "Private" from the public dropdown. - In the "Allow changes to contents from" dropdown select "Permitted staff only" - A note should appear about the setting having no effect. - You should see a similar note displayed when you select "Staff only" or "Anyone seeing this list" Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42445 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- Fixed conflict with bug BZ42445. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42445 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198603|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42445 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 198604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198604&action=edit Bug 42445: Remove event attributes from list creation template This patch removes a couple of "onChange" event attributes from the lists template in favor of defining the event handler in the footer JS. To test, apply the patch and go to Lists -> New list. - Choose "Private" from the public dropdown. - In the "Allow changes to contents from" dropdown select "Permitted staff only" - A note should appear about the setting having no effect. - You should see a similar note displayed when you select "Staff only" or "Anyone seeing this list" Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Amended-by: Jonathan Druart Tidy Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42445 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42445 --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42445 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00 |26.05.00,25.11.05 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42445 --- Comment #8 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42445 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to stable |Needs documenting --- Comment #9 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 25.05.x unless requested -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42445 --- Comment #10 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- (In reply to Wainui Witika-Park from comment #9)
Not backporting to 25.05.x unless requested
This was because patch didn't apply cleanly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42445 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #11 from David Nind <david@davidnind.com> --- No visible user interface change, no changes required to the manual. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org