[Bug 17389] New: Exporting framework always export the default framework
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17389 Bug ID: 17389 Summary: Exporting framework always export the default framework Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: System Administration Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17389 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- From: commit 705097f938ba9334c21b3e6f006bd7c9ba38763c Bug 16035: MARC default bibliographic framework Export fix -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17389 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16035 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16035 [Bug 16035] MARC framework Export misbehaving -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17389 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17389 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55975&action=edit Bug 17389: (bug 16035 follow-up) Fix export non-default frameworks Trivial patch, no need to explain anything :) Test plan: Export default framework Export other frameworks => The frameworkcode column should contain the framework code -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17389 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55977&action=edit Bug 17389: Clear logs Logs are full of: Use of uninitialized value in substitution (s///) at C4/ImportExportFramework.pm line 282. Use of uninitialized value in concatenation (.) or string at C4/ImportExportFramework.pm line 283. Some field are NULL in DB, we need to init the value to an empty string to avoid these warnings. Note: This fix is not related to the original bug -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17389 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55975|0 |1 is obsolete| | --- Comment #4 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 55983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55983&action=edit [SIGNED-OFF]Bug 17389: (bug 16035 follow-up) Fix export non-default frameworks Trivial patch, no need to explain anything :) Test plan: Export default framework Export other frameworks => The frameworkcode column should contain the framework code Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17389 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55977|0 |1 is obsolete| | --- Comment #5 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 55984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55984&action=edit [SIGNED-OFF]Bug 17389: Clear logs Logs are full of: Use of uninitialized value in substitution (s///) at C4/ImportExportFramework.pm line 282. Use of uninitialized value in concatenation (.) or string at C4/ImportExportFramework.pm line 283. Some field are NULL in DB, we need to init the value to an empty string to avoid these warnings. Note: This fix is not related to the original bug Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Warnings avoided -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17389 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |hector.hecaxmmx@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17389 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17389 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55983|0 |1 is obsolete| | Attachment #55984|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 56153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56153&action=edit [PASSED QA] Bug 17389: (bug 16035 follow-up) Fix export non-default frameworks Trivial patch, no need to explain anything :) Test plan: Export default framework Export other frameworks => The frameworkcode column should contain the framework code Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17389 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 56154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56154&action=edit [PASSED QA] Bug 17389: Clear logs Logs are full of: Use of uninitialized value in substitution (s///) at C4/ImportExportFramework.pm line 282. Use of uninitialized value in concatenation (.) or string at C4/ImportExportFramework.pm line 283. Some field are NULL in DB, we need to init the value to an empty string to avoid these warnings. Note: This fix is not related to the original bug Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Warnings avoided Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17389 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan@bywatersolutions.co | |m --- Comment #8 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the November 16.11 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17389 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |frederic@tamil.fr --- Comment #9 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.05. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17389 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #10 from Julian Maurice <julian.maurice@biblibre.com> --- Pushed to 3.22.x, will be in 3.22.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17389 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hagud@orex.es --- Comment #11 from M. Tompsett <mtompset@hotmail.com> --- *** Bug 17410 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org