[Bug 7018] New: need all acq permissions to search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7018 Bug #: 7018 Summary: need all acq permissions to search Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: critical Priority: P5 Component: Acquisitions AssignedTo: henridamien@koha-fr.org ReportedBy: nengard@gmail.com QAContact: koha-bugs@lists.koha-community.org You can't do the order search on acquisitions if you have the following permissions: group_manage Manage orders & basketgroups order_manage Manage orders & basket order_receive Manage orders & basket I think you should be able to search acquisitions if you're allowed to order things or manage vendors. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7018 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Version|master |rel_3_6 --- Comment #1 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-26 14:42:31 UTC --- Bug still valid in 3.6. It happen on order histearch.pl. I agree with Nicole suggested behaviour -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7018 --- Comment #2 from Kyle M Hall <kyle.m.hall@gmail.com> 2012-02-08 15:48:34 UTC --- Created attachment 7506 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7506 Bug 7018 - need all acq permissions to search Single line fix. Changes permissions required for histsearch.pl from requiring * for acquisitions to only requiring budget_add_del, budget_manage, and budget_modify -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7018 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |kyle.m.hall@gmail.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7018 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Nicole C. Engard <nengard@gmail.com> 2012-02-14 19:41:23 UTC --- Kyle, If my patron has: group_manage Manage orders & basketgroups order_manage Manage orders & basket order_receive Manage orders & basket The permissions needed to place an order I still can't do an order search. I'm not sure what you're saying about the budget stuff, but it's the order search that needs fixing. Nicole -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7018 --- Comment #4 from Kyle M Hall <kyle.m.hall@gmail.com> 2012-02-15 12:51:12 UTC --- Created attachment 7653 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7653 Bug 7018 - need all acq permissions to search Single line fix. Changes permissions required for histsearch.pl from requiring * for acquisitions to only requiring group_manage, order_manage, and order_receive -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7018 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7506|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7018 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7018 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7653|0 |1 is obsolete| | --- Comment #5 from Nicole C. Engard <nengard@gmail.com> 2012-02-16 02:24:51 UTC --- Created attachment 7671 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7671 [SIGNED-OFF] Bug 7018 - need all acq permissions to search Single line fix. Changes permissions required for histsearch.pl from requiring * for acquisitions to only requiring group_manage, order_manage, and order_receive Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7018 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7018 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |koha.sekjal@gmail.com --- Comment #6 from Ian Walls <koha.sekjal@gmail.com> 2012-02-16 17:39:03 UTC --- Changes permission call only to allow for partial acq permissions to access this page. Marking Passed QA. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7018 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7018 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #7 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This fix was included in the 3.6.x branch prior to 3.6.4. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7018 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED CC| |fridolyn.somers@biblibre.co | |m Resolution|FIXED |--- --- Comment #8 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- I reopen this bug because it does not behave like wanted. Using : flagsrequired => { acquisition => 'group_manage', acquisition => 'order_manage', acquisition => 'order_receive' }, flagsrequired is a hash so setting 3 times the same key results in a hash with only : { acquisition => 'order_receive' } So instead of requiring group_manage, order_manage and order_receive permissions, acq search page only needs order_receive. Tested with only group_manage or only order_manage, permission is denied. Using several permissions on same module will need development in C4::Auth. It should allow a boolean combination of permissions I think. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7018 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.6 |master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7018 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7671|0 |1 is obsolete| | Status|REOPENED |Needs Signoff Assignee|henridamien@koha-fr.org |fridolyn.somers@biblibre.co | |m --- Comment #9 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 15721 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15721&action=edit [reopened] Proposed patch I propose to use any acqui permission to allow order search. See commit message. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7018 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7018 MJ Ray (software.coop) <mjr@software.coop> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15721|0 |1 is obsolete| | --- Comment #10 from MJ Ray (software.coop) <mjr@software.coop> --- Created attachment 15781 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15781&action=edit Bug 7018 : need all acq permissions to search All acquisition module permissions are needed to allow order search (acqui/histsearch.pl). With this patch any acquisition permission allows to order search. Many other pages of this module have this behavior. Test plan : - Set for a user only one permission in acquisition module (not order_receive) => they also need catalogue permission to be able to log in - Login with this user and try to perform an order search => you get access to page - Set for a user no permission in acquisition module - Login with this user and try to perform an order search => you do not get access to page Signed-off-by: MJ Ray <mjr@phonecoop.coop> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7018 MJ Ray (software.coop) <mjr@software.coop> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mjr@software.coop -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7018 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de QA Contact|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Looking at this now. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7018 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7018 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15781|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 16481 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16481&action=edit [PASSED QA] Bug 7018 : need all acq permissions to search All acquisition module permissions are needed to allow order search (acqui/histsearch.pl). With this patch any acquisition permission allows to order search. Many other pages of this module have this behavior. Test plan : - Set for a user only one permission in acquisition module (not order_receive) => they also need catalogue permission to be able to log in - Login with this user and try to perform an order search => you get access to page - Set for a user no permission in acquisition module - Login with this user and try to perform an order search => you do not get access to page Signed-off-by: MJ Ray <mjr@phonecoop.coop> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as expected and passes tests. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7018 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #13 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7018 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #14 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x and 3.8.x will be in 3.10.5 and 3.8.12 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org