http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9504 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard@myacpl.org |fridolyn.somers@biblibre.co | |m --- Comment #1 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 14921 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14921&action=edit Proposed patch See commit message -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9504 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14921|0 |1 is obsolete| | --- Comment #2 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 15019 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15019&action=edit Bug 9504: URL escape in OPAC more searches OPACSearchForTitleIn is a syspref used to add links as "more searches" in OPAC record detail page. The links can contain vars depending on record values like title, ISBN, ... Thoses values must be URL-escaped because they can contain special characters that will brake URL and/or HTML. This patch add a method C4::Output::parametrized_url() that replaces vars in URL usign escape and UTF-8 encoding. Test plan : - Define in OPACSearchForTitleIn a link with all possible vars : TITLE, AUTHOR, ISBN, ISSN, CONTROLNUMBER, BIBLIONUMBER - Edit a record to add special characters in title : ", &, ? ... - Go to OPAC detail pages of this record => Check that URL is well encoded => Click on link to check the term is well encoded (diacritical characters, ...) Signed-off-by: Liz Rea <liz@catalyst.net.nz> Nice test plan, thanks! Verified bug and fix - both look good. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9504 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15019|0 |1 is obsolete| | --- Comment #3 from Mason James <mtj@kohaaloha.com> --- Created attachment 16446 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16446&action=edit Bug 9504: URL escape in OPAC more searches OPACSearchForTitleIn is a syspref used to add links as "more searches" in OPAC record detail page. The links can contain vars depending on record values like title, ISBN, ... Thoses values must be URL-escaped because they can contain special characters that will brake URL and/or HTML. This patch add a method C4::Output::parametrized_url() that replaces vars in URL usign escape and UTF-8 encoding. Test plan : - Define in OPACSearchForTitleIn a link with all possible vars : TITLE, AUTHOR, ISBN, ISSN, CONTROLNUMBER, BIBLIONUMBER - Edit a record to add special characters in title : ", &, ? ... - Go to OPAC detail pages of this record => Check that URL is well encoded => Click on link to check the term is well encoded (diacritical characters, ...) Signed-off-by: Liz Rea <liz@catalyst.net.nz> Nice test plan, thanks! Verified bug and fix - both look good. Signed-off-by: Mason James <mtj@kohaaloha.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9504 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.