http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13129 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13129 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |fridolyn.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13129 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32583|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 32703 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32703&action=edit Bug 13129 - HTML and JS escapes missing in unimarc_field_4XX.tt This patch adds JS and HTML espaces are it is missing. Replaces calls to url filter by uri filter, url filter does not espace enought caracters : http://template-toolkit.org/docs/manual/Filters.html#section_url. Also corrects the fact the code : resul.size => resul.item('size'). Old code returns the size of the loop instead of the value of "size" field. Test plan : - Use the plugin unimarc_field_4XX - Perform a search with a ? or & => Search works - Perform a search that returns a record with a double quote in title - Choose this record => Plugin works - Check the results displays well the value of biblioitems.size Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13129 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32703|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 32728 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32728&action=edit [PASSED QA] Bug 13129 - HTML and JS escapes missing in unimarc_field_4XX.tt This patch adds JS and HTML espaces are it is missing. Replaces calls to url filter by uri filter, url filter does not espace enough characters: http://template-toolkit.org/docs/manual/Filters.html#section_url. Also corrects the fact the code: resul.size => resul.item('size'). Old code returns the size of the loop instead of the value of "size" field. Test plan : - Use the plugin unimarc_field_4XX - Perform a search with a ? or & => Search works - Perform a search that returns a record with a double quote in title - Choose this record => Plugin works - Check the results displays well the value of biblioitems.size Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes tests and QA script, I fixed some tabs. Tested in a UNIMARC installation. -- You are receiving this mail because: You are watching all bug changes.