https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34630 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 154888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154888&action=edit Bug 34630: Update MARC21 cataloging plugin templates with consistent body class This patch updates cataloging plugin templates to remove the inline style "padding:1em" from the body tag. This style conflicts with fixed Bootstrap footers. A "value_builder" class is added to the body tag instead, the style added to staff-global.scss. There shouldn't be any visible change to the appearance of the pages. To test, apply the patch and rebuild the staff interface CSS and clear your browser cache if necessary. - Go to Cataloging -> New record. - In a default MARC21 installation you can test various plugin popups to confirm that they display correctly: - 000 - 006 - 007 - 008 To visually confirm each affected template, the plugins can be loaded in their own tab for testing the appearance of the page. I have a list of direct links here: https://gitlab.com/-/snippets/2555254 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34630 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154888|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 154974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154974&action=edit Bug 34630: Update MARC21 cataloging plugin templates with consistent body class This patch updates cataloging plugin templates to remove the inline style "padding:1em" from the body tag. This style conflicts with fixed Bootstrap footers. A "value_builder" class is added to the body tag instead, the style added to staff-global.scss. There shouldn't be any visible change to the appearance of the pages. To test, apply the patch and rebuild the staff interface CSS and clear your browser cache if necessary. - Go to Cataloging -> New record. - In a default MARC21 installation you can test various plugin popups to confirm that they display correctly: - 000 - 006 - 007 - 008 To visually confirm each affected template, the plugins can be loaded in their own tab for testing the appearance of the page. I have a list of direct links here: https://gitlab.com/-/snippets/2555254 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34630 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34630 Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155139|0 |1 is obsolete| | --- Comment #4 from Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com> --- Created attachment 155565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155565&action=edit Bug 34630: Update MARC21 cataloging plugin templates with consistent body class This patch updates cataloging plugin templates to remove the inline style "padding:1em" from the body tag. This style conflicts with fixed Bootstrap footers. A "value_builder" class is added to the body tag instead, the style added to staff-global.scss. There shouldn't be any visible change to the appearance of the pages. To test, apply the patch and rebuild the staff interface CSS and clear your browser cache if necessary. - Go to Cataloging -> New record. - In a default MARC21 installation you can test various plugin popups to confirm that they display correctly: - 000 - 006 - 007 - 008 To visually confirm each affected template, the plugins can be loaded in their own tab for testing the appearance of the page. I have a list of direct links here: https://gitlab.com/-/snippets/2555254 Signed-off-by: Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34630 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34630 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34630 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34630 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #8 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Not sure this is much different from bug 34566, manual-wise. Feel free to reopen with more details if needed. -- You are receiving this mail because: You are watching all bug changes.