https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34661 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34661 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 155006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155006&action=edit Bug 34661: FOR TESTING ONLY, a database update to configure MARC plugins This patch is for testing purposes only: An update to change the default framework's plugin settings for various fields in order to make all the updated UNIMARC plugin available. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34661 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34661 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 155588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155588&action=edit Bug 34661: FOR TESTING ONLY, a database update to configure MARC plugins This patch is for testing purposes only: An update to change the default framework's plugin settings for various fields in order to make all the updated UNIMARC plugin available. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34661 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155587|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 155725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155725&action=edit Bug 34661: Update UNIMARC cataloging plugins with consistent footers This patch updates UNIMARC cataloging plugin templates so that they have consistent fixed footers in the plugin popup window. Plugins for the following UNIMARC fields have been updated: 000 (Leader) 123$f 128$a 181$b 100$a 123$g 128$b 182$2 105$a 123$i 128$c 182$a 106$a 123$j 130$a 182$c 110$a 124$a 135$a 183$2 115$a 124$b 140$a 183$a 115$b 124$c 141$a 210$c 116$a 124$d 146$a 225$a 117$a 124$e 146$c 225$a 120$a 124$f 146$d 283$2 121$a 124$g 146$e 283$a 121$b 125$a 146$f 325$h 122$a 125$b 146$h 325$j 123$a 126$a 146$i 123$d 126$b 181$2 123$e 127$a 181$a Most of these will be pre-configured in a test system with default UNIMARC data. In KTD you can use the 'reset_all_unimarc' command. Go to Cataloging -> New record and test the plugin link for each of the fields listed above. - In each case, confirm that the correct popup window is shown when you click the plugin link. - Confirm that clicking the "Cancel" button closes the window without copying any data to the field in the MARC editor. * Note that if the plugin is also triggered by cursor focus in the input field, some data may be automatically filled anyway. - Confirm that filing in data and clicking "Submit" will copy the correct information into the field. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34661 --- Comment #8 from David Nind <david@davidnind.com> --- Testing notes using KTD: 1. I've found the 'reset_all_unimarc' command doesn't work very well for me - resets everything but no search results, even after a reindex. I tend to update the KOHA_MARC_FLAVOUR=unimarc in .env file and then start up KTD. 2. I have signed off, feel free to change status if some of the things noted in 5 + 6 need addressing for this bug. A really nice improvement! 3. Tested using Firefox, I think Google Chrome or Chromium renders things slightly differently, so some of the issues noted with window sizing may be related to that. 4. Used this list to quickly check after all were individually tested - https://gitlab.com/-/snippets/2555254 5. Some issues, but not related to this bug as this was the case before the patch is applied - happy to create bugs for these if needed: 106$a - OK - Window sizing, need to scroll to the right 110$a - OK - Window sizing, need to scroll to the right 117$a - OK - Window sizing, need to scroll down 146$a - OK - By default it is set up as an authorized value list, changed to plugin; labelled as "Framework plugin for UNIMARC 146$a" and is formatted differently - field label above input field; when clicking on the tag editor it jumps to the top of the page - popup window still populates the field but need to scroll back down again 146$b - OK - Missed off list in testing plan, labelled as "Framework plugin for UNIMARC 146$b" and is formatted differently - field label above input field 146$c - OK - Same as 146$b - labelled as "Framework plugin for UNIMARC 146$c" and is formatted differently - field label above input field 146$d - OK - Same as 146$b - labelled as "Framework plugin for UNIMARC 146$d" and is formatted differently - field label above input field 146$e - OK - Same as 146$b - labelled as "Framework plugin for UNIMARC 146$e" and is formatted differently - field label above input field 146$f - OK - Same as 146$b - labelled as "Framework plugin for UNIMARC 146$f" and is formatted differently - field label above input field 146$h - OK - Same as 146$b - labelled as "Framework plugin for UNIMARC 146$h" and is formatted differently - field label above input field; when clicking on the tag editor it jumps to the top of the page - popup window still populates the field but need to scroll back down again 146$i - OK - Same as 146$b - labelled as "Framework plugin for UNIMARC 146$i" and is formatted differently - field label above input field; when clicking on the tag editor it jumps to the top of the page - popup window still populates the field but need to scroll back down again 6. Some issues, don't do this before the patch is applied - happy to create bugs for these if required: 325$h - OK - Jumps to 325$a after value selected 325$j - OK - Jumps to 325$a after value selected 7. Notes about specific value builders: 181$c - OK - By default it is set up as an authorized value list, needed to remove authorized value list and add plugin; note that changing 181$c also changes 181$2 (depending on the value selected) 182$2 - OK - Needed to add the plugin in the framework 182$a - OK - Needed to remove the authorized value list from the framework 182$c - OK - Needed to remove the authorized value list from the framework; note that this may change 182$2 depending on the value selected 183$a - OK - Note that this may change 182$2 depending on the value selected 210c_bis - OK - This is an autocomplete field, based on the values available - start typing the name of a publisher, for example: pub 225$a - OK - Not able to test fully as requires some work to set up (see description in koha/cataloguing/value_builder/unimarc_field_225a.pl) 225$a-bis - OK - This is an autocomplete field, start typing - for example: fic 8. Not covered in test plan but look OK to me: unimarc_field_010.pl - no popup window unimarc_field_009_ppn.pl - authorities related?, no pop up window unimarc_field_124.pl - OK unimarc_field_125.pl - OK unimarc_field_126.pl - OK unimarc_field_127.pl - OK unimarc_field_700-4 - OK unimarc_leader_authorities.pl - OK 9. Not covered in test plan, search plugins so no footer with Save and Cancel buttons required in footer: unimarc_field_210$c - Search for authority type EDITORS unimarc_field_4XX - Search unimarc_field_686a - Search -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34661 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155725|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 156688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156688&action=edit Bug 34661: Update UNIMARC cataloging plugins with consistent footers This patch updates UNIMARC cataloging plugin templates so that they have consistent fixed footers in the plugin popup window. Plugins for the following UNIMARC fields have been updated: 000 (Leader) 123$f 128$a 181$b 100$a 123$g 128$b 182$2 105$a 123$i 128$c 182$a 106$a 123$j 130$a 182$c 110$a 124$a 135$a 183$2 115$a 124$b 140$a 183$a 115$b 124$c 141$a 210$c 116$a 124$d 146$a 225$a 117$a 124$e 146$c 225$a 120$a 124$f 146$d 283$2 121$a 124$g 146$e 283$a 121$b 125$a 146$f 325$h 122$a 125$b 146$h 325$j 123$a 126$a 146$i 123$d 126$b 181$2 123$e 127$a 181$a Most of these will be pre-configured in a test system with default UNIMARC data. In KTD you can use the 'reset_all_unimarc' command. Go to Cataloging -> New record and test the plugin link for each of the fields listed above. - In each case, confirm that the correct popup window is shown when you click the plugin link. - Confirm that clicking the "Cancel" button closes the window without copying any data to the field in the MARC editor. * Note that if the plugin is also triggered by cursor focus in the input field, some data may be automatically filled anyway. - Confirm that filing in data and clicking "Submit" will copy the correct information into the field. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34661 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156689|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34661 --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34661 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting -- You are receiving this mail because: You are watching all bug changes.