[Bug 7919] New: Display the Codes koha according to connexion libraries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Priority: P5 - low Change sponsored?: --- Bug ID: 7919 Assignee: gmcharlt@gmail.com Summary: Display the Codes koha according to connexion libraries QA Contact: koha.sekjal@gmail.com Severity: enhancement Classification: Unclassified OS: All Reporter: stephane.delaye@biblibre.com Hardware: All Status: NEW Version: rel_3_8 Component: Cataloging Product: Koha
From Koha administration:
Patron categories .. / cgi-bin / koha / admin / categorie.pl? & op = add_form CategoryCode = [^] and Authorized values / cgi-bin/koha/admin/authorised_values.pl? op = & id = add_form and Patron attribute types gi-bin/koha/admin/patron-attr-types.pl? edit_attribute_type = op & code = [^] and Item types / cgi-bin/koha/admin/itemtypes.pl? op = add_form & itemtype = link each code to a branchcode list. Then the administrator can choose to link a code (category, attribute, value allowed) to a specific branchcode Interest: each librarie will see that its codes. Each librarie will be able to secure the access and the use of its codes in a network. The filter should apply to the following screens: MEMBERS .. / cgi-bin / koha / members / members-home.pl [^] .. / cgi-bin / koha / members / memberentry.pl? op = add & CategoryCode = [^] .. / cgi-bin / koha / members / memberentry.pl? op = add & CategoryCode = [^] PERIODICAL ... / cgi-bin / koha / serials / subscription-add.pl? op = & mod = SubscriptionId ... ACQUISITIONS ... / cgi-bin / koha / admin / aqbudgets.pl? & op = add_form budget_parent_id = 131 & budget_period_id = .. ... / cgi-bin / koha / acquisition / neworderempty.pl? OrderNumber = 26 & booksellerid = 2 & basketno = ... TOOLS .. / cgi-bin / koha / tools / modborrowers.pl SORT1, SORT2, borrower_attribute, CategoryCode, branchcode ... / cgi-bin / koha / tools / batchMod.p ==> Items.location ==> Items.notforloan ==> items.ccode CATALOGUING / cgi-bin/koha/cataloguing/additem.pl? biblionumber = / cgi-bin/koha/cataloguing/addbiblio.pl? biblionumber = 37202 & op = OPAC .. / cgi-bin / koha / opac-search.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 delaye <stephane.delaye@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Assignee|gmcharlt@gmail.com |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Display the Codes koha |Display of values depending |according to connexion |on the connexion librairy |libraries | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 8939 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8939&action=edit Bug 7919 : Display of values depending on the connexion librairy In a librairies network, we would like to declare specific values just for one (or more) librairy. Here we implement the ability to associate categories, patron attributes types and/or authorised_values with librairies (branches). This patch adds 3 new association tables: - categories_branches ( association table between categories and branches ) - authorised_values_branches ( association table between authorised_values and branches ) - borrower_attribute_types_branches (association table between borrower_attribute_types and branches ) Plan test: - Create (or modify) categories, patron attributes and authorised_values and link it with one (or more) library. - Set one of these librairies - Go to one of the multiple pages where this specific value must be displayed and check that it does appear. - Set a librairy not concerned. - Check on the same pages this value is doest not appear. A page list: cataloguing/addbiblio.pl cataloguing/additems.pl members/members-home.pl members/memberentry.pl acqui/neworderempty.pl tools/import_borrowers.pl and others ? Please say me if filters don't work on some pages. Take no account of filters on item types. They are not impletemented by this development -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 delaye <stephane.delaye@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 delaye <stephane.delaye@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from delaye <stephane.delaye@biblibre.com> --- i have this error message when i go in ..cgi-bin/koha/members/members-home.pl Software error: Can't use an undefined value as an ARRAY reference at /home/koha/src/C4/Category.pm line 86. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8939|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 9170 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9170&action=edit Bug 7919 :Bug 7919 : Display of values depending on the connexion librairy Display of values depending on the connexion librairy Rebased patch Stephane, I don't understand your error. Could you check if your database contains the 3 association tables added by this patch? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 --- Comment #4 from delaye <stephane.delaye@biblibre.com> --- I do not have the 3 tables(categories_branches,authorised_values_branches,borrower_attribute_types_branches) in my database after apply the patch in a sandbox ; so I can not test. Can you give me the script mysql to add the tables in the database? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9170|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 9973 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9973&action=edit Bug 7919 : Display of values depending on the connexion librairy Display of values depending on the connexion librairy Rebased patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paul.poulain@biblibre.com --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> --- Patch tested with a sandbox, by Delaye Stephane <stephane.delaye@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9973|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 --- Comment #7 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 9984 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9984&action=edit Bug 7919 : Display of values depending on the connexion librairy In a librairies network, we would like to declare specific values just for one (or more) librairy. Here we implement the ability to associate categories, patron attributes types and/or authorised_values with librairies (branches). This patch adds 3 new association tables: - categories_branches ( association table between categories and branches ) - authorised_values_branches ( association table between authorised_values and branches ) - borrower_attribute_types_branches (association table between borrower_attribute_types and branches ) Plan test: - Create (or modify) categories, patron attributes and authorised_values and link it with one (or more) library. - Set one of these librairies - Go to one of the multiple pages where this specific value must be displayed and check that it does appear. - Set a librairy not concerned. - Check on the same pages this value is doest not appear. A page list: cataloguing/addbiblio.pl cataloguing/additems.pl members/members-home.pl members/memberentry.pl acqui/neworderempty.pl tools/import_borrowers.pl and others :) Please say me if filters don't work on some pages. Signed-off-by: Delaye Stephane <stephane.delaye@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion CC| |ruth@bywatersolutions.com --- Comment #8 from Ian Walls <koha.sekjal@gmail.com> --- I'm all for having more granular control of system features on the branch level, but this patch seems to be doing it in a very ad-hoc, bolt-on way for only certain features. There are lots of other things that would be good to control on a per-branch level, and I'd like to see clean, well thought out approach that can handle these use cases and many others with one approach. While it's certainly more work to do it this way, it would lead to more uniform, clean and understandable code, with lower maintenance costs and better extensibility. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #8) Hi Ian, Yes you are right, it is not very clean. But... it is Koha and I cannot find 10 days to rewrite completely an Authorised Values module. I don't know how filter authorised values functions of the branch level without adding a join on each SELECT query. The authorised value management is, for me, one of the most dirty part of Koha and it could be difficult to make something clean. Likewise, I do not know how it is possible to filter elements simply (here AV, borrower attributes, categories, what else do you think about ?), with the current code of Koha.
I'd like to see clean, well thought out approach that can handle these use cases and many others with one approach
How do you see this approach ? Thanks for your review :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Failed QA --- Comment #10 from Paul Poulain <paul.poulain@biblibre.com> --- I agree with Jonathan's comment here : it is as clean as possible with the current code imo. Rewritting it "from scratch" is another thing. Maybe, as we spoke of the Koha:: during the hackfest, that's something that could emerge here. But it's another topic. I propose to Switch back to "signed off" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 delaye <stephane.delaye@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 --- Comment #11 from Paul Poulain <paul.poulain@biblibre.com> --- Patch tested with a sandbox, by Delaye Stephane <stephane.delaye@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9984|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 --- Comment #12 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 10424 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10424&action=edit Bug 8272 - OPAC : date expiration format Adding TT date filter to output of expiration date on OPAC user page. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Delaye Stephane <stephane.delaye@biblibre.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Signed-off-by: Delaye Stephane <stephane.delaye@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 delaye <stephane.delaye@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10424|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 delaye <stephane.delaye@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9984|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 delaye <stephane.delaye@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9973|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9973|0 |1 is obsolete| | --- Comment #13 from Paul Poulain <paul.poulain@biblibre.com> --- Comment on attachment 9973 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9973 Bug 7919 : Display of values depending on the connexion librairy Display of values depending on the connexion librairy obsoleted by signed off patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #14 from Paul Poulain <paul.poulain@biblibre.com> --- Extensive testing this patch that has not been QAed yet, signed-off since 1 month and a half. QA Comments 1 Patch applies with a small conflict I've solved 2 Usability comment: If there is a library limit on a given value, there's nothing specific displayed on lists in admin. It would be worth to have a column with applicable branches for each value -when there are-. Not worth failing QA though 3 tested = updated a category only visible to librarians from library B. Being connected as librarian from library A, reaching members pages, and checked I can't see this category. 4 tested = adding a limit to afr authorised_values LANG, connected to 101$a (language in UNIMARC). In addbiblio.pl, all the lists appear as empty !!! switching back to master it work well. Seems it's because of the SQL that is built, that returns nothing: SELECT id,authorised_value, lib FROM authorised_values RIGHT JOIN authorised_values_branches ON ( id = av_id AND ( branchcode = 'BDP' OR branchcode IS NULL ) ) WHERE category = 'LANG' GROUP BY lib ORDER BY lib, lib_opac; 5 perlcritic, valid-templates, translatable-templates OK Without point 4, this would have earned QA, but with point 4, it's failed QA, sorry -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Display of values depending |Display of values depending |on the connexion librairy |on the connexion library -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 --- Comment #15 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 11163 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11163&action=edit Bug 7919: Followup: using LEFT JOIN instead of JOIN for 2 files -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #16 from Jonathan Druart <jonathan.druart@biblibre.com> --- Please test last patch on pages cataloguing/addbiblio.pl and tools/batchMod.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 --- Comment #17 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 11168 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11168&action=edit Bug 7919: Followup: Add a column "Branches limitations" for the 3 pages -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Alexandre Lengereau <alexandre.lengereau@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexandre.lengereau@biblibr | |e.com --- Comment #18 from Alexandre Lengereau <alexandre.lengereau@biblibre.com> --- Sandbox test result: Something went wrong ! Applying: Bug 7919 : Display of values depending on the connexion librairy Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging C4/Budgets.pm Auto-merging C4/Input.pm Auto-merging C4/Koha.pm Auto-merging C4/Members.pm Auto-merging C4/Members/AttributeTypes.pm Auto-merging C4/Members/Attributes.pm Auto-merging admin/authorised_values.pl Auto-merging admin/categorie.pl CONFLICT (content): Merge conflict in admin/categorie.pl Auto-merging admin/patron-attr-types.pl Auto-merging cataloguing/addbiblio.pl Auto-merging cataloguing/additem.pl Auto-merging installer/data/mysql/kohastructure.sql Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/categorie.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/categorie.tt Failed to merge in the changes. Patch failed at 0001 Bug 7919 : Display of values depending on the connexion librairy When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Bug 7919 - Display of values depending on the connexion library Bug 7919 : Display of values depending on the connexion librairy Apply? [yn] Patch left in /tmp/Bug-7919--Display-of-values-depending-on-the-conne-hVli22.patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9984|0 |1 is obsolete| | Attachment #11163|0 |1 is obsolete| | Attachment #11168|0 |1 is obsolete| | --- Comment #19 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 11373 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11373&action=edit Bug 7919 : Display of values depending on the connexion library Rebased and squashed patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@univ-lyon3.fr --- Comment #20 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- test with a sandbox : a few points about this patch : 1. In tables patron category administration, authorized values,,patron attributes types, when appears "1 branches limitations" there's a link which point on the actual page : either it doesn't point on the good URL or it wasn't usefull. 2.In the table Patron attribute types, there's an inversion between column actions et column Branches limitations 3.In page members/memberentry.pl, there's no Drop-down menu for sort1 and sort2, so restrictions on Bsort1 and Bsort2 in authorized values can't be apply 4.In additem.pl, i try a restriction on LOST, it works but the value isn't saved 5.In acqui/neworderempty.pl, restrictions about localisation don't work 6.There's no Drop-down menu in tools/import_borrowers.pl Everything is fine in tools/batchMod.pl and with authorised_values LANG in page cataloguing/addbiblio.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 --- Comment #21 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 11751 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11751&action=edit Bug 7919: Followup FIX several behaviours Hi Sonia, (In reply to comment #20)
test with a sandbox : a few points about this patch : 1. In tables patron category administration, authorized values,,patron attributes types, when appears "1 branches limitations" there's a link which point on the actual page : either it doesn't point on the good URL or it wasn't usefull.
Ok, I replaced the "a href" link with a "span" to avoid ambiguity. The limitations appear with a mouseover.
2.In the table Patron attribute types, there's an inversion between column actions et column Branches limitations
Done.
3.In page members/memberentry.pl, there's no Drop-down menu for sort1 and sort2, so restrictions on Bsort1 and Bsort2 in authorized values can't be apply
A bug is corrected. It would work now.
4.In additem.pl, i try a restriction on LOST, it works but the value isn't saved
Hum... It works for me.
5.In acqui/neworderempty.pl, restrictions about localisation don't work
Done.
6.There's no Drop-down menu in tools/import_borrowers.pl
Normaly you can filter on Patron Categories. Now you have Sort1 and 2 too. Thank you for testing ! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 --- Comment #22 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Hi Jonathan,
6.There's no Drop-down menu in tools/import_borrowers.pl
Normaly you can filter on Patron Categories. Now you have Sort1 and 2 too. -> Can you just check with my sandbox, but for me, there's no drop-down menu to choose some value in this page http://pro.salers.biblibre.com/cgi-bin/koha/tools/import_borrowers.pl But, I can miss somthing. Thanks !! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 --- Comment #23 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #22)
-> Can you just check with my sandbox, but for me, there's no drop-down menu to choose some value in this page http://pro.salers.biblibre.com/cgi-bin/koha/tools/import_borrowers.pl But, I can miss somthing.
ho, sorry ! It is not import_borrowers.pl but tools/modborrowers.pl :-/ -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #24 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- For point 4 "In additem.pl, i try a restriction on LOST, it works but the value isn't saved", it's the same this another patch, it must be a problem of settings. Ok for the page tools/modborrowers.pl So everything is ok for me ! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Version|rel_3_8 |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |rel_3_12 --- Comment #25 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Changing target version so this bug report will show up in the list of 3.12-targeted features and doesn't get lost in the shuffle during feature freeze. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high Status|Signed Off |Passed QA Patch complexity|--- |Large patch QA Contact|koha.sekjal@gmail.com |paul.poulain@biblibre.com --- Comment #26 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: * from comment 27 I understand that Koha Team Lyon 3 sign-off the patch, I add their signature * squashed the main patch and the follow-up * koha-qa.pl complain because of POD in CA/Members/Attributes.pm, but the problem was already here. I fixed it during QA * koha-qa.pl complain because of tabs in admin/categorie.pl, but they were already here before, not failing QA for that * koha-qa complain because of "my" variable $sth masks earlier declaration in same scope "my" variable $dbh masks earlier declaration in same scope in admin/categorie.pl, that's added byt this patch, I've fixed that too * checked that things worked, could not find anything wrong * If I had written it myself, I would have added a 'branch' column, with a '*' for default, and used the same rule as for circulation rules, but the way it's done is OK. It will just make caching harder to develop (but that's another topic) * in templates, I feel the span with explanations could be styled a little bit better, but won't fail QA for that, someone (Owen ?) will for sure improve the look if needed Passed QA ! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11373|0 |1 is obsolete| | Attachment #11751|0 |1 is obsolete| | --- Comment #27 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 13736 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13736&action=edit Bug 7919 : Display of values depending on the connexion library In a librairies network, we would like to declare specific values just for one (or more) library. Here we implement the ability to associate categories, patron attributes types and/or authorised_values with librairies (branches). This patch adds 3 new association tables: - categories_branches ( association table between categories and branches ) - authorised_values_branches ( association table between authorised_values and branches ) - borrower_attribute_types_branches (association table between borrower_attribute_types and branches ) Plan test: - Create (or modify) categories, patron attributes and authorised_values and link it with one (or more) library. - Set one of these librairies - Go to one of the multiple pages where this specific value must be displayed and check that it does appear. - Set a library not concerned. - Check on the same pages this value is doest not appear. A page list: cataloguing/addbiblio.pl cataloguing/additems.pl members/members-home.pl members/memberentry.pl acqui/neworderempty.pl tools/import_borrowers.pl and others :) Please say me if filters don't work on some pages. Signed-off-by: Delaye Stephane <stephane.delaye@biblibre.com> Signed-off-by: Koha Team Lyon 3 <koha@univ-lyon3.fr> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Display of values depending |Display of values depending |on the connexion library |on the connexion library | |(authorised values, patron | |categories, extended | |attributes) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Needs Signoff --- Comment #28 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Could I please get another signoff on this patch? It touches some rather core functionality so I'd feel better if it had a little more testing, since I don't use the Acquisitions or Patrons modules very heavily in my day-to-day work. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Melia Meggs <melia@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |melia@bywatersolutions.com --- Comment #29 from Melia Meggs <melia@bywatersolutions.com> --- Hi, I tried to test this patch, but I don't think it's working. After applying the patch, I went to Patron Categories and choose to edit an existing patron category. Under "Branch Limitation," I clicked on one branch name, then clicked save. But when the Patron Category Administration page came back up, it still shows no branch limitation. I then went to Patron Attribute Types and chose to edit an existing attribute. The same thing happened. After choosing a branch and clicking on save, the Patron Attribute Types page reloaded with a message: Modified patron attribute type "HBR" but it still says no branch limitation in the column below. Next, I clicked on Patrons in the top menu bar and got this software error: Can't use an undefined value as an ARRAY reference at /home/melia/kohaclone/C4/Category.pm line 89. For help, please send mail to the webmaster (webmaster@ByWater-Test), giving this error message and the time and date of the error. Hope that helps! Thanks, Melia -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 --- Comment #30 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to comment #29)
Hi,
I tried to test this patch, but I don't think it's working.
Are you sure your database had been updated ? This patch add the following tables: categories_branches authorised_values_branches borrower_attribute_types_branches -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 --- Comment #31 from Jonathan Druart <jonathan.druart@biblibre.com> --- Hi Melia, Thanks for testing. I tested again and it works for me. Could you please check if the 3 queries of the updatedatabase (3 new tables: borrower_attribute_types_branches, categories_branches and authorised_values_branches) are correctly executed ? When you save your changes, there is certainly an error in your Koha log, could you please copy it here ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Melia Meggs <melia@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #32 from Melia Meggs <melia@bywatersolutions.com> --- Ok, thanks! Updatedatabase was the problem. I've run ./installer/data/mysql/updatedatabase.pl and things are looking better now. Here is what I have done to test: 1. Modified two existing patron categories ("Board" and "Kid"). I limited "Board" to Centerville branch and "Kid" to Fairview branch. 2. Modified existing patron attributes ("Driver's License" and "Resident"). I limited "Driver's License" to Midway Branch and "Resident" to Centerville branch. 3. Created two new authorized values (one for the MARC 504 field, and a new collection code) and limited them both to Centerville branch. Then I set the library as Centerville branch. - I went to cataloging to add a new bib record and verified that I can see my new MARC 504 field authorized value in the dropdown menu there. - I searched the catalog for an existing Centerville item to edit and verified that I can see my new collection code authorized value there. - I added a new patron and verified that I can see "Board" as a possible patron category but cannot see "Kid" as a possible patron category - I edited an existing Centerville patron record and verified that I can see "Resident" under Patron Attributes but cannot see "Driver's License" - I went to Acquisitions and created a new order, but I'm not sure what to look at on this page, sorry... - I went to Tools > Import Patrons, but I'm not sure what to look for on this page either. I can see patron_attributes as a choice here, but it doesn't list the specific attributes, so I can't verify whether the one that is limited to this branch shows up or not. Then I set the library as Midway branch. - I went to cataloging to add a new bib record verified that I CANNOT see my new MARC 504 field authorized value there (correct - it was limited to Centerville branch). - I searched the catalog for an existing Midway item to edit and verified that I CANNOT see my new collection code authorized value there (correct - it was limited to Centerville branch). - I added a new patron and verified that I CANNOT see "Board" or "Kid" as possible patron categories (correct - "Board" is limited to Centerville branch, and "Kid" is limited to Fairview branch.) - I edited an existing Midway patron record and verified that I CANNOT see "Resident" under Patron Attributes but can see "Driver's License" (correct - "Resident" is limited to Centerville, but "Driver's License" is limited to Midway) For the pages I was able to test (cataloguing and members), this seems to be working well. I will add my sign off, with the understanding that I did not test acqui/neworderempty.pl or tools/import_borrowers.pl. Thanks, Melia -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Melia Meggs <melia@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13736|0 |1 is obsolete| | --- Comment #33 from Melia Meggs <melia@bywatersolutions.com> --- Created attachment 13862 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13862&action=edit [Signed off] Bug 7919 : Display of values depending on the connexion library In a librairies network, we would like to declare specific values just for one (or more) library. Here we implement the ability to associate categories, patron attributes types and/or authorised_values with librairies (branches). This patch adds 3 new association tables: - categories_branches ( association table between categories and branches ) - authorised_values_branches ( association table between authorised_values and branches ) - borrower_attribute_types_branches (association table between borrower_attribute_types and branches ) Plan test: - Create (or modify) categories, patron attributes and authorised_values and link it with one (or more) library. - Set one of these librairies - Go to one of the multiple pages where this specific value must be displayed and check that it does appear. - Set a library not concerned. - Check on the same pages this value is doest not appear. A page list: cataloguing/addbiblio.pl cataloguing/additems.pl members/members-home.pl members/memberentry.pl acqui/neworderempty.pl tools/import_borrowers.pl and others :) Please say me if filters don't work on some pages. Signed-off-by: Delaye Stephane <stephane.delaye@biblibre.com> Signed-off-by: Koha Team Lyon 3 <koha@univ-lyon3.fr> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Signed-off-by: Melia Meggs <melia@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 --- Comment #34 from Melia Meggs <melia@bywatersolutions.com> --- Oh also, one tiny thing - if you choose to limit to just one branch, it shows up as "1 branches limitations," which should be "1 branch limitation." -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 --- Comment #35 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #32)
For the pages I was able to test (cataloguing and members), this seems to be working well. I will add my sign off, with the understanding that I did not test acqui/neworderempty.pl or tools/import_borrowers.pl.
It is not tools/import_borrowers.pl but tools/modborrowers.pl. I did not update the commit message, sorry. In acqui/neworderempty you can test the statistics (1 and 2) values after selecting a fund (this one has to be linked to 1 or 2 authorized value(s)). (In reply to comment #34)
Oh also, one tiny thing - if you choose to limit to just one branch, it shows up as "1 branches limitations," which should be "1 branch limitation."
A patch is coming. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13862|0 |1 is obsolete| | --- Comment #36 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 13867 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13867&action=edit Bug 7919 : Display of values depending on the connexion library In a librairies network, we would like to declare specific values just for one (or more) library. Here we implement the ability to associate categories, patron attributes types and/or authorised_values with librairies (branches). This patch adds 3 new association tables: - categories_branches ( association table between categories and branches ) - authorised_values_branches ( association table between authorised_values and branches ) - borrower_attribute_types_branches (association table between borrower_attribute_types and branches ) Plan test: - Create (or modify) categories, patron attributes and authorised_values and link it with one (or more) library. - Set one of these librairies - Go to one of the multiple pages where this specific value must be displayed and check that it does appear. - Set a library not concerned. - Check on the same pages this value is doest not appear. A page list: cataloguing/addbiblio.pl cataloguing/additems.pl members/members-home.pl members/memberentry.pl acqui/neworderempty.pl tools/modborrowers.pl and others :) Please say me if filters don't work on some pages. Signed-off-by: Delaye Stephane <stephane.delaye@biblibre.com> Signed-off-by: Koha Team Lyon 3 <koha@univ-lyon3.fr> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Signed-off-by: Melia Meggs <melia@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 --- Comment #37 from Jonathan Druart <jonathan.druart@biblibre.com> --- I updated the commit message in the last patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 --- Comment #38 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 13868 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13868&action=edit Bug 7919: Followup: Fix plural and GetAuthvalueDropbox Remove plural if there is just one branch limitation (authorised_values.tt, categorie.tt and patron-attr-types.tt) FIX a bug in GetAuthvalueDropbox (called by acqui/fetch_sort_dropbox.pl) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #39 from Jonathan Druart <jonathan.druart@biblibre.com> --- The last patch needs a SO. There was a bug in the neworderempty page, fixed. Plurals in 3 pages, fixed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Melia Meggs <melia@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #40 from Melia Meggs <melia@bywatersolutions.com> --- Thanks, Jonathan! I have now tested tools/modborrowers.pl, and the patron categories on that page look good. I also applied your follow up and tested acqui/neworderempty.pl using the Asort1 and Asort2 for Statistics. This works perfectly as well. And thanks for the "1 branch limitation" correction. I can now call this one completely signed off! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Melia Meggs <melia@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13868|0 |1 is obsolete| | --- Comment #41 from Melia Meggs <melia@bywatersolutions.com> --- Created attachment 13891 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13891&action=edit [Signed off] Bug 7919: Followup: Fix plural and GetAuthvalueDropbox Remove plural if there is just one branch limitation (authorised_values.tt, categorie.tt and patron-attr-types.tt) FIX a bug in GetAuthvalueDropbox (called by acqui/fetch_sort_dropbox.pl) Signed-off-by: Melia Meggs <melia@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #42 from Paul Poulain <paul.poulain@biblibre.com> --- passed QA again, the follow-up is small, not a big deal from QA POV -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 --- Comment #43 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- I will be pushing these patches shortly, since they work great, and add a useful feature. However, I'd like to suggest a follow-up. Right now the branch limitations are based on the staff user's branch, but it seems to me that it would be more helpful if the limitations were based on the branch of the object being edited. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #44 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 --- Comment #45 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- (In reply to comment #43)
I will be pushing these patches shortly, since they work great, and add a useful feature. However, I'd like to suggest a follow-up. Right now the branch limitations are based on the staff user's branch, but it seems to me that it would be more helpful if the limitations were based on the branch of the object being edited.
I've been told that comment was unclear. By "staff user's branch," I mean "branch currently set by the staff user," not "staff user's home branch." -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 --- Comment #46 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to comment #45)
(In reply to comment #43)
I will be pushing these patches shortly, since they work great, and add a useful feature. However, I'd like to suggest a follow-up. Right now the branch limitations are based on the staff user's branch, but it seems to me that it would be more helpful if the limitations were based on the branch of the object being edited.
I've been told that comment was unclear. By "staff user's branch," I mean "branch currently set by the staff user," not "staff user's home branch."
Are you saying we should change the behaviour or add a syspref to let the library choose ? The library that sponsored this development wanted that way, and I think most of our libraries will be happy to have it that way. OTOH, I think that, it's like the HomeOrHoldingBranch syspref, some libraries could be interested by the other behaviour (ie= AV depends on the object library, not staff user's branch. I'm not sure I see one of libary needing it this way, but why not. (just to be clear: I don't thin we will do that in a predictable time, as none of our library is requesting it for now) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 --- Comment #47 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- (In reply to comment #46)
(In reply to comment #45)
(In reply to comment #43)
I will be pushing these patches shortly, since they work great, and add a useful feature. However, I'd like to suggest a follow-up. Right now the branch limitations are based on the staff user's branch, but it seems to me that it would be more helpful if the limitations were based on the branch of the object being edited.
I've been told that comment was unclear. By "staff user's branch," I mean "branch currently set by the staff user," not "staff user's home branch."
Are you saying we should change the behaviour or add a syspref to let the library choose ? The library that sponsored this development wanted that way, and I think most of our libraries will be happy to have it that way.
Probably a syspref would be useful. As I said, this is not something to block the feature going in, just a potentially useful addition.
OTOH, I think that, it's like the HomeOrHoldingBranch syspref, some libraries could be interested by the other behaviour (ie= AV depends on the object library, not staff user's branch. I'm not sure I see one of libary needing it this way, but why not. (just to be clear: I don't thin we will do that in a predictable time, as none of our library is requesting it for now)
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 --- Comment #48 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Jenkins caught a problem in t/Members_AttributeTypes.t that I missed (this will teach me to check my PERL5LIB environment variable!). Could I please get a follow-up that fixes this test? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 --- Comment #49 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 13901 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13901&action=edit Bug 7919: Fix unit test (Members_AttributeTypes.t) - Reintroduce the class column in a select statement (was present before this development) - FIX UT: If there are no arg passed in parameter, the routine calls C4::Context->userenv which call an execute statement. It consumes the mocked resultset -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13867|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13891|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13901|0 |1 is obsolete| | --- Comment #50 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 13952 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13952&action=edit Bug 7919: Fix unit test (Members_AttributeTypes.t) - Reintroduce the class column in a select statement (was present before this development) - FIX UT: If there are no arg passed in parameter, the routine calls C4::Context->userenv which call an execute statement. It consumes the mocked resultset Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Elliott Davis <elliott@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13952|0 |1 is obsolete| | --- Comment #51 from Elliott Davis <elliott@bywatersolutions.com> --- Created attachment 13953 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13953&action=edit Bug 7919: Fix unit test (Members_AttributeTypes.t) [Signed-Off] [Passed QA] - Reintroduce the class column in a select statement (was present before this development) - FIX UT: If there are no arg passed in parameter, the routine calls C4::Context->useren Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Elliott Davis <elliott@test.bywatersolutions.com> All tests successful. Files=1, Tests=9, 0 wallclock secs ( 0.02 usr 0.01 sys + 0.16 cusr 0.06 csys = 0.25 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Elliott Davis <elliott@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |elliott@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #52 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Thanks for the follow-up. Pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 --- Comment #53 from Owen Leonard <oleonard@myacpl.org> --- This has broken the "new patron" menu on members-home.pl. categorycodes are not being passed to the template, so although all the category descriptions are listed, each link is the same: /cgi-bin/koha/members/memberentry.pl?op=add&categorycode= -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 --- Comment #54 from Owen Leonard <oleonard@myacpl.org> --- Display of patron categories in patron search results (member.pl) is now broken as well. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Liz Rea (CatalystIT) <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |In Discussion CC| |liz@catalyst.net.nz --- Comment #55 from Liz Rea (CatalystIT) <liz@catalyst.net.nz> --- I confirm Owen's two bugs. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 --- Comment #56 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 14162 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14162&action=edit Bug 7919: FIX the "all" categories method The C4::Category->all method must return fields from the categories table only. Without this patch, there is 2 "categorycode" values, the second one is sometimes undef (if no branch limitation). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13953|0 |1 is obsolete| | Attachment #14162|0 |1 is obsolete| | --- Comment #57 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 14163 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14163&action=edit Bug 7919: FIX the "all" categories method The C4::Category->all method must return fields from the categories table only. Without this patch, there is 2 "categorycode" values, the second one is sometimes undef (if no branch limitation). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion Patch complexity|Large patch |Small patch Severity|new feature |major -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14163|0 |1 is obsolete| | --- Comment #58 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 14184 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14184&action=edit Bug 7919: FIX the "all" categories method The C4::Category->all method must return fields from the categories table only. Without this patch, there is 2 "categorycode" values, the second one is sometimes undef (if no branch limitation). Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14184|0 |1 is obsolete| | --- Comment #59 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 14287 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14287&action=edit Bug 7919: FIX the "all" categories method The C4::Category->all method must return fields from the categories table only. Without this patch, there is 2 "categorycode" values, the second one is sometimes undef (if no branch limitation). same for the GetBorrowercategoryList routine (some category codes are undefined) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical --- Comment #60 from Jonathan Druart <jonathan.druart@biblibre.com> --- I found another place where the problem exists. I increase the priority to critical -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9076 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14287|0 |1 is obsolete| | --- Comment #61 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 14350 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14350&action=edit Bug 7919: FIX the "all" categories method The C4::Category->all method must return fields from the categories table only. Without this patch, there is 2 "categorycode" values, the second one is sometimes undef (if no branch limitation). same for the GetBorrowercategoryList routine (some category codes are undefined) Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Liz Rea (CatalystIT) <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14350|0 |1 is obsolete| | --- Comment #62 from Liz Rea (CatalystIT) <liz@catalyst.net.nz> --- Created attachment 14372 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14372&action=edit Bug 7919: FIX the "all" categories method The C4::Category->all method must return fields from the categories table only. Without this patch, there is 2 "categorycode" values, the second one is sometimes undef (if no branch limitation). same for the GetBorrowercategoryList routine (some category codes are undefined) Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Liz Rea <liz@catalyst.net.nz> Signed off for also fixing problems with patron searching noted by Katrin. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14372|0 |1 is obsolete| | --- Comment #63 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 14377 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14377&action=edit [SIGNED-OFF] Bug 7919: FIX the "all" categories method The C4::Category->all method must return fields from the categories table only. Without this patch, there is 2 "categorycode" values, the second one is sometimes undef (if no branch limitation). same for the GetBorrowercategoryList routine (some category codes are undefined) Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Liz Rea <liz@catalyst.net.nz> Signed off for also fixing problems with patron searching noted by Katrin. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Problems fixed by this patch include: - on patron search result list the category description is shown again - it's possible to limit a patron search to a patron category again All tests pass. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #64 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 --- Comment #65 from Chris Cormack <chris@bigballofwax.co.nz> --- Doesn't apply for 3.10.x but I don't think it is needed, if it is please submit a patch formatted for 3.10.x -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |new feature -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org