[Bug 9151] New: Renewal notice according to patron alert preferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9151 Bug ID: 9151 Summary: Renewal notice according to patron alert preferences Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: vfernandes@keep.pt CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Send to patron a renewal notice, which is almost a new checkout notice. The alert preferences should be the same that the checkout preferences because a renewal is the same that a new checkout. The template notice should be different. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9151 Vitor Fernandes <vfernandes@keep.pt> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high Change sponsored?|--- |Sponsored Assignee|koha-bugs@lists.koha-commun |vfernandes@keep.pt |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9151 --- Comment #1 from Vitor Fernandes <vfernandes@keep.pt> --- Created attachment 13704 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13704&action=edit BUG 9151 - Renewal notice according to patron alert preferences Modifications on AddRenewals and SendCirculationAlert in order to send a renewal notice to the patron according to the patron checkout alert preference. Added a new notice template for renewals notices. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9151 Vitor Fernandes <vfernandes@keep.pt> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9151 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Vitor, I like the idea of a renewal notice :) Do you think you could maybe make it configurable? I can imagine not every library wants to use it and it would make it a bit easier to get it integrated in existing workflows. Ideally I would like to see it on the same level as checkout/return notices with a checkbox in the patron account, but I think a system preference would be ok for now too. The updatedatabase adds the notice template, which is good, but can you maybe provide a follow-up addings it to the sample files for the different languages? They are used for new installations. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9151 Vitor Fernandes <vfernandes@keep.pt> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #3 from Vitor Fernandes <vfernandes@keep.pt> --- Katrin when I done the patch I had doubts about adding a system preference for controlling the renewal notice. Thinking better, it's perfectly natural to have a system preference. Today I'll submit a new patch with that modification and with the translation. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9151 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thanks, Vitor :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9151 --- Comment #5 from Vitor Fernandes <vfernandes@keep.pt> --- Created attachment 13705 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13705&action=edit BUG 9151 - Renewal notice according to patron alert preferences (Patch 2) Added a system preferences (RenewalSendNotice - default no) to controll the renewal notice sending. Added to installer languages the renewal notice template. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9151 Vitor Fernandes <vfernandes@keep.pt> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9151 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13704|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 13913 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13913&action=edit BUG 9151 - Renewal notice according to patron alert preferences Modifications on AddRenewals and SendCirculationAlert in order to send a renewal notice to the patron according to the patron checkout alert preference. Added a new notice template for renewals notices. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9151 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13705|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 13914 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13914&action=edit BUG 9151 - Renewal notice according to patron alert preferences (Patch 2) Added a system preferences (RenewalSendNotice - default no) to controll the renewal notice sending. Added to installer languages the renewal notice template. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9151 --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 13915 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13915&action=edit Bug 9151 - Renewal notice according to patron alert preferences - QA Followup - Fix DB Revs & Grammar -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9151 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13913|BUG 9151 - Renewal notice |[SIGNED-OFF] BUG 9151 - description|according to patron alert |Renewal notice according to |preferences |patron alert preferences -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9151 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13914|BUG 9151 - Renewal notice |[SIGNED-OFF] BUG 9151 - description|according to patron alert |Renewal notice according to |preferences (Patch 2) |patron alert preferences | |(Patch 2) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9151 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9151 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com --- Comment #9 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: * passes koha-qa.pl (some tabs are still here instead of 4 spaces, but they were here before) * the feature itself is nice ! * no side effect I can see passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9151 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13913|0 |1 is obsolete| | Attachment #13914|0 |1 is obsolete| | Attachment #13915|0 |1 is obsolete| | --- Comment #10 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 14215 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14215&action=edit BUG 9151 - Renewal notice according to patron alert preferences Modifications on AddRenewals and SendCirculationAlert in order to send a renewal notice to the patron according to the patron checkout alert preference. Added a new notice template for renewals notices. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9151 --- Comment #11 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 14216 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14216&action=edit BUG 9151 - Renewal notice according to patron alert preferences (Patch 2) Added a system preferences (RenewalSendNotice - default no) to controll the renewal notice sending. Added to installer languages the renewal notice template. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9151 --- Comment #12 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 14217 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14217&action=edit Bug 9151 - Renewal notice according to patron alert preferences - QA Followup - Fix DB Revs & Grammar -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9151 --- Comment #13 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 14218 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14218&action=edit Bug 9151 follow-up: fr-FR translated to french -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9151 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Small patch |Medium patch QA Contact| |paul.poulain@biblibre.com --- Comment #14 from Paul Poulain <paul.poulain@biblibre.com> --- (Updated patch complexity) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9151 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #15 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9151 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |savitra.sirohi@osslabs.biz --- Comment #16 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- *** Bug 6811 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9151 --- Comment #17 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 14477 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14477&action=edit bug 9151 follow-up: fix sample notice SQL for en Fix two different errors that prevented sample notices from being loaded into a fresh English Koha database. Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9151 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9151 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #18 from Galen Charlton <gmcharlt@gmail.com> --- Follow-up patch attached that fixes installation breakage introduced by commit 97b05999. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9151 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Severity|enhancement |blocker --- Comment #19 from Chris Cormack <chris@bigballofwax.co.nz> --- This feature broke installation in english, needs the follow tested and pushed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9151 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14216|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9151 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14217|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9151 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14218|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9151 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14215|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9151 --- Comment #20 from Hugh Davenport <hugh@davenport.net.nz> --- Created attachment 14638 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14638&action=edit bug 9151 follow-up: fix sample notice SQL for en Fix two different errors that prevented sample notices from being loaded into a fresh English Koha database. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Hugh Davenport <hugh@davenport.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9151 Hugh Davenport <hugh@davenport.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9151 Hugh Davenport <hugh@davenport.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14477|0 |1 is obsolete| | Attachment #14638|0 |1 is obsolete| | --- Comment #21 from Hugh Davenport <hugh@davenport.net.nz> --- Created attachment 14639 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14639&action=edit bug 9151 follow-up: fix sample notice SQL for en Fix two different errors that prevented sample notices from being loaded into a fresh English Koha database. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Hugh Davenport <hugh@davenport.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9151 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Blocks| |9413 --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Moving this follow-up to separate bug 9413 as the original feature has already been pushed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9151 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9151 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|blocker |new feature -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org