[Bug 28210] New: C4::Circulation::LostItem should pass through skip_record_index to MarkIssueReturned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28210 Bug ID: 28210 Summary: C4::Circulation::LostItem should pass through skip_record_index to MarkIssueReturned Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org With Bug 27281 we removed a superflous call to update the homebranch of items in transfer. However, this highlighted a test that needed to be removed and lead to the removal of the 'skip_record_index' parameter from the method signature. This lead Nick to spot that we never passed the parameter on to MarkIssueAsReturned when we should.. This bug will add back the parameter in LostItem, add a test for the MarkIssueReturned case and start passing the parameters through properly. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28210 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 120118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120118&action=edit Bug 28210: Unit test Add a unit test to check that skip_record_index is adhered to when passed to LostItem with the force_mark_returned option enabled. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28210 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 120119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120119&action=edit Bug 28210: Pass skip_record_index through LostItem This patch restores the skip_record_index optional parameter for LostItem and passes it through to MarkIssueReturned as required. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28210 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27281 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27281 [Bug 27281] Replace call to `C4::Circulation::DeleteTransfer` with `Koha::Item::Transfer->cancel({ comment => $comment })` in `C4::Circulation::LostItem` -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28210 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24446 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28210 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28210 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28210 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28210 --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- *** Bug 28209 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28210 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28210 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120118|0 |1 is obsolete| | Attachment #120119|0 |1 is obsolete| | --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 120179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120179&action=edit Bug 28210: Unit test Add a unit test to check that skip_record_index is adhered to when passed to LostItem with the force_mark_returned option enabled. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28210 --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 120180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120180&action=edit Bug 28210: Add issue, replacementprice, and set onloan so check-in tests work Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28210 --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 120181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120181&action=edit Bug 28210: Pass skip_record_index through LostItem This patch restores the skip_record_index optional parameter for LostItem and passes it through to MarkIssueReturned as required. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28210 --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- I added some data needed to make the tests pass, can you verify Martin? For testing this also requires applying the follow-ups on 24446 and 27281 While we remove/readd some code in the series I think it makes sense to remove it to fix the tests, then add it as it should have been here -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28210 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28210 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28210 --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28210 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 24446 not in 20.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org