[Bug 28198] New: French sample notices SQL fails: Column count doesn't match value count
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28198 Bug ID: 28198 Summary: French sample notices SQL fails: Column count doesn't match value count Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: victor@tuxayo.net QA Contact: testopia@bugs.koha-community.org DBD::mysql::st execute failed: Column count doesn't match value count at row 15 Row 15 is koha_1 | ('reserves','HOLD_REMINDER','','Waiting hold reminder',0,'You have waiting holds.','Dear [% borrower.firstname %] [% borrower.surname %],\r\n\r\nThe follwing holds are waiting at [% branch.branchname %]:\r\n\\r\n[% FOREACH hold IN holds %]\r\n [% hold.biblio.title %] : waiting since [% hold.waitingdate %]\r\n[% END %]','email'), Git bisect showed that the error is since ea6467724cf8e6fac2224e1dcb6c6ddee73736af Bug 15986: Add sample notice to translated notices Which added the line on row 15 Test plan (with koha testing docker): 1. in .env file set KOHA_MARC_FLAVOUR=unimarc 2. start the instance 3. fail! Full error messages: https://privatebin.deblan.org/?7e440eb0ce80f1f4#6sRbG9qywKQjCNDDHiDSWcrFneDC... Not sure about criticality. Maybe it should be higher that "normal" since it hinders testing unimarc stuff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28198 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15986 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 [Bug 15986] Add a script for sending hold waiting reminder notices -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28198 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_05_candidate Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | Status|NEW |ASSIGNED CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28198 --- Comment #1 from Victor Grousset/tuxayo <victor@tuxayo.net> --- note: workaround: remove from installer/data/mysql/fr-FR/1-Obligatoire/sample_notices.sql The line: ('reserves','HOLD_REMINDER','','Waiting hold reminder',0,'You have waiting holds.','Dear [% borrower.firstname %] [% borrower.surname %],\r\n\r\nThe following holds are waiting at [% branch.branchname %]:\r\n\\r\n[% FOREACH hold IN holds %]\r\n [% hold.biblio.title %] : waiting since [% hold.waitingdate | $KohaDates %]\r\n[% END %]','email'), -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28198 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28198 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 120183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120183&action=edit Bug 28198: Correct sample HOLD_REMINDER notice for French To test: 1 - sudo koha-mysql kohadev 2 - DELETE FROM letter 3 - cat installer/data/mysql/fr-FR/1-Obligatoire/sample_notices.sql | sudo koha-mysql kohadev 4 - Error! 5 - Apply patch 6 - Repeat 1-3 7 - Success! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28198 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120183|0 |1 is obsolete| | --- Comment #3 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 120187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120187&action=edit Bug 28198: Correct sample HOLD_REMINDER notice for French To test: 1 - sudo koha-mysql kohadev 2 - DELETE FROM letter 3 - cat installer/data/mysql/fr-FR/1-Obligatoire/sample_notices.sql | sudo koha-mysql kohadev 4 - Error! 5 - Apply patch 6 - Repeat 1-3 7 - Success! Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28198 --- Comment #4 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 120188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120188&action=edit Bug 28198: Correct sample HOLD_REMINDER notice for it,nb,pl,ru It turns out that ea6467724cf8e6fac2224e1dcb6c6ddee73736af also caused the same issue in these locales Also e0b0e908f767e510c5538d8e5cfb25f994579441 (a follow up) caused the issue in it-IT == Test plan == Paste all this :D ``` # doesn't work without this patch applied echo "DELETE FROM letter;" | sudo koha-mysql kohadev cat installer/data/mysql/nb-NO/1-Obligatorisk/sample_notices.sql | sudo koha-mysql kohadev echo "DELETE FROM letter;" | sudo koha-mysql kohadev cat installer/data/mysql/pl-PL/mandatory/sample_notices.sql | sudo koha-mysql kohadev echo "DELETE FROM letter;" | sudo koha-mysql kohadev cat installer/data/mysql/ru-RU/mandatory/sample_notices.sql | sudo koha-mysql kohadev echo "DELETE FROM letter;" | sudo koha-mysql kohadev cat installer/data/mysql/it-IT/necessari/notices.sql | sudo koha-mysql kohadev # test all the rest ## fixed by previous patch, double checking echo "DELETE FROM letter;" | sudo koha-mysql kohadev cat installer/data/mysql/fr-FR/1-Obligatoire/sample_notices.sql | sudo koha-mysql kohadev ## was already working, just double checking echo "DELETE FROM letter;" | sudo koha-mysql kohadev cat installer/data/mysql/fr-CA/obligatoire/sample_notices.sql | sudo koha-mysql kohadev echo "DELETE FROM letter;" | sudo koha-mysql kohadev cat installer/data/mysql/uk-UA/mandatory/sample_notices.sql | sudo koha-mysql kohadev ``` -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28198 --- Comment #5 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Thanks, it works :D, fr-FR is fixed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28198 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|French sample notices SQL |Sample notices SQL fails on |fails: Column count doesn't |HOLD_REMINDER: Column count |match value count |doesn't match value count -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28198 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28198 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28198 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_05_candidate | Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28198 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 15986 not in 20.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org