http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9126 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 13601 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13601&action=edit Bug 9126: Do not return from Check too early. If there is no errors, it should continue instead of returning true. + move a block of code at the end of Check function. This avoid detaching and re-attaching a HTML block if there are errors. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9126 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Severity|major |critical -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9126 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi all, this is a critical bug in 3.10 - it would be awesome if someone could test and sign-off on this soon. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9126 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.8 |master --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I can reproduce this on master - changing version. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9126 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Julian and Jonathan, I tested on master and on 3.8 - I can't reproduce it apart from that one time I thought it happened. What am I missing? AcqCreateItem = receive UniqueItemFields = barcode - I create a new basket, ordered quantity = 1 - I close the basket and start a new chipment - I receive the items, I tried - only filling out the barcode - only filling out the itemtype -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9126 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Julian, I think that was the crucial bit of information - I had started testing with a partial receive and that was probably the one time I could reproduce the problem. If someone else could sign this off... I could QA it later... -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9126 --- Comment #10 from Julian Maurice <julian.maurice@biblibre.com> --- Hello Kyle, I think the additional item is not created because of "unique key" on items.barcode. You may see in log file something like this: DBD::mysql::st execute failed: Duplicate entry '013' for key 'itembarcodeidx at /home/julian/koha/src/C4/Items.pm line 2105 DBD::mysql::st execute failed: Column 'itemnumber' cannot be null at /home/julian/koha/src/C4/Acquisition.pm line 1094. Try the following steps: - create order with quantity=2 and go to receipt page - fill the item form for the first item with a unique barcode and click 'add' - in the new item form change barcode so it is unique too but do not click on 'add' - click 'Save' - you should have 2 items created but parcel.pl indicates only 1 item received. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9126 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13764|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 14290 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14290&action=edit [SIGNED-OFF] Bug 9126: Do not return from Check too early. If there is no errors, it should continue instead of returning true. + move a block of code at the end of Check function. This avoid detaching and re-attaching a HTML block if there are errors. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> The following queries show us the issues: select count(*) from items; select * from aqorders_items where ordernumber=XX; Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> To test: AcqCreateItem = receive UniqueItemFields = barcode 1) Create a new basket 2) Create a new order with quantity > 1 3) Close the basket and create a new invoice/shipment 4) Receive only 1 item. - Fill out the first item form with item type only. Click add. - Don't change second item form at all. - Click save. Before patch: 2 items are created on the record, both with the selected itemtype. After patch: Only 1 item is created, which is correct. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9126 Elliott Davis <elliott@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |elliott@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9126 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #14 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x and 3.10.x -- You are receiving this mail because: You are watching all bug changes.