[Bug 7678] New: stat wizrad :patron
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7678 Priority: P5 - low Change sponsored?: --- Bug ID: 7678 Assignee: gmcharlt@gmail.com Summary: stat wizrad :patron QA Contact: koha.sekjal@gmail.com Severity: enhancement Classification: Unclassified OS: All Reporter: stephane.delaye@biblibre.com Hardware: All Status: NEW Version: rel_3_8 Component: Reports Product: Koha The patron stat wizard ( http://koha-community:8080/cgi-bin/koha/reports/borrowers_stats.pl) should also support filter by extended attributes (with the exclusion of those being defined as password) For those who are related to authorised_values, the wizard will display the list on the filter column. Add filter and information : patron branch Add filter and information dateenrolled (after / before) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7678 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt@gmail.com |julian.maurice@biblibre.com --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 11445 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11445&action=edit Bug 7678: Adds extended patron attributes in patron reports This patch allows to choose row and column amongst extended patron attributes and to filter on them in reports/borrower_stats.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7678 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|stat wizrad :patron |Statistics wizard: patrons -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7678 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11445|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 11597 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11597&action=edit [SIGNED-OFF] Bug 7678: Adds extended patron attributes in patron reports This patch allows to choose row and column amongst extended patron attributes and to filter on them in reports/borrower_stats.pl Signed-off-by: Marc Veron <veron@veron.ch> Great, I was looking for such a feature. Patch works as expected. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7678 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7678 claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez@biblibre.c | |om -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7678 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comments: 1/ In the routine "calculate", the variables $line and $digit have to be escaped. 2/ Maybe this line: for (my $i = 0; $i <= scalar @$filters; $i++) { could be replaced with for my $i ( 0 .. scalar @$filters ) { For more readability (not mandatory) :) Marked as Failed QA for 1 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7678 --- Comment #4 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 11687 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11687&action=edit Bug 7678: follow-up to pass QA Check input parameters to avoid SQL injection Rewrite a for loop for readability -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7678 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7678 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7678 --- Comment #5 from delaye <stephane.delaye@biblibre.com> --- i test the patch in a sandbox but does not work , i have a white screen when i run the report.....and when i select a patron attributes in the report and i don't see the filter dateenrolled (after / before) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7678 MathildeF <mathilde.formery@ville-nimes.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathilde.formery@ville-nime | |s.fr --- Comment #6 from MathildeF <mathilde.formery@ville-nimes.fr> --- also tested in a sandbox no white screen for me but: - Filters on authorised_value does not work: I have selected a single value, and the results table displays all the values - I dont see "dateenrolled" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7678 claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #7 from claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> --- I change the patch status for review. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7678 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11687|0 |1 is obsolete| | --- Comment #8 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 12742 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12742&action=edit Bug 7678: follow-up to pass QA Check input parameters to avoid SQL injection Rewrite a for loop for readability -- Previous patch didn't take into account patron attributes. That's why we had blank screen. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7678 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7678 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12742|0 |1 is obsolete| | --- Comment #9 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 12753 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12753&action=edit Bug 7678: follow-up to pass QA Check input parameters to avoid SQL injection Rewrite a for loop for readability -- Improved checks on patron attribute types -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7678 Koha Team AMU <koha.aixmarseille@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha.aixmarseille@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7678 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11597|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 12941 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12941&action=edit [SIGNED-OFF] Bug 7678: Adds extended patron attributes in patron reports This patch allows to choose row and column amongst extended patron attributes and to filter on them in reports/borrower_stats.pl Signed-off-by: Marc Veron <veron@veron.ch> Great, I was looking for such a feature. Patch works as expected. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7678 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12753|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 12942 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12942&action=edit [SIGNED-OFF] Bug 7678: follow-up to pass QA Check input parameters to avoid SQL injection Rewrite a for loop for readability Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7678 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7678 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jcamins@cpbibliography.com --- Comment #12 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Is this patch for 3.8 only? If not, please update the version listed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7678 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Version|3.8 |master --- Comment #13 from Julian Maurice <julian.maurice@biblibre.com> --- This is an enhancement, so this is for master. Version updated accordingly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7678 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de QA Contact|koha.sekjal@gmail.com |katrin.fischer@bsz-bw.de --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Script fails perlcritic before and after applying the test: Subroutine prototypes used at line 149, column 1. See page 194 of PBP. (Severity: 5) Subroutine prototypes used at line 154, column 1. See page 194 of PBP. (Severity: 5) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7678 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7678 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12941|0 |1 is obsolete| | Attachment #12942|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 13829 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13829&action=edit [SIGNED-OFF] Bug 7678: Adds extended patron attributes in patron reports This patch allows to choose row and column amongst extended patron attributes and to filter on them in reports/borrower_stats.pl Signed-off-by: Marc Veron <veron@veron.ch> Great, I was looking for such a feature. Patch works as expected. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7678 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 13830 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13830&action=edit [SIGNED-OFF] Bug 7678: follow-up to pass QA Check input parameters to avoid SQL injection Rewrite a for loop for readability Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All tests pass, perlcritic is unchanged. Test plan - Verify ExtendedPatronAttributes hides/shows new patron attribute search criteria - Verify patron attribute show up correctly - pull down list for attributes linked to authorized values - input field for other attributes - Verify search works correctly -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7678 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #17 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- I love the idea, unfortunately I found a problem: if you do a report on an extended attribute that permits both NULL *and* zero values the zero values are not shown: branchcode / SHOW_BCODE 1 NULL TOTAL CPL 1 1 FRL 9 9 MPL 18 18 PVL 1 1 SPL 1 20 22 TOTAL 0 1 49 51 There is one patron at SPL with SHOW_BCODE set to 0, a fact which is not reflected either in the SPL line or the total. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7678 --- Comment #18 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 13975 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13975&action=edit Bug 7678: Adds extended patron attributes in patron reports Fix bug that prevented zero values to be shown in the results. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7678 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #19 from Julian Maurice <julian.maurice@biblibre.com> --- Thanks for the tests Jared, patch above should fix the problem. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7678 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13975|0 |1 is obsolete| | --- Comment #20 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 14710 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14710&action=edit [SIGNED-OFF] Bug 7678: Adds extended patron attributes in patron reports Fix bug that prevented zero values to be shown in the results. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7678 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7678 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7678 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14710|0 |1 is obsolete| | --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 14728 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14728&action=edit [SIGNED-OFF] Bug 7678: Adds extended patron attributes in patron reports Fix bug that prevented zero values to be shown in the results. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Fixes the problem with differentiating 0 and NULL values. Passes all tests. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7678 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #22 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7678 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #23 from Julian Maurice <julian.maurice@biblibre.com> --- Ok in master. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org